Home GnuPG

Remove Exception typehint to fix T9637
d5b4421792e5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove Exception typehint to fix T9637

Summary:
Parse errors are caught by the error handler in PHP7, but they may not be of the type Exception
Remove type-hinting so that we can catch them and deal with them

Test Plan: arc unit --everything

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T9637

Differential Revision: https://secure.phabricator.com/D14342

Details

Provenance
Michael Krasnow <mnkras@gmail.com>Authored on Oct 26 2015, 7:34 PM
Parents
rPHUTILfe7d8c21a808: Improve UTF8StringTruncator behavior for huge inputs
Branches
Unknown
Tags
Unknown

Event Timeline

Michael Krasnow <mnkras@gmail.com> committed rPHUTILd5b4421792e5: Remove Exception typehint to fix T9637 (authored by Michael Krasnow <mnkras@gmail.com>).Oct 26 2015, 7:34 PM