Home GnuPG
Diffusion libphutil e0dd9c4efda1

Fix an issue with removing bytes in PhutilRope
e0dd9c4efda1Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix an issue with removing bytes in PhutilRope

Summary: Via HackerOne, although this is not a security issue. PhutilRope does have a bug with byte handling, though.

Test Plan: Added a failing test and made it pass.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14801

Details

Provenance
epriestley <git@epriestley.com>Authored on Dec 16 2015, 9:26 PM
Parents
rPHUTIL4a09be9ffd4a: Read profile images from Google OAuth correctly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILe0dd9c4efda1: Fix an issue with removing bytes in PhutilRope (authored by epriestley <git@epriestley.com>).Dec 16 2015, 9:32 PM

Changes (2)

PathSize
src/
utils/
__tests__/

rPHUTILe0dd9c4efda1

View Options

src/utils/PhutilRope.php

Loading...
View Options

src/utils/__tests__/PhutilRopeTestCase.php

Loading...