Home GnuPG

Disambiguate "host.com:123" as a port, not a relative path
e9e79fd8d7f5Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Disambiguate "host.com:123" as a port, not a relative path

Summary:
Ref T11222. When we parse "host.com:123", it could be a Git-style URI pointing at the file named "123" on the host. We currently interpret it as such.

Instead, always assume that completely numeric "paths" are port numbers.

Test Plan: Added failing test; made it pass.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11222

Differential Revision: https://secure.phabricator.com/D16187

Details

Provenance
epriestley <git@epriestley.com>Authored on Jun 28 2016, 11:37 PM
Parents
rPHUTIL5796beffff16: Censor credentials with "********" instead of "xxxxx"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILe9e79fd8d7f5: Disambiguate "host.com:123" as a port, not a relative path (authored by epriestley <git@epriestley.com>).Jun 28 2016, 11:58 PM