Home GnuPG

Plug memory leak with PhutilErrorTrap
eef230eaccc6Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Plug memory leak with PhutilErrorTrap

Summary:
Since PhutilErrorTrap registers itself with PhutilErrorHandler, it still has a positive refcount after unset() and is not destroyed. Destroy it explicitly.

(I didn't test this well in the original revision. :/)

Test Plan: Ran phd debug phabricatorbot <config> -- --trace-memory and saw climbing memory usage before this patch. After this patch, saw steady usage.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, staticshock

Differential Revision: https://secure.phabricator.com/D6788

Details

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILeef230eaccc6: Plug memory leak with PhutilErrorTrap (authored by epriestley <git@epriestley.com>).Aug 20 2013, 10:56 PM