Paths

Table of Contentst

Make error handling for ICS parsing more robust
f8af794b2135Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Make error handling for ICS parsing more robust

Summary:
Ref T10747. This mostly adds a bunch of test cases for the ICS format syntax errors, and fixes a couple of issues:

Multiple VCALENDAR sections in one .ics file is legal according to the spec.
Had some bugs with parsing properties with multiple parameters.
Tighten up the regexp for property names.
Show a lot more detail about what went wrong when parsing fails.

Test Plan: Ran unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16521

Details

Provenance

epriestley <git@epriestley.com>

Authored on Sep 8 2016, 11:41 PM

Parents

rPHUTIL0107c187b6d8: Add a very basic ICS syntax parser

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUTILf8af794b2135: Make error handling for ICS parsing more robust (authored by epriestley <git@epriestley.com>).Sep 12 2016, 4:22 PM

Changes (22)

Path

Size

src/

__phutil_library_map__.php

parser/

calendar/

data/

PhutilCalendarRawNode.php

PhutilCalendarRootNode.php

ics/

PhutilICSParser.php

PhutilICSParserException.php

__tests__/

PhutilICSParserTestCase.php

data/

err-bad-base64.ics

err-bad-boolean.ics

err-extra-end.ics

err-initial-unfold.ics

err-malformed-double-quote.ics

err-malformed-parameter.ics

err-malformed-property.ics

err-missing-end.ics

err-missing-value.ics

err-mixmatched-sections.ics

err-root-property.ics

err-unescaped-backslash.ics

err-unexpected-child.ics

err-unexpected-text.ics

good-boolean.ics

multiple-vcalendars.ics

rPHUTILf8af794b2135

View Options

src/__phutil_library_map__.php

View Options

src/parser/calendar/data/PhutilCalendarRawNode.php

View Options

src/parser/calendar/data/PhutilCalendarRootNode.php

View Options

src/parser/calendar/ics/PhutilICSParser.php

View Options

src/parser/calendar/ics/PhutilICSParserException.php

View Options

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

View Options

src/parser/calendar/ics/tests/data/err-bad-base64.ics

View Options

src/parser/calendar/ics/tests/data/err-bad-boolean.ics

View Options

src/parser/calendar/ics/tests/data/err-extra-end.ics

View Options

src/parser/calendar/ics/tests/data/err-initial-unfold.ics

View Options

src/parser/calendar/ics/tests/data/err-malformed-double-quote.ics

View Options

src/parser/calendar/ics/tests/data/err-malformed-parameter.ics

View Options

src/parser/calendar/ics/tests/data/err-malformed-property.ics

View Options

src/parser/calendar/ics/tests/data/err-missing-end.ics

View Options

src/parser/calendar/ics/tests/data/err-missing-value.ics

View Options

src/parser/calendar/ics/tests/data/err-mixmatched-sections.ics

View Options

src/parser/calendar/ics/tests/data/err-root-property.ics

View Options

src/parser/calendar/ics/tests/data/err-unescaped-backslash.ics

View Options

src/parser/calendar/ics/tests/data/err-unexpected-child.ics

View Options

src/parser/calendar/ics/tests/data/err-unexpected-text.ics

View Options

src/parser/calendar/ics/tests/data/good-boolean.ics

View Options

src/parser/calendar/ics/tests/data/multiple-vcalendars.ics

Make error handling for ICS parsing more robustf8af794b2135UnpublishedActions

Unpublished Commit · Learn More

Description

Details

Event Timeline

Changes (22)

rPHUTILf8af794b2135

src/__phutil_library_map__.php

src/parser/calendar/data/PhutilCalendarRawNode.php

src/parser/calendar/data/PhutilCalendarRootNode.php

src/parser/calendar/ics/PhutilICSParser.php

src/parser/calendar/ics/PhutilICSParserException.php

src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php

src/parser/calendar/ics/__tests__/data/err-bad-base64.ics

src/parser/calendar/ics/__tests__/data/err-bad-boolean.ics

src/parser/calendar/ics/__tests__/data/err-extra-end.ics

src/parser/calendar/ics/__tests__/data/err-initial-unfold.ics

src/parser/calendar/ics/__tests__/data/err-malformed-double-quote.ics

src/parser/calendar/ics/__tests__/data/err-malformed-parameter.ics

src/parser/calendar/ics/__tests__/data/err-malformed-property.ics

src/parser/calendar/ics/__tests__/data/err-missing-end.ics

src/parser/calendar/ics/__tests__/data/err-missing-value.ics

src/parser/calendar/ics/__tests__/data/err-mixmatched-sections.ics

src/parser/calendar/ics/__tests__/data/err-root-property.ics

src/parser/calendar/ics/__tests__/data/err-unescaped-backslash.ics

src/parser/calendar/ics/__tests__/data/err-unexpected-child.ics

src/parser/calendar/ics/__tests__/data/err-unexpected-text.ics

src/parser/calendar/ics/__tests__/data/good-boolean.ics

src/parser/calendar/ics/__tests__/data/multiple-vcalendars.ics

Make error handling for ICS parsing more robust
f8af794b2135Unpublished
Actions

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

src/parser/calendar/ics/tests/data/err-bad-base64.ics

src/parser/calendar/ics/tests/data/err-bad-boolean.ics

src/parser/calendar/ics/tests/data/err-extra-end.ics

src/parser/calendar/ics/tests/data/err-initial-unfold.ics

src/parser/calendar/ics/tests/data/err-malformed-double-quote.ics

src/parser/calendar/ics/tests/data/err-malformed-parameter.ics

src/parser/calendar/ics/tests/data/err-malformed-property.ics

src/parser/calendar/ics/tests/data/err-missing-end.ics

src/parser/calendar/ics/tests/data/err-missing-value.ics

src/parser/calendar/ics/tests/data/err-mixmatched-sections.ics

src/parser/calendar/ics/tests/data/err-root-property.ics

src/parser/calendar/ics/tests/data/err-unescaped-backslash.ics

src/parser/calendar/ics/tests/data/err-unexpected-child.ics

src/parser/calendar/ics/tests/data/err-unexpected-text.ics

src/parser/calendar/ics/tests/data/good-boolean.ics

src/parser/calendar/ics/tests/data/multiple-vcalendars.ics