Add missing fd support to ksba_reader_t.
ClosedPublic

Authored by kai on Jul 21 2017, 7:14 PM.

Details

Summary
  • Also adds simple ksba_reader_t tests.

GnuPG-bug-id: 3072

Test Plan

run the test suite

Diff Detail

Repository
rK libksba
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kai created this revision.Jul 21 2017, 7:14 PM
marcus requested changes to this revision.Jul 21 2017, 8:31 PM
marcus added inline comments.
tests/t-reader.c
187

This doesn't work with out-of-source-tree builds. You need to prepend getenv("srcdir"), cf. https://dev.gnupg.org/source/libassuan/browse/master/tests/common.h;859f9a9754708572a6289853d7d95b9ee3eae589$197

This revision now requires changes to proceed.Jul 21 2017, 8:31 PM
werner added inline comments.Jul 24 2017, 9:56 AM
tests/t-reader.c
2

s/t-dnparser.c/t-reader.c/

28

You can't include this unconditionally.

84

Pleade don't use "fd" for FILE object. "fp" or "stream" are commonly used names.

kai updated this revision to Diff 1294.Jul 28 2017, 5:35 PM
kai marked 4 inline comments as done.

Remove use of mmap(), allow out-of-source builds.

kai abandoned this revision.Aug 9 2017, 3:33 PM

Commited as c7f4ef5

This revision was automatically updated to reflect the committed changes.