Add missing fd support to ksba_reader_t.
ClosedPublic
Actions

Authored by kai on Jul 21 2017, 7:14 PM.

Details

Reviewers

marcus
werner

Commits

Summary

GnuPG-bug-id: 3072

Test Plan

run the test suite

Repository

rK libksba

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

marcus requested changes to this revision.Jul 21 2017, 8:31 PM

marcus added inline comments.

tests/t-reader.c
186	This doesn't work with out-of-source-tree builds. You need to prepend getenv("srcdir"), cf. https://dev.gnupg.org/source/libassuan/browse/master/tests/common.h;859f9a9754708572a6289853d7d95b9ee3eae589$197

This revision now requires changes to proceed.Jul 21 2017, 8:31 PM

tests/t-reader.c
1	s/t-dnparser.c/t-reader.c/
27	You can't include this unconditionally.
83	Pleade don't use "fd" for FILE object. "fp" or "stream" are commonly used names.