Add missing fd support to ksba_reader_t.
ClosedPublic
Actions

Authored by kai on Jul 21 2017, 7:14 PM.

Details

Reviewers

marcus
werner

Commits

rKc7f4ef5b5ebc: Add missing fd support to ksba_reader_t.

Summary

GnuPG-bug-id: 3072

Test Plan

run the test suite

Repository

rK libksba

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tests/t-reader.c
187	This doesn't work with out-of-source-tree builds. You need to prepend getenv("srcdir"), cf. https://dev.gnupg.org/source/libassuan/browse/master/tests/common.h;859f9a9754708572a6289853d7d95b9ee3eae589$197

This revision now requires changes to proceed.Jul 21 2017, 8:31 PM

tests/t-reader.c
2	s/t-dnparser.c/t-reader.c/
28	You can't include this unconditionally.
84	Pleade don't use "fd" for FILE object. "fp" or "stream" are commonly used names.

Remove use of mmap(), allow out-of-source builds.

Commited as c7f4ef5

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1292	ab23f39		Jul 21 2017, 7:14 PM	★	★
Diff 2	1294	ab23f39	Remove use of mmap(), allow out-of-source builds.	Jul 28 2017, 5:35 PM	★	★
Diff 3	1303	ab23f39	rKc7f4ef5b5ebc8d6be2c56f14da999a36735a2eba	Aug 9 2017, 3:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4527c2e6f4fe	e3523959ea49	ab23f39a91b5	seu	Add missing fd support to ksba_reader_t.	Jul 28 2017, 4:46 PM