Differential D503

fix undefined-shift in block_filter
AcceptedPublic
Actions

Authored by ltx on Jun 12 2020, 5:18 AM.

Details

Reviewers
gniibe
Group Reviewers
gnupg
Maniphest Tasks
T4975: undefined-shift in block_filter
Summary

force to 'size_t' before shift

* common/iobuf.c (block_filter): add size_t.
  • Signed-off-by: lutianxiong <lutianxiong@huawei.com>
Test Plan
  1. make check
  2. run oss-fuzz

Diff Detail

Repository
rG GnuPG
Lint
Lint Skipped
Unit
Unit Tests Skipped
ltx created this revision.Jun 12 2020, 5:18 AM
ltx edited the summary of this revision. (Show Details)Jun 12 2020, 5:24 AM
ltx edited the test plan for this revision. (Show Details)
ltx edited the summary of this revision. (Show Details)
ltx edited the test plan for this revision. (Show Details)
gniibe added a subscriber: gniibe.Jul 10 2020, 4:26 AM

Thanks for the patch.
I see your point in T4975: undefined-shift in block_filter.
You are right that we have a problem of possible overflow (which could be kicked by fuzzing) here.
(The actual impact would be small, though).

gniibe accepted this revision.Dec 7 2020, 4:07 AM
This revision is now accepted and ready to land.Dec 7 2020, 4:07 AM

Revision Contents

PathPackages
Mcommon/iobuf.c (2 lines)

Diff 1428

View Options

common/iobuf.c

Loading...