Page MenuHome GnuPG

gniibe (NIIBE Yutaka)
UserAdministrator

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:47 PM (215 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Tue, May 11

gniibe changed the status of T5430: "free(): invalid pointer" from --clearsign from Open to Testing.
Tue, May 11, 8:43 AM · gnupg (gpg23)
gniibe added a comment to T5430: "free(): invalid pointer" from --clearsign.

Sorry, it's my fault.
Fixed in rGac731dbbbd21: gpg: Fix allocation for EXTRAHASH..

Tue, May 11, 7:50 AM · gnupg (gpg23)
gniibe committed rGac731dbbbd21: gpg: Fix allocation for EXTRAHASH. (authored by gniibe).
gpg: Fix allocation for EXTRAHASH.
Tue, May 11, 7:50 AM
gniibe added a comment to T5428: PC/SC detecting removal of card.

On Windows, smartcard is also used by logon/logout and certificates handling. Those may be related.

Tue, May 11, 3:47 AM · Windows, scd, Bug Report
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Applied in rG32baa9acfb15: scd: Serialize READER_TABLE access for PC/SC..

Tue, May 11, 3:42 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Please note that we don't use lock in apdu_dev_list_start/finish any more.
Use of lock is narrowed, only within apdu_open_reader function.

Tue, May 11, 3:41 AM · gnupg (gpg23), scd
gniibe committed rG32baa9acfb15: scd: Serialize READER_TABLE access for PC/SC. (authored by gniibe).
scd: Serialize READER_TABLE access for PC/SC.
Tue, May 11, 3:39 AM

Mon, May 10

gniibe added a comment to E864: Weekly Standup.

Last week:

This week:

Mon, May 10, 9:47 AM
gniibe is attending E864: Weekly Standup.
Mon, May 10, 9:44 AM
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Make the lock holding narrower, and it allows no exposing reader_table_lock.

Mon, May 10, 7:52 AM · gnupg (gpg23), scd
gniibe added inline comments to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.
Mon, May 10, 7:51 AM · gnupg (gpg23), scd
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Exposing reader_table_lock would be better.
I found a dead-lock condition when apdu_close_reader is called during apdu_dev_list_start/finish.

Mon, May 10, 7:06 AM · gnupg (gpg23), scd
gniibe claimed T5428: PC/SC detecting removal of card.

I wonder if PCSC_SHARE_SHARED is related or not.

Mon, May 10, 6:32 AM · Windows, scd, Bug Report
gniibe created T5428: PC/SC detecting removal of card.
Mon, May 10, 5:40 AM · Windows, scd, Bug Report
gniibe updated the diff for D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

And if the coding style of hiding mutex_lock/mutex_unlock inside different functions matters, we can expose the mutex to its user.

Mon, May 10, 4:32 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

Last commit will be:

Mon, May 10, 4:29 AM · gnupg (gpg23), scd
gniibe committed rGec5591dc4e1f: scd: Fix close_pcsc_reader. (authored by gniibe).
scd: Fix close_pcsc_reader.
Mon, May 10, 3:56 AM
gniibe committed rGcccc9bd5db1f: scd: Make sure releasing PC/SC context. (authored by gniibe).
scd: Make sure releasing PC/SC context.
Mon, May 10, 3:56 AM
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

The second commit is replacing a use case of close_pcsc_reader by clearing pcsc.rdrname and calling release_pcsc_context.
This makes the use of close_pcsc_reader to its original purpose only (== closing PC/SC reader as a method of close_reader).

Mon, May 10, 3:48 AM · gnupg (gpg23), scd
gniibe added a comment to D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.

OK. As I pointed out a commit having multiple things may make analysis difficult, I should have been careful.
So, let me fix the problem by multiple commits.

Mon, May 10, 3:28 AM · gnupg (gpg23), scd

Fri, May 7

gniibe added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

The problem is accesses to reader_table by
(1) scanning reader(s) to open new one
(2) closing reader

Fri, May 7, 6:59 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added a comment to T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe).

I'm testing D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname, but I'm not sure about the impact on Windows.

Fri, May 7, 6:54 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe requested review of D531: Keep holding READER_LOCK_TABLE and make clear distinction among close/releasing_PCSC_context/nullify_rdrname.
Fri, May 7, 6:51 AM · gnupg (gpg23), scd
gniibe reopened T5416: [windows] Smartcards are less reliable under 2.3.1 (requires restarting gpg-agent.exe) as "Open".

The commit rGbb8e3996e44f: scd: Fix problem with reader list becoming empty. removed READER_TABLE_LOCK holding between apdu_dev_list_start and apdu_dev_list_finish, that opens possible stale resource access for CCID driver: reader_table[slot].ccid.handle

Fri, May 7, 6:34 AM · yubikey, scd, gnupg (gpg23), Bug Report
gniibe added projects to T5425: scdaemon.conf reader-port setting broken in 2.3: scd, Testing, gnupg.
Fri, May 7, 6:05 AM · gnupg, Testing, scd, Bug Report
gniibe claimed T5425: scdaemon.conf reader-port setting broken in 2.3.

Thank you for your report.

Fri, May 7, 6:04 AM · gnupg, Testing, scd, Bug Report
gniibe committed rG0498ea8fbd57: scd: Increment PCSC.COUNT correctly. (authored by gniibe).
scd: Increment PCSC.COUNT correctly.
Fri, May 7, 4:27 AM
gniibe committed rG5d1b41310682: scd: Fix memory leak for RDRNAME and serialize access. (authored by gniibe).
scd: Fix memory leak for RDRNAME and serialize access.
Fri, May 7, 4:27 AM
gniibe committed rG039aed9d401f: scd: Fix declarations for PC/SC access. (authored by gniibe).
scd: Fix declarations for PC/SC access.
Fri, May 7, 12:13 AM

Thu, May 6

gniibe committed rG53bdc6288f9b: scd: Recover the partial match for PORTSTR for PC/SC. (authored by gniibe).
scd: Recover the partial match for PORTSTR for PC/SC.
Thu, May 6, 12:26 PM
gniibe committed rGd6fe82d3d169: scd: When reader is specified, make sure only open once. (authored by gniibe).
scd: When reader is specified, make sure only open once.
Thu, May 6, 12:26 PM
gniibe added a comment to T5423: libgcrypt 1.8 ECDH.

Also fixed in version 1.8: rCbd662c090bd4: ecc: Fix the previous commit.

Thu, May 6, 7:16 AM · Debian, libgcrypt
gniibe committed rC5f814e8a4968: ecc: Fix the input length check for Montgomery curve. (authored by gniibe).
ecc: Fix the input length check for Montgomery curve.
Thu, May 6, 6:13 AM
gniibe added a comment to T5423: libgcrypt 1.8 ECDH.

Suppose that the data is 33-byte with the prefix 0x40 (=='@'):

@ L1234567 89abcdef ghijklmn opqrstuM
Thu, May 6, 5:31 AM · Debian, libgcrypt
gniibe triaged T5423: libgcrypt 1.8 ECDH as High priority.
Thu, May 6, 5:23 AM · Debian, libgcrypt
gniibe added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

Or... we could add --disable-ccid-driver as default for macOS.

Thu, May 6, 3:56 AM · MacOS, yubikey, Bug Report
gniibe claimed T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.
Thu, May 6, 3:55 AM · MacOS, yubikey, Bug Report
gniibe added a comment to T5415: YubiKey no longer recognized in GnuPG 2.3.1 on macOS 10.15.7.

If it is built with LIBUSB enabled, please try adding the following to your scdaemon.conf:

disable-ccid
Thu, May 6, 3:54 AM · MacOS, yubikey, Bug Report

Mon, May 3

gniibe added a comment to E863: Weekly Standup.

Last week:

This week:

Mon, May 3, 6:40 AM
gniibe added a project to T5413: Unblock PIN by Reset Code: Testing.
Mon, May 3, 6:33 AM · Testing, gnupg, scd
gniibe is attending E863: Weekly Standup.
Mon, May 3, 6:29 AM
gniibe added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.

@colemickens We don't maintain any ccid udev rules in GnuPG. What do you refer?

Mon, May 3, 6:29 AM · MacOS, Support, scd

Wed, Apr 28

gniibe added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.

Perhaps, if a distro haven't offered setting of USB, it would be better to configure GnuPG build with --disable-ccid-driver and only support scdaemon with PC/SC. GPG for Windows does so.

Wed, Apr 28, 4:05 AM · MacOS, Support, scd
gniibe added a comment to T5409: scdaemon: 'Operation not supported by device' error under macOS after upgrading to 2.3.1.
  1. It's a breaking change for system with both of PC/SC and CCID. T4673 due to T3300
    • If you configure with no libusb, users don't need 'disable-ccid' option.
  2. I don't know how "wide".
  3. In Debian, it is maintained here: https://salsa.debian.org/debian/gnupg2/-/blob/debian/main/debian/scdaemon.udev
  4. Yes.
Wed, Apr 28, 3:59 AM · MacOS, Support, scd
gniibe added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

To set DISPLAY, dbus-update-activation-environment is your friend.

Wed, Apr 28, 3:43 AM · pinentry
gniibe added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

FYI, for me, on a machine with Debian GNU/Linux, I use Sway, it works fine with pinentry-gnome3.

Wed, Apr 28, 3:34 AM · pinentry
gniibe added a comment to rC060c378c050e: ecc: Check the input length for the point..

Backported in rC3f48e3ea37ad: ecc: Check the input length for the point..

Wed, Apr 28, 3:20 AM

Tue, Apr 27

gniibe committed rGf209d7d2db0e: scd: Fix unblock PIN by a Reset Code with KDF. (authored by kirelagin).
scd: Fix unblock PIN by a Reset Code with KDF.
Tue, Apr 27, 1:49 PM
gniibe triaged T5413: Unblock PIN by Reset Code as Normal priority.
Tue, Apr 27, 1:45 PM · Testing, gnupg, scd
gniibe created T5413: Unblock PIN by Reset Code.
Tue, Apr 27, 1:44 PM · Testing, gnupg, scd
gniibe committed rC060c378c050e: ecc: Check the input length for the point. (authored by gniibe).
ecc: Check the input length for the point.
Tue, Apr 27, 10:30 AM

Mon, Apr 26

gniibe added a comment to T1756: gpg-agent doesn't accept ssh certificates.

Update:
It looks like OpenSSH version 8 now supports ssh-agent's handling REQUEST_IDENTITIES.

Mon, Apr 26, 8:32 AM · gnupg, Feature Request
gniibe added a comment to E859: Weekly Standup.

Last week:

This week:

  • Bug fixes
  • Gnuk RSA Removal part 2
Mon, Apr 26, 8:24 AM
gniibe is attending E859: Weekly Standup.
Mon, Apr 26, 8:17 AM

Fri, Apr 23

gniibe closed T5408: gpgconf should? not list disabled components as Resolved.
Fri, Apr 23, 4:20 AM · Bug Report, Windows, gnupg (gpg23)
gniibe accepted D529: po: Update Simplified Chinese Translation..

Thank you.
I'll report the original message problem.
Applied and pushed.

Fri, Apr 23, 4:19 AM
gniibe committed rGad7d2e6fb1b4: po: Update Simplified Chinese Translation. (authored by bobwxc).
po: Update Simplified Chinese Translation.
Fri, Apr 23, 4:19 AM
gniibe committed rG97ba94e52b23: tools: Fix for --disable-tpm2d. (authored by gniibe).
tools: Fix for --disable-tpm2d.
Fri, Apr 23, 4:13 AM

Thu, Apr 22

gniibe added a comment to D529: po: Update Simplified Chinese Translation..

Thank you. Please confirm for one message translation. Others are all good.

Thu, Apr 22, 9:02 AM

Wed, Apr 21

gniibe committed rA8ec3e9f1dd88: build: Update gpg-error.m4. (authored by gniibe).
build: Update gpg-error.m4.
Wed, Apr 21, 4:38 AM
gniibe added a comment to T5408: gpgconf should? not list disabled components.

If it confuses users, we can apply something like this:

diff --git a/tools/gpgconf-comp.c b/tools/gpgconf-comp.c
index 2a5087e1f..12916a64e 100644
--- a/tools/gpgconf-comp.c
+++ b/tools/gpgconf-comp.c
@@ -93,7 +93,9 @@ gc_error (int status, int errnum, const char *fmt, ...)
 /* Forward declaration.  */
 static void gpg_agent_runtime_change (int killflag);
 static void scdaemon_runtime_change (int killflag);
+#ifdef BUILD_WITH_TPM2D
 static void tpm2daemon_runtime_change (int killflag);
+#endif
 static void dirmngr_runtime_change (int killflag);
 static void keyboxd_runtime_change (int killflag);
Wed, Apr 21, 4:36 AM · Bug Report, Windows, gnupg (gpg23)
gniibe updated the task description for T5408: gpgconf should? not list disabled components.
Wed, Apr 21, 4:35 AM · Bug Report, Windows, gnupg (gpg23)
gniibe created T5408: gpgconf should? not list disabled components.
Wed, Apr 21, 4:28 AM · Bug Report, Windows, gnupg (gpg23)
gniibe committed rK72f19cdabfb2: build: Update gpg-error.m4. (authored by gniibe).
build: Update gpg-error.m4.
Wed, Apr 21, 3:52 AM
gniibe closed T5395: libksba coverity static analysis reports as Resolved.

Thank you for your confirmation. Closing.

Wed, Apr 21, 2:46 AM · libksba, Bug Report
gniibe closed T3891: kdf-setup does not set admin and user PIN codes, a subtask of T3823: gpg frontend support to setup KDF DO, as Resolved.
Wed, Apr 21, 2:45 AM · scd
gniibe closed T3891: kdf-setup does not set admin and user PIN codes, a subtask of T3152: KDF DO support in OpenPGP card, as Resolved.
Wed, Apr 21, 2:45 AM · scd
gniibe closed T3891: kdf-setup does not set admin and user PIN codes as Resolved.
Wed, Apr 21, 2:45 AM · Testing, scd, Bug Report
gniibe added a project to T5297: SCM SPR332 smartcard reader support broken: gnupg (gpg22).

Fixed in GnuPG 2.3.1, so, add the tag for GnuPG 2.2.

Wed, Apr 21, 2:44 AM · gnupg (gpg22), scd, Bug Report

Tue, Apr 20

gniibe accepted D501: VPMSUMD accelleration for GCM mode on PPC.

It's in 1.9 already.

Tue, Apr 20, 8:41 AM
gniibe abandoned D509: Yubikey supports two (or more) apps, serial number problem.
Tue, Apr 20, 8:36 AM · gnupg
gniibe abandoned D510: Connection to gpg-agent/dirmngr/etc..

it's in 2.3.

Tue, Apr 20, 8:34 AM · gnupg
gniibe abandoned D513: Support macOS build with SIP by using posix_spawn in tests/random.

Applied.

Tue, Apr 20, 8:32 AM
gniibe accepted D525: doc: Fix swapped constants.

This has been applied already.

Tue, Apr 20, 8:29 AM
gniibe committed rKfbb1f303198b: Fixes for static analysis reports. (authored by Jakuje).
Fixes for static analysis reports.
Tue, Apr 20, 6:33 AM
gniibe added a comment to T5395: libksba coverity static analysis reports.

I applied 1,2,3, and 5 in rKfbb1f303198b: Fixes for static analysis reports.

Tue, Apr 20, 6:32 AM · libksba, Bug Report
gniibe added a comment to T5395: libksba coverity static analysis reports.

I can't see null pointer de-reference (you claimed) in [4/5].
Could you please elaborate?

Tue, Apr 20, 4:47 AM · libksba, Bug Report
gniibe claimed T5395: libksba coverity static analysis reports.
Tue, Apr 20, 2:39 AM · libksba, Bug Report
gniibe closed T5293: gpg-error.m4 should search gpg-error.pc under the paths of gpgrt-config as Resolved.
Tue, Apr 20, 2:36 AM · gpgrt
gniibe closed T5372: assertion failure mulm_25519: different sizes in Libgrypt 1.9 as Resolved.
Tue, Apr 20, 2:29 AM · !assert, Bug Report, libgcrypt
gniibe closed T5384: pinentry coverity static analysis reports as Resolved.
Tue, Apr 20, 2:28 AM · pinentry, Bug Report
gniibe added a comment to T4900: OS X 10.12 and dyld: Library not loaded: /usr/local/lib/libgcrypt.20.dylib.

IIUC, with libgcrypt in LIBGCRYPT-1.8-BRANCH (not yet released) and libgcrypt 1.9.3, the build process works well (the problem with SIP has been handled).

Tue, Apr 20, 2:27 AM · MacOS, libgcrypt, Bug Report
gniibe closed T5375: getentropy usage is forbidden by Apple, but is now being forced by libgcrypt as Resolved.
Tue, Apr 20, 2:12 AM · MacOS, libgcrypt

Mon, Apr 19

gniibe updated subscribers of E858: Weekly Standup.

Last week:
Mostly Gleaning

This week:
Continue for bug fixing like gleaning and

  • RSA removal from Gnuk master
    • key generation and testing key generation -> switch to Ed25519
Mon, Apr 19, 6:45 AM
gniibe committed rT1c2f98da3364: build: Update gpg-error.m4 (authored by gniibe).
build: Update gpg-error.m4
Mon, Apr 19, 5:24 AM
gniibe is attending E858: Weekly Standup.
Mon, Apr 19, 1:27 AM

Fri, Apr 16

gniibe added a comment to T5048: Error handling in libassuan.

Updated:

diff --git a/configure.ac b/configure.ac
index 53a343b..f496729 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,6 +82,7 @@ AC_PROG_AWK
 AC_CHECK_TOOL(AR, ar, :)
 AC_USE_SYSTEM_EXTENSIONS
Fri, Apr 16, 8:50 AM · gpgrt, libassuan
gniibe added a comment to T5384: pinentry coverity static analysis reports.

Fixed in rP7f7fd8bcfd74: tty: Fix error return paths and its resource leaks.

Fri, Apr 16, 5:59 AM · pinentry, Bug Report
gniibe committed rP7f7fd8bcfd74: tty: Fix error return paths and its resource leaks. (authored by gniibe).
tty: Fix error return paths and its resource leaks.
Fri, Apr 16, 5:58 AM
gniibe added a comment to T5384: pinentry coverity static analysis reports.

Actually, calling do_tuch_file when some error(s) are not good.
Let me fix all the things.

Fri, Apr 16, 5:02 AM · pinentry, Bug Report
gniibe closed T5134: GPG - will not sign nor verify the pin when using a contactless reader as Resolved.
Fri, Apr 16, 4:25 AM · Not A Bug, scd, Bug Report
gniibe added a project to T5048: Error handling in libassuan: gpgrt.
Fri, Apr 16, 3:56 AM · gpgrt, libassuan
gniibe added a comment to T5048: Error handling in libassuan.

Sorry, I was wrong. It seems that GNU C library has a feature to avoid bad truncation.

Fri, Apr 16, 3:55 AM · gpgrt, libassuan

Thu, Apr 15

gniibe committed rGPA77a069390073: build: Update m4/gpg-error.m4 (authored by gniibe).
build: Update m4/gpg-error.m4
Thu, Apr 15, 10:35 AM
gniibe committed rGPA240fb98c6e6b: Let autogen.sh create the VERSION file. (authored by gniibe).
Let autogen.sh create the VERSION file.
Thu, Apr 15, 10:35 AM
gniibe committed rGPAfe623eab3d20: po: Update Japanese Translations. (authored by gniibe).
po: Update Japanese Translations.
Thu, Apr 15, 10:35 AM
gniibe committed rCa8d6c6c1b258: cipher: Fix memory leaks for EdDSA. (authored by gniibe).
cipher: Fix memory leaks for EdDSA.
Thu, Apr 15, 9:14 AM
gniibe closed T5385: libgcrypt coverity static analysis reports as Resolved.

Thank you.
We also need to release memory for points.

Thu, Apr 15, 9:13 AM · libgcrypt, Bug Report
gniibe closed T5380: Tools needed during a build lack of CFLAGS was passed durring configure time as Resolved.

mkheader has CFLAGS_FOR_BUILD since libassuan 2.5.4.
gost-s-box has so since libgcrypt 1.9.0.

Thu, Apr 15, 8:41 AM · MacOS, Bug Report
gniibe committed rP6b697bd3e9f8: build: Update m4/gpg-error.m4 (authored by gniibe).
build: Update m4/gpg-error.m4
Thu, Apr 15, 7:33 AM