gniibe (NIIBE Yutaka)Administrator
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:47 PM (181 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

Here are my test configurations.

Fri, Sep 18, 10:15 AM · Bug Report
gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

I think that there is some misunderstanding how gpg-agent and scdaemon run.
In the normal configuration, those program run when you login to your desktop or it is invoked when used, then, after you logout, it dies.

Fri, Sep 18, 5:01 AM · Bug Report
gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

For SSH, I don't think forwarding gpg-agent's socket (S.gpg-agent.ssh) is good; It complicates things unnecessarily. Simply use -A option of SSH, if possible.

Fri, Sep 18, 3:58 AM · Bug Report
gniibe closed T5063: Use of some "SCD" command through extra socket, a subtask of T5062: gpg: error getting version from 'scdaemon': Forbidden, as Resolved.
Fri, Sep 18, 3:55 AM · Bug Report
gniibe closed T5063: Use of some "SCD" command through extra socket as Resolved.
Fri, Sep 18, 3:55 AM · Bug Report
gniibe added a comment to T5063: Use of some "SCD" command through extra socket.

Fixed in master.

Fri, Sep 18, 3:52 AM · Bug Report
gniibe added a comment to T5063: Use of some "SCD" command through extra socket.

"SCD GETINFO card_list" is not needed actually. It was my misunderstanding.

Fri, Sep 18, 3:51 AM · Bug Report
gniibe committed rGdfdcf1473897: common,agent,dirmngr,g10,tools: Fix split_fields API. (authored by gniibe).
common,agent,dirmngr,g10,tools: Fix split_fields API.
Fri, Sep 18, 3:36 AM
gniibe committed rG8a84a71f3a58: agent: Fix regression for access through the extra secket. (authored by gniibe).
agent: Fix regression for access through the extra secket.
Fri, Sep 18, 3:36 AM
gniibe added a commit to T5063: Use of some "SCD" command through extra socket: rG8a84a71f3a58: agent: Fix regression for access through the extra secket..
Fri, Sep 18, 3:36 AM · Bug Report

Thu, Sep 17

gniibe added a comment to T5065: scdaemon doesn't detect card removal after boot/resume (Identiv SPR332v2).

And please report the output of lsusb -d 04e6:e003 for the information of the card reader.

Thu, Sep 17, 8:27 AM · gnupg (gpg22), scd, Bug Report
gniibe added a comment to T5065: scdaemon doesn't detect card removal after boot/resume (Identiv SPR332v2).

@turkja Thanks for your information.
May I ask you one thing?
Please show me the usb VID:PID of your card reader.
Is it 04e6:e003?
You can examine a line of the output by lsusb.

Thu, Sep 17, 8:23 AM · gnupg (gpg22), scd, Bug Report

Wed, Sep 16

gniibe updated the task description for T5001: Card specification enhancement.
Wed, Sep 16, 8:51 AM · Feature Request, scd
gniibe claimed T5065: scdaemon doesn't detect card removal after boot/resume (Identiv SPR332v2).
Wed, Sep 16, 8:04 AM · gnupg (gpg22), scd, Bug Report
gniibe added a comment to T5065: scdaemon doesn't detect card removal after boot/resume (Identiv SPR332v2).

Thanks for sending.

Wed, Sep 16, 8:01 AM · gnupg (gpg22), scd, Bug Report
gniibe added a comment to T5065: scdaemon doesn't detect card removal after boot/resume (Identiv SPR332v2).

Is it an alias of SPR532? Please show me the USB vendor ID and product ID.

Wed, Sep 16, 7:39 AM · gnupg (gpg22), scd, Bug Report
gniibe committed rGf4c07fc3d3c3: scd: Clear caching PIN at KDF setup. (authored by gniibe).
scd: Clear caching PIN at KDF setup.
Wed, Sep 16, 6:15 AM
gniibe committed rG316a8cbc7523: scd: Add better support for KDF feature. (authored by gniibe).
scd: Add better support for KDF feature.
Wed, Sep 16, 6:15 AM
gniibe committed rG8ff36630277f: scd: Clear PIN cache when changing key attributes. (authored by gniibe).
scd: Clear PIN cache when changing key attributes.
Wed, Sep 16, 6:15 AM
gniibe committed rG8dfd0ebfd8cf: gpg,scd: Fix handling of KDF feature. (authored by gniibe).
gpg,scd: Fix handling of KDF feature.
Wed, Sep 16, 5:52 AM
gniibe committed rG61aea64b3c17: scd: Fix the use case of verify_chv2 by CHECKPIN. (authored by gniibe).
scd: Fix the use case of verify_chv2 by CHECKPIN.
Wed, Sep 16, 5:49 AM

Tue, Sep 15

gniibe committed rG6e51f2044aeb: scd: Fix the use case of verify_chv2 by CHECKPIN. (authored by gniibe).
scd: Fix the use case of verify_chv2 by CHECKPIN.
Tue, Sep 15, 8:46 AM

Mon, Sep 14

gniibe added a comment to E775: Weekly Standup.

Last week:

This week:

Mon, Sep 14, 9:34 AM
gniibe is attending E775: Weekly Standup.
Mon, Sep 14, 9:23 AM

Fri, Sep 11

gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

You should not do gpgconf --kill all on your remote machine; It kills gpg-agent on your local machine, through forwarded socket. And next invocation of gpg will invoke gpg-agent on your remote machine, which makes things confusing.

Fri, Sep 11, 9:36 AM · Bug Report
gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

Sorry, my editing error. I wanted write:

Fri, Sep 11, 8:51 AM · Bug Report
gniibe claimed T5062: gpg: error getting version from 'scdaemon': Forbidden.
Fri, Sep 11, 6:39 AM · Bug Report
gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

Perhaps, for the usability, it would be good for gpg-agent's "extra" access to allow some of SCD commands.
This can align the current limitation, I suppose.

Fri, Sep 11, 6:38 AM · Bug Report
gniibe closed T4957: OpenPGP card protocol 3.4 with Yubikey as Resolved.

The data object 0x00FA is now supported. And other changes are not needed.

Fri, Sep 11, 5:17 AM · scd
gniibe created T5063: Use of some "SCD" command through extra socket.
Fri, Sep 11, 4:35 AM · Bug Report
gniibe added a comment to T5062: gpg: error getting version from 'scdaemon': Forbidden.

I think that your configuration does not work well for gpg --card-status when you want to use local scdaemon service from remote machine.
By using "extra" socket, only a few commands are allowed to execute.

Fri, Sep 11, 4:28 AM · Bug Report
gniibe added a project to T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation): Testing.
Fri, Sep 11, 2:20 AM · Testing, ssh, Bug Report
gniibe changed the status of T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation) from Open to Testing.

Fixed in Gnuk 1.2.16, although it still has a limitation by the I/O buffer size.

Fri, Sep 11, 2:19 AM · Testing, ssh, Bug Report

Thu, Sep 10

gniibe committed rGd4cb774ddd88: scd: Flush KDF DO (0x00F9) when it's being set. (authored by gniibe).
scd: Flush KDF DO (0x00F9) when it's being set.
Thu, Sep 10, 8:20 AM

Wed, Sep 9

gniibe triaged T5057: Smartcard's secret key cannot be found for decryption as Normal priority.
Wed, Sep 9, 8:32 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T5057: Smartcard's secret key cannot be found for decryption.

@leder I agree that it is useful if OpenPGP public key can be (directly or indirectly) retrieved from a card.

Wed, Sep 9, 8:31 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T5057: Smartcard's secret key cannot be found for decryption.

Please note that your private keys are on your card, together with finger print information. But there is no place to have OpenPGP public keys on the card. I guess that this is a possible cause of confusion.

Wed, Sep 9, 3:08 AM · gnupg (gpg22), Bug Report
gniibe added inline comments to rG0db9c83555b4: scd: Add a workaround for Yubikey..
Wed, Sep 9, 2:06 AM

Tue, Sep 8

gniibe committed rG2bc1ec294422: gpg,tools: Add handling of supported algorithms by a card. (authored by gniibe).
gpg,tools: Add handling of supported algorithms by a card.
Tue, Sep 8, 8:42 AM
gniibe committed rG0db9c83555b4: scd: Add a workaround for Yubikey. (authored by gniibe).
scd: Add a workaround for Yubikey.
Tue, Sep 8, 4:46 AM

Mon, Sep 7

gniibe committed rG270c49b8c6ea: scd: Fix handling 0x00FA to support OpenPGP card 3.4. (authored by gniibe).
scd: Fix handling 0x00FA to support OpenPGP card 3.4.
Mon, Sep 7, 7:33 AM
gniibe added a comment to E772: Weekly Standup.

Last week:

This week:

  • Release Gnuk 1.2.16
  • Some tests with GD32VG103 (the RISC-V version) to consider flash upgrade process in Gnuk
  • gpg --card-edit/gpg-card checking "Algorithm Information" when it tries to change key-attr for newer cards
Mon, Sep 7, 7:08 AM
gniibe is attending E772: Weekly Standup.
Mon, Sep 7, 6:56 AM

Fri, Sep 4

gniibe committed rG43bbc25b0f57: scd: Support GET DATA response with no header for DO 0x00FA. (authored by gniibe).
scd: Support GET DATA response with no header for DO 0x00FA.
Fri, Sep 4, 10:18 AM
gniibe committed rGeba2563dabbb: scd: Parse "Algorithm Information" data object in scdaemon. (authored by gniibe).
scd: Parse "Algorithm Information" data object in scdaemon.
Fri, Sep 4, 7:46 AM
gniibe added a comment to T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation).

Thanks for your information. No debug output any more, as I already figured out things.

Fri, Sep 4, 1:53 AM · Testing, ssh, Bug Report

Thu, Sep 3

gniibe committed rG90d0072165cc: scd: Add handling of "Algorithm Information" DO. (authored by gniibe).
scd: Add handling of "Algorithm Information" DO.
Thu, Sep 3, 1:03 PM
gniibe updated the task description for T5048: Error handling in libassuan.
Thu, Sep 3, 4:46 AM · libassuan
gniibe created T5048: Error handling in libassuan.
Thu, Sep 3, 4:45 AM · libassuan
gniibe added a comment to T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation).

Well, from the viewpoint of card specification, "a message M of arbitrary size" for Ed25519/Ed448 in RFC8032 is not good, because card has a limit for buffer size and the protocol in the OpenPGP card specification requires the steps of (1) the message M is buffered and then (2) the compute the signature.

Thu, Sep 3, 3:15 AM · Testing, ssh, Bug Report
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

It's a different issue: Gnuk doesn't support length of 3072, only 2048 and 4096.

Thu, Sep 3, 1:54 AM · Testing, gnupg (gpg22), Bug Report

Wed, Sep 2

gniibe claimed T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation).
Wed, Sep 2, 5:42 AM · Testing, ssh, Bug Report
gniibe added a comment to T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation).

I just confirmed that Gnuk has a limitation for the input length is less than or equals to 256.
So, this is the issue of Gnuk, not GnuPG.

Wed, Sep 2, 5:40 AM · Testing, ssh, Bug Report
gniibe added a comment to T5041: gpg-agent/scdaemon/gnuk unable to sign ssh certificate (Couldn't certify key … via agent: agent refused operation).

Please show us concrete example of debug output by scdaemon, when you run ssh-keygen.
You can have a setup in .gnupg/scdaemon.conf like:

Wed, Sep 2, 5:11 AM · Testing, ssh, Bug Report

Tue, Sep 1

gniibe committed rG0a9665187a7c: scd: Fix a regression for OpenPGP card. (authored by gniibe).
scd: Fix a regression for OpenPGP card.
Tue, Sep 1, 8:49 AM
gniibe added a commit to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status: rG0a9665187a7c: scd: Fix a regression for OpenPGP card..
Tue, Sep 1, 8:49 AM · Testing, gnupg (gpg22), Bug Report
gniibe added a project to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status: Testing.

Thanks a lot. Applied and pushed.

Tue, Sep 1, 8:27 AM · Testing, gnupg (gpg22), Bug Report
gniibe updated the task description for T5001: Card specification enhancement.
Tue, Sep 1, 7:23 AM · Feature Request, scd
gniibe triaged T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status as High priority.
Tue, Sep 1, 7:11 AM · Testing, gnupg (gpg22), Bug Report
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

I think that following patch can solve the issue:

Tue, Sep 1, 7:10 AM · Testing, gnupg (gpg22), Bug Report

Mon, Aug 31

gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Ah, I see the situation of the regression.
When the token is not yet accessed at all, scdaemon misunderstood as no signing key.

Mon, Aug 31, 10:20 AM · Testing, gnupg (gpg22), Bug Report
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Do you have a signing key in your card or not?

Mon, Aug 31, 10:18 AM · Testing, gnupg (gpg22), Bug Report
gniibe claimed T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.
Mon, Aug 31, 10:17 AM · Testing, gnupg (gpg22), Bug Report
gniibe added a comment to E771: Weekly Standup.

Topic:

  • UTF-8 handling for LANG=C
    • In some situations, with LANG=C, some people expect UTF-8 (or no-translation) on POSIX, these days
    • With LANG=C, nl_langinfo (CODESET) returns ASCII (ANSI_X3.4-1968) (on GNU/Linux)
      • So, currently, it is handled as iso-8859-1 by GnuPG
    • In future, possibly, it would make sense to change behavior of this corner case, adding special handling of LANG=C
      • When LANG=C or LC_CTYPE=C is detected, it is handled as UTF-8, instead of iso-8859-1
      • Or, emit a warning that it defaults to iso-8859-1

Last week:

This week:

  • Examine the error path(s) of UI of gpg --card-edit and gpg-card, so that it won't confuse users much.
Mon, Aug 31, 4:10 AM
gniibe is attending E771: Weekly Standup.
Mon, Aug 31, 3:47 AM

Fri, Aug 28

gniibe committed rG393dcdd61c3b: common: Fix fallback handling to utf-8. (authored by gniibe).
common: Fix fallback handling to utf-8.
Fri, Aug 28, 8:21 AM
gniibe added a commit to T5038: UTF-8 handling in the command line: rG393dcdd61c3b: common: Fix fallback handling to utf-8..
Fri, Aug 28, 8:21 AM · backport, gnupg
gniibe added a comment to T5038: UTF-8 handling in the command line.

I mean:

diff --git a/common/utf8conv.c b/common/utf8conv.c
index 7804dbfcd..bdab225a9 100644
--- a/common/utf8conv.c
+++ b/common/utf8conv.c
@@ -138,7 +138,7 @@ handle_iconv_error (const char *to, const char *from, int use_fallback)
          native encoding.  Nowadays this seems to be the best bet in
          case of errors from iconv or nl_langinfo.  */
       active_charset_name = "utf-8";
-      no_translation = 0;
+      no_translation = 1;
       use_iconv = 0;
     }
 }
Fri, Aug 28, 7:39 AM · backport, gnupg
gniibe added a subtask for T1514: charset weirdness with non-ascii User IDs under non-UTF-8 locales: T5038: UTF-8 handling in the command line.
Fri, Aug 28, 7:37 AM · Bug Report, gnupg
gniibe added a parent task for T5038: UTF-8 handling in the command line: T1514: charset weirdness with non-ascii User IDs under non-UTF-8 locales.
Fri, Aug 28, 7:37 AM · backport, gnupg
gniibe updated the task description for T5038: UTF-8 handling in the command line.
Fri, Aug 28, 7:25 AM · backport, gnupg
gniibe created T5038: UTF-8 handling in the command line.
Fri, Aug 28, 7:22 AM · backport, gnupg
gniibe added projects to T4710: Cannot use Secure PIN Entry for Reset Code: Documentation, Not A Bug.
Fri, Aug 28, 6:48 AM · Not A Bug, Documentation, OpenPGP, scd, Bug Report
gniibe added a comment to T4817: dirmgr keys.openpgp.org:443 Address family not supported by protocol.

In T4977: dirmngr not working with linux kernel parameter ipv6.disable=1, EAFNOSUPPORT fix was applied in 2.2.22.
I think that original problem in this report is fixed.
Please test with 2.2.22.

Fri, Aug 28, 6:46 AM · Bug Report
gniibe added a comment to T4838: add configure check for zlib to ntbtls.

Actually, configure already has the check.
If it's really needed to build without zlib, you can use this patch:

From 76920ac034490e4860ad6abe9891e3b1c0813363 Mon Sep 17 00:00:00 2001
From: NIIBE Yutaka <gniibe@fsij.org>
Date: Fri, 28 Aug 2020 11:02:13 +0900
Subject: [PATCH] Until compression is implemented, build with no ZLIB can be
 done.
Fri, Aug 28, 4:08 AM · ntbtls, Bug Report
gniibe added a project to T5037: dn.cpp:181: suspicious loop: gpgme.
Fri, Aug 28, 3:06 AM · gnupg, gpgme, Bug Report
gniibe closed T3207: FASTWIPE_T undefined as Resolved.
Fri, Aug 28, 3:01 AM · Testing, ntbtls, Bug Report
gniibe closed T4934: Returning automatic variable buffer from a function as Resolved.
Fri, Aug 28, 2:58 AM · dirmngr, Testing, Bug Report

Thu, Aug 27

gniibe committed rG9f148360a2bf: scd: Add heuristics to identify cardtype. (authored by gniibe).
scd: Add heuristics to identify cardtype.
Thu, Aug 27, 7:34 AM
gniibe committed rGd2f1a0a791db: scd: Add condition for VERIFY with 0x82. (authored by gniibe).
scd: Add condition for VERIFY with 0x82.
Thu, Aug 27, 3:55 AM
gniibe committed rGaf189be481df: scd: Add condition for VERIFY with 0x82. (authored by gniibe).
scd: Add condition for VERIFY with 0x82.
Thu, Aug 27, 3:45 AM

Tue, Aug 25

gniibe committed rE13c28a300e02: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Tue, Aug 25, 7:36 AM
gniibe added a comment to T5029: server socket/pipe handling in GnuPG.

It's pretty minor bug, it only matters for some strange scenario on Windows like:
(1) a user runs gpg --card-edit or gpg-card and keeps the user interaction for some reason (say, forgetting the terminal interaction), which keeps the pipe connection from gpg-agent to scdaemon
(2) While the pipe connection is used by the user interaction above, from another terminal, the user invokes gpg (say, gpg --decrypt) which uses socket connection from gpg-agent to scdaemon

Tue, Aug 25, 3:13 AM · gnupg (gpg23)
gniibe added a comment to T5029: server socket/pipe handling in GnuPG.

I mean these uses of close:

diff --git a/scd/scdaemon.c b/scd/scdaemon.c
index b7bbc0361..a6925eaf9 100644
--- a/scd/scdaemon.c
+++ b/scd/scdaemon.c
@@ -797,8 +797,8 @@ main (int argc, char **argv )
       /* We run handle_connection to wait for the shutdown signal and
          to run the ticker stuff.  */
       handle_connections (fd);
-      if (fd != -1)
-        close (fd);
+      if (fd != GNUPG_INVALID_FD)
+        assuan_sock_close (fd);
     }
   else if (!is_daemon)
     {
@@ -932,7 +932,7 @@ main (int argc, char **argv )
Tue, Aug 25, 3:02 AM · gnupg (gpg23)
gniibe renamed T5034: dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, ang gpg-error-config from dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, and npth-config to dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, ang gpg-error-config.
Tue, Aug 25, 2:55 AM
gniibe created T5034: dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, ang gpg-error-config.
Tue, Aug 25, 2:54 AM
gniibe closed T5010: gpgrt-config: Bug for handling Requires as Resolved.
Tue, Aug 25, 2:24 AM · Testing, gpgrt

Mon, Aug 24

gniibe committed rPTH02ce6b2d27f9: Conditionally enable busy_wait_for. (authored by gniibe).
Conditionally enable busy_wait_for.
Mon, Aug 24, 9:26 AM
gniibe added a comment to E770: Weekly Standup.

Last week:

  • It was too hot to work.
  • Test with clang build
  • Minor fixed in GnuPG master
  • Minor fix in libgcrypt and libgpg-error
  • Created T5029: server socket/pipe handling in GnuPG
    • Please note that it's not clean up for fd/HANDLE thing
    • It's a (minor) bug of calling close where we should use assuan_socket_close
  • Defer working for FST-01SZ to September

This week:

  • I realized that use of Linux kernel 5.7 is easier. Configure wireguard with Linux 5.7.
  • Bug fixes
Mon, Aug 24, 8:17 AM
gniibe is attending E770: Weekly Standup.
Mon, Aug 24, 8:04 AM

Fri, Aug 21

gniibe committed rC65a2cd139e21: ecc: Fix an error path. (authored by gniibe).
ecc: Fix an error path.
Fri, Aug 21, 5:51 AM
gniibe committed rCfd51bc523d09: tests: Fix basic.c. (authored by gniibe).
tests: Fix basic.c.
Fri, Aug 21, 5:51 AM
gniibe committed rE87a6b28c0f3b: argparse: Handle a corner case of wrong ARGC. (authored by gniibe).
argparse: Handle a corner case of wrong ARGC.
Fri, Aug 21, 4:02 AM

Aug 19 2020

gniibe added a project to T5029: server socket/pipe handling in GnuPG: gnupg.
Aug 19 2020, 10:10 AM · gnupg (gpg23)
gniibe created T5029: server socket/pipe handling in GnuPG.
Aug 19 2020, 10:10 AM · gnupg (gpg23)
gniibe committed rG1d66b518ca83: gpg: Fix condition of string_to_aead_algo. (authored by gniibe).
gpg: Fix condition of string_to_aead_algo.
Aug 19 2020, 8:20 AM
gniibe committed rGf58d441bee7e: common: Fix iobuf.c. (authored by gniibe).
common: Fix iobuf.c.
Aug 19 2020, 8:20 AM
gniibe committed rGcc0d53905ce9: dns: Fix memory use-after-free. (authored by gniibe).
dns: Fix memory use-after-free.
Aug 19 2020, 8:20 AM
gniibe committed rGf3e424d4e727: Silence compiler warnings. (authored by gniibe).
Silence compiler warnings.
Aug 19 2020, 6:24 AM
gniibe committed rG4fa0a65676a2: scd: Fix possible uninitialized variables. (authored by gniibe).
scd: Fix possible uninitialized variables.
Aug 19 2020, 4:45 AM