gniibe (NIIBE Yutaka)Administrator
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:47 PM (78 w, 1 d)
Roles
Administrator
Availability
Available

Recent Activity

Thu, Sep 20

gniibe committed rE15309d0fb4c7: src: Fix portability for echo. (authored by gniibe).
src: Fix portability for echo.
Thu, Sep 20, 6:25 AM
gniibe committed rEd510f38ccbc7: gpg-error-config: Remove white space for the output by old. (authored by gniibe).
gpg-error-config: Remove white space for the output by old.
Thu, Sep 20, 6:25 AM
gniibe committed rEa338801aa4ba: gpg-error-config: Use expr to remove var in expression. (authored by gniibe).
gpg-error-config: Use expr to remove var in expression.
Thu, Sep 20, 5:47 AM
gniibe committed rE4c2601a95f06: gpg-error-config: Fix a variable name for zsh. (authored by gniibe).
gpg-error-config: Fix a variable name for zsh.
Thu, Sep 20, 5:02 AM
gniibe committed rE5731ad6377ab: gpg-error-config: Don't use local variables. (authored by gniibe).
gpg-error-config: Don't use local variables.
Thu, Sep 20, 5:02 AM
gniibe committed rE95ab4d037ce2: gpg-error-config: Avoid more space char. (authored by gniibe).
gpg-error-config: Avoid more space char.
Thu, Sep 20, 5:02 AM

Wed, Sep 19

gniibe added a comment to E401: Weekly Standup.

pkg-config support in libgpg-error: Fixes for *BSD... done

  • FreeBSD 11.1: OK
  • NetBSD 7.1: OK
  • OpenBSD: BAD
  • AIX: BAD
  • Solaris11: BAD
Wed, Sep 19, 6:27 AM
gniibe committed rE144f4b3df520: src: Fix Makefile for BSD make. (authored by gniibe).
src: Fix Makefile for BSD make.
Wed, Sep 19, 4:19 AM
gniibe committed rE5564efac95e9: Accept pkgconf difference for spaces. (authored by gniibe).
Accept pkgconf difference for spaces.
Wed, Sep 19, 4:19 AM

Tue, Sep 18

gniibe added a comment to T4145: pinentry-gnome3 grabs input partially and ignores grab/no-grab option.

We know that. And pinentry-gtk does like that.

Tue, Sep 18, 4:44 AM · Documentation, pinentry
gniibe added a project to T4145: pinentry-gnome3 grabs input partially and ignores grab/no-grab option: Documentation.

Yes. It's up to GCR library in GNOME.

Tue, Sep 18, 4:09 AM · Documentation, pinentry
gniibe committed rGfe8b6339542f: g10: Fix memory leak for --card-status. (authored by gniibe).
g10: Fix memory leak for --card-status.
Tue, Sep 18, 3:09 AM
gniibe committed rGf5be5c9654d8: po: Update Japanese translation. (authored by gniibe).
po: Update Japanese translation.
Tue, Sep 18, 3:09 AM

Mon, Sep 17

gniibe added a comment to E400: Weekly Standup.

Last week:

  • libgpg-error: pkg-config support is merged to master
  • gnupg: In master, public key decryption change introduced memory leak, which is fixed
Mon, Sep 17, 9:18 AM
gniibe is attending E400: Weekly Standup.
Mon, Sep 17, 8:58 AM

Fri, Sep 14

gniibe committed rG60c880bda5c9: g10: Fix another memory leak. (authored by gniibe).
g10: Fix another memory leak.
Fri, Sep 14, 1:23 AM
gniibe committed rG2eb481e8cc1c: g10: Fix memory leak (more). (authored by gniibe).
g10: Fix memory leak (more).
Fri, Sep 14, 1:23 AM
gniibe committed rG64c5c45e2aa4: g10: Fix memory leak in enum_secret_keys. (authored by gniibe).
g10: Fix memory leak in enum_secret_keys.
Fri, Sep 14, 1:23 AM
gniibe added a commit to T4140: Memory leak in get_session_key: rG64c5c45e2aa4: g10: Fix memory leak in enum_secret_keys..
Fri, Sep 14, 1:23 AM · Bug Report
gniibe closed T4140: Memory leak in get_session_key as Resolved.

Thanks a lot.
By this report, I was able to fix more memory leaks.

Fri, Sep 14, 1:19 AM · Bug Report

Thu, Sep 13

gniibe claimed T4140: Memory leak in get_session_key.
Thu, Sep 13, 2:00 AM · Bug Report

Wed, Sep 12

gniibe abandoned D462: Figure out the session key by looking at all PKT_PUBKEY_ENC packets.

Changes are included to master branch of gnupg.

Wed, Sep 12, 9:57 AM · gnupg
gniibe added a comment to T3189: secmem routines should be in libgpg-error as gpgrt_*.

secmem routines are installed into gniibe/secmem branch.
Please note that it's only secmem routines, not malloc_secure.

Wed, Sep 12, 5:45 AM · gpgrt, libgcrypt

Tue, Sep 11

gniibe closed T3877: not all malloc performed in libgcrypt covered by gcry_set_allocation_handler as Resolved.
Tue, Sep 11, 1:34 PM · libgcrypt, Bug Report
gniibe committed rG69bab1cba07a: Revert "dirmngr: hkp: Avoid potential race condition when some hosts die." (authored by gniibe).
Revert "dirmngr: hkp: Avoid potential race condition when some hosts die."
Tue, Sep 11, 7:07 AM
gniibe added a reverting commit for rG04b56eff118e: dirmngr: hkp: Avoid potential race condition when some hosts die.: rG69bab1cba07a: Revert "dirmngr: hkp: Avoid potential race condition when some hosts die.".
Tue, Sep 11, 7:07 AM
gniibe committed rG995aded58724: dirmngr: Serialize access to hosttable. (authored by gniibe).
dirmngr: Serialize access to hosttable.
Tue, Sep 11, 7:07 AM
gniibe committed rE78b679a778dd: Make gpg-error-config compatible to pkg-config. (authored by gniibe).
Make gpg-error-config compatible to pkg-config.
Tue, Sep 11, 2:43 AM
gniibe added a commit to T4085: Add support for pkg-config: rE78b679a778dd: Make gpg-error-config compatible to pkg-config..
Tue, Sep 11, 2:43 AM

Mon, Sep 10

gniibe closed T4093: Undefined shift in parse_symkeyenc as Resolved.

I confirmed: Now, all use cases of iobuf_get check against negative value or are using iobuf_get_eof.
So, closing.

Mon, Sep 10, 7:47 AM · Bug Report
gniibe committed rG0383e7fed7b2: common: Use iobuf_get_noeof to avoid undefined behaviors. (authored by gniibe).
common: Use iobuf_get_noeof to avoid undefined behaviors.
Mon, Sep 10, 7:00 AM
gniibe added a commit to T4093: Undefined shift in parse_symkeyenc: rG0383e7fed7b2: common: Use iobuf_get_noeof to avoid undefined behaviors..
Mon, Sep 10, 6:59 AM · Bug Report
gniibe committed rGf80346f42df4: common: Use iobuf_get_noeof to avoid undefined behaviors. (authored by gniibe).
common: Use iobuf_get_noeof to avoid undefined behaviors.
Mon, Sep 10, 6:58 AM
gniibe added a commit to T4093: Undefined shift in parse_symkeyenc: rGf80346f42df4: common: Use iobuf_get_noeof to avoid undefined behaviors..
Mon, Sep 10, 6:58 AM · Bug Report
gniibe added a comment to E399: Weekly Standup.
  • libgpg-error
    • gniibe/secmem branch is ready to be merged into master
    • gniibe/pkg-config-support works well for me. If everything is OK, we can manually merge it into master (the history in the branch is not needed to be merged).
  • gnupg/dirmngr
    • hosttable requires (or is better to have) serialized access
    • -> My plan: introduce a lock for serializing hosttable access
    • I remember rGe175152ef751: agent: Fix double free.
      • It is true that the thread may surrender control to a different (Pthread's) thread calling allocator
        • (for example, when there is a thread which uses estream calling fread->malloc->getting malloc's internal lock and then syscall mmap)
      • (But I think that) it never occurs for a control to go to another nPth thread, while the original thread holding nPth's semaphore
      • well, it is possible a user uses special allocator (instead of system allocator) which calls npth_unprotect npth_protect pair.
Mon, Sep 10, 6:18 AM
gniibe is attending E399: Weekly Standup.
Mon, Sep 10, 4:07 AM
gniibe committed rGadce73b86fd4: agent: Fix error code check from npth_mutex_init. (authored by gniibe).
agent: Fix error code check from npth_mutex_init.
Mon, Sep 10, 2:25 AM
gniibe committed rG213379debe55: agent: Fix error code check from npth_mutex_init. (authored by gniibe).
agent: Fix error code check from npth_mutex_init.
Mon, Sep 10, 2:25 AM

Fri, Sep 7

gniibe added a comment to T2836: dirmngr: wakes up periodically.

Patch 0001 applied to master.

Fri, Sep 7, 7:30 AM · gnupg, gnupg (gpg23), Bug Report, dirmngr
gniibe committed rG04b56eff118e: dirmngr: hkp: Avoid potential race condition when some hosts die. (authored by dkg).
dirmngr: hkp: Avoid potential race condition when some hosts die.
Fri, Sep 7, 7:30 AM
gniibe added a commit to T2836: dirmngr: wakes up periodically: rG04b56eff118e: dirmngr: hkp: Avoid potential race condition when some hosts die..
Fri, Sep 7, 7:30 AM · gnupg, gnupg (gpg23), Bug Report, dirmngr
gniibe closed T3916: Memory leak in read_block as Resolved.

Thanks for your report. Applied.

Fri, Sep 7, 6:08 AM · gnupg, Bug Report
gniibe committed rG7c96cc67e108: g10: Fix memory leak. (authored by gniibe).
g10: Fix memory leak.
Fri, Sep 7, 6:08 AM
gniibe added a commit to T3916: Memory leak in read_block: rG7c96cc67e108: g10: Fix memory leak..
Fri, Sep 7, 6:08 AM · gnupg, Bug Report
gniibe committed rG91f8a9b33a12: g10: Fix memory leak. (authored by gniibe).
g10: Fix memory leak.
Fri, Sep 7, 6:08 AM
gniibe added a commit to T3916: Memory leak in read_block: rG91f8a9b33a12: g10: Fix memory leak..
Fri, Sep 7, 6:08 AM · gnupg, Bug Report
gniibe committed rEca8557c0d7d1: secmem: Exposed function should have consistent name. (authored by gniibe).
secmem: Exposed function should have consistent name.
Fri, Sep 7, 5:11 AM

Thu, Sep 6

gniibe committed rEb2aba1bec151: gpgscm: Suppress warnings for GCC > 6. (authored by gniibe).
gpgscm: Suppress warnings for GCC > 6.
Thu, Sep 6, 8:03 AM
gniibe committed rG99c17b970bc0: gpgscm: Suppress warnings for GCC > 6. (authored by gniibe).
gpgscm: Suppress warnings for GCC > 6.
Thu, Sep 6, 7:59 AM
gniibe committed rG625ced6e672d: Fix use of strncpy, which is actually good to use memcpy. (authored by gniibe).
Fix use of strncpy, which is actually good to use memcpy.
Thu, Sep 6, 4:48 AM
gniibe committed rGf0fdee2e24a2: Fix use of strncpy, which is actually good to use memcpy. (authored by gniibe).
Fix use of strncpy, which is actually good to use memcpy.
Thu, Sep 6, 4:48 AM
gniibe claimed T3189: secmem routines should be in libgpg-error as gpgrt_*.

I created gniibe/secmem branch for this.
https://dev.gnupg.org/source/libgpg-error/history/gniibe%252Fsecmem/

Thu, Sep 6, 3:20 AM · gpgrt, libgcrypt
gniibe committed rEc03cc0015612: Copy definitions from libgcrypt/src/g10lib.h. (authored by gniibe).
Copy definitions from libgcrypt/src/g10lib.h.
Thu, Sep 6, 3:18 AM
gniibe committed rEc6b7bbe91368: secmem: Export symbols and the interface. (authored by gniibe).
secmem: Export symbols and the interface.
Thu, Sep 6, 3:18 AM
gniibe committed rE74dfa426d682: Remove fips_mode support originally available in libgcrypt. (authored by gniibe).
Remove fips_mode support originally available in libgcrypt.
Thu, Sep 6, 3:18 AM
gniibe committed rE26bf6d0ab3f4: secmem.c migration into gpgrt. (authored by gniibe).
secmem.c migration into gpgrt.
Thu, Sep 6, 3:18 AM
gniibe committed rEed813b1dfb33: Fix copyright notices. (authored by gniibe).
Fix copyright notices.
Thu, Sep 6, 3:18 AM
gniibe committed rE25e0253fdaa8: Change gcry -> gpgrt_. (authored by gniibe).
Change gcry -> gpgrt_.
Thu, Sep 6, 3:18 AM
gniibe committed rE6930b723a194: Remove _gpgrt_secmem_module_init. (authored by gniibe).
Remove _gpgrt_secmem_module_init.
Thu, Sep 6, 3:18 AM
gniibe committed rEed924cebb511: Add src/secmem.{c,h} from libgcrypt master. (authored by gniibe).
Add src/secmem.{c,h} from libgcrypt master.
Thu, Sep 6, 3:18 AM
gniibe committed rE2148e19fbefa: po: Fix the previous commit. (authored by gniibe).
po: Fix the previous commit.
Thu, Sep 6, 2:59 AM

Wed, Sep 5

gniibe committed rEcb0113f4690e: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Wed, Sep 5, 5:16 AM
gniibe committed rE85dcab57cc43: Merge branch 'master' into gniibe/pkg-config-support (authored by gniibe).
Merge branch 'master' into gniibe/pkg-config-support
Wed, Sep 5, 5:00 AM
gniibe committed rE61d78fdc25e5: gpg-error-config: Forward compatibility support. (authored by gniibe).
gpg-error-config: Forward compatibility support.
Wed, Sep 5, 4:57 AM
gniibe committed rEfa2855d9470e: Forward compatibility support by gpg-error-config-old (--variable=*). (authored by gniibe).
Forward compatibility support by gpg-error-config-old (--variable=*).
Wed, Sep 5, 4:47 AM
gniibe added a comment to T4119: gpg --symmetric emits a SEIP packet, but no MDC.

Perhaps, the missing length information in compressed data packet is confusing. The length is determined by the assumption of existence of 22-byte MDC packet.

Wed, Sep 5, 3:58 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T4119: gpg --symmetric emits a SEIP packet, but no MDC.

Here is my understanding.

Wed, Sep 5, 3:55 AM · gnupg (gpg22), Bug Report

Tue, Sep 4

gniibe closed T3759: Compile test fails, Libassuan v2.5.1 - Ubuntu 14.04 - fdpassing[7693]: assuan_pipe_connect failed: End of file as Resolved.

Closing.

Tue, Sep 4, 9:21 AM · Info Needed, libassuan, Bug Report
gniibe added a comment to T4085: Add support for pkg-config.

Initial development finished.
Now, my plan is:

  • a bit more tweaks for gpg-error-config-old to support new ways (such as --variable=*)
  • testing on *BSD
  • not including gpg-error-config-new to next libgpg-error 1.33
    • Possibly include new gpg-error.m4???
  • After 1.33, merge the branch (not directly by "merge" but merging all changes with relevant commit logs) to master of libgpg-error. This means:
    • gpg-error-config-new
    • checking difference between old and new at build-time
    • "make check" tests difference between gpg-error-config(-new) and pkg-config (if available)
  • 1.34 will have all new features
  • Then, we will migrate other software of our GnuPG
    • libassuan
    • libgcrypt
    • libksba
    • libnpth
    • ntbtls
    • gpgme
Tue, Sep 4, 9:12 AM
gniibe claimed T4119: gpg --symmetric emits a SEIP packet, but no MDC.

I can see MDC packet of 22-byte (which starts by 0xd3 0x19, and then 20-byte SHA-1 hash), when SEIP data packet is decrypted.
I don't see your situation.
How about with no compression (-z 0)? I mean, compression is not applied to MDC packet.

Tue, Sep 4, 7:35 AM · gnupg (gpg22), Bug Report
gniibe committed rEf77c96871874: Merge branch 'master' into gniibe/pkg-config-support (authored by gniibe).
Merge branch 'master' into gniibe/pkg-config-support
Tue, Sep 4, 4:00 AM
gniibe committed rEaa697dae4c36: gpg-error-config: Determine output at configure time. (authored by gniibe).
gpg-error-config: Determine output at configure time.
Tue, Sep 4, 4:00 AM
gniibe committed rE1b025ca89b58: Fix configure time check for includedir and libdir. (authored by gniibe).
Fix configure time check for includedir and libdir.
Tue, Sep 4, 3:53 AM
gniibe committed rE6bca1ddc29a7: Add gpg-error-config to CLEANFILES. (authored by gniibe).
Add gpg-error-config to CLEANFILES.
Tue, Sep 4, 3:53 AM
gniibe committed rE129e75fabd4a: Extend gpg-error-config-test.sh to test against pkg-config. (authored by gniibe).
Extend gpg-error-config-test.sh to test against pkg-config.
Tue, Sep 4, 3:53 AM

Mon, Sep 3

gniibe added a comment to E398: Weekly Standup.
gpg-error-config gpg-error '>=' 1.33 libgcrypt '>=' 1.9.5 libassuan '>=' 2.5.1
  • Sorry for many commit logs. My experiment with shell was by trial-and-error.
Mon, Sep 3, 6:19 AM
gniibe is attending E398: Weekly Standup.
Mon, Sep 3, 6:08 AM
gniibe committed rEa2cb8c2451d9: Not by "make check" but gpg-error-config is determined by the test. (authored by gniibe).
Not by "make check" but gpg-error-config is determined by the test.
Mon, Sep 3, 6:01 AM
gniibe committed rE83d523e4b9c4: Fix new gpg-error-config and add a test. (authored by gniibe).
Fix new gpg-error-config and add a test.
Mon, Sep 3, 4:37 AM
gniibe committed rE5a30c1dc7843: Change old gpg-error-config for isubdirafter. (authored by gniibe).
Change old gpg-error-config for isubdirafter.
Mon, Sep 3, 4:37 AM
gniibe committed rE433075092cd1: Add back old gpg-error-config. (authored by gniibe).
Add back old gpg-error-config.
Mon, Sep 3, 4:37 AM
gniibe committed rE8a6ca0194b6c: Fix old gpg-config-error with configure.ac substitution. (authored by gniibe).
Fix old gpg-config-error with configure.ac substitution.
Mon, Sep 3, 4:37 AM
gniibe committed rE576499c264eb: Support invocation like gpg-erro-config '>=' 1.32. (authored by gniibe).
Support invocation like gpg-erro-config '>=' 1.32.
Mon, Sep 3, 4:37 AM

Fri, Aug 31

gniibe added a comment to T4085: Add support for pkg-config.

The implementation by Bourne shell is not perfect. Parsing .pc file depends on glob pattern match, which would have unexpected behavior in some cases (e.g. when .pc has no variable definitions and it only has "Requires: somepackage >= 1.0", the line matches glob pattern of "*=*" which looks like variable definition).

Fri, Aug 31, 9:18 AM
gniibe added a comment to T4085: Add support for pkg-config.

By {rGfb1d0cd}, it supports version dependency handling.
While it's far from pkg-config replacement, I think that we can use the script for all GnuPG software with *.pc file.
I mean, this single script for all.

Fri, Aug 31, 9:11 AM
gniibe committed rEfb1d0cd7105e: Support module dependency. (authored by gniibe).
Support module dependency.
Fri, Aug 31, 9:08 AM
gniibe added a comment to T4085: Add support for pkg-config.

Today, I wrote a script:

Fri, Aug 31, 6:53 AM

Thu, Aug 30

gniibe added a comment to T4085: Add support for pkg-config.

Up to rEe0aecec6d040: Remove AC_CONFIG_COMMANDS for gpg-error-config., now it supports dependency of modules and multiple modules.
A single shell script can be same content (but only names differ).
It only supports features used by our *-config command, though. (Not support --static yet, for example)

Thu, Aug 30, 8:43 AM
gniibe committed rEe0aecec6d040: Remove AC_CONFIG_COMMANDS for gpg-error-config. (authored by gniibe).
Remove AC_CONFIG_COMMANDS for gpg-error-config.
Thu, Aug 30, 8:36 AM
gniibe committed rE53d2eb399601: Fixes src/gpg-error-config-main.sh and src/pkgconf-funcs.sh. (authored by gniibe).
Fixes src/gpg-error-config-main.sh and src/pkgconf-funcs.sh.
Thu, Aug 30, 8:28 AM
gniibe committed rE66ba9c3ad0bf: Support invocation with module names. (authored by gniibe).
Support invocation with module names.
Thu, Aug 30, 8:28 AM
gniibe committed rE78be78bd3d91: Remove dupulicates. (authored by gniibe).
Remove dupulicates.
Thu, Aug 30, 6:52 AM
gniibe committed rE5cbc696fec8b: Handle module dependency (Requires field). (authored by gniibe).
Handle module dependency (Requires field).
Thu, Aug 30, 6:52 AM
gniibe committed rEffebb25cfe23: Add note for the compatibility. (authored by gniibe).
Add note for the compatibility.
Thu, Aug 30, 6:52 AM
gniibe committed rEed6f96f26c2b: New func read_config_from_stdin and cleanup_vars_attrs. (authored by gniibe).
New func read_config_from_stdin and cleanup_vars_attrs.
Thu, Aug 30, 6:52 AM
gniibe committed rE3f96c9c1d103: PKG_CONFIG_PATH change. (authored by gniibe).
PKG_CONFIG_PATH change.
Thu, Aug 30, 6:52 AM
gniibe committed rE6680867dd90c: Simplify configure substitution. (authored by gniibe).
Simplify configure substitution.
Thu, Aug 30, 6:52 AM
gniibe committed rE37f627eaca57: Fix test condition for pkg-conf-funcs. (authored by gniibe).
Fix test condition for pkg-conf-funcs.
Thu, Aug 30, 6:52 AM
gniibe committed rE55603b7a0d2f: Fix the previous commit. (authored by gniibe).
Fix the previous commit.
Thu, Aug 30, 6:52 AM

Wed, Aug 29

gniibe committed rE07fcb271f761: Fix gpg-error.m4 to use pkg-config compatible way. (authored by gniibe).
Fix gpg-error.m4 to use pkg-config compatible way.
Wed, Aug 29, 8:14 AM