Page MenuHome GnuPG

gniibe (NIIBE Yutaka)
UserAdministrator

Projects (9)

User Details

User Since
Mar 27 2017, 4:47 PM (393 w, 4 d)
Roles
Administrator
Availability
Busy Busy until Sep 30 2030.

Recent Activity

Yesterday

gniibe committed rE1860f6407f83: spawn: Add new function to modify environment. (authored by gniibe).
spawn: Add new function to modify environment.
Fri, Oct 11, 9:32 AM
gniibe added a comment to T7307: Add new function to spawn API which has 'modifying' environment semantics.

With the change, T7169 is fixed (by side-effect).

Fri, Oct 11, 9:31 AM · gpgrt, Bug Report
gniibe changed the status of T7307: Add new function to spawn API which has 'modifying' environment semantics from Open to Testing.

Pushed the change: rE1860f6407f83: spawn: Add new function to modify environment.

Fri, Oct 11, 9:31 AM · gpgrt, Bug Report
gniibe changed the status of T7307: Add new function to spawn API which has 'modifying' environment semantics, a subtask of T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ'), from Open to Testing.
Fri, Oct 11, 9:31 AM · gpgrt, MacOS, Bug Report
gniibe committed rGf8bf5e01f766: build: Use AC_C_BIGENDIAN for detecting endian. (authored by gniibe).
build: Use AC_C_BIGENDIAN for detecting endian.
Fri, Oct 11, 3:24 AM

Thu, Oct 10

gniibe committed rE68600fe17c5f: w32: Fix releasing memory for UTF-8 text. (authored by gniibe).
w32: Fix releasing memory for UTF-8 text.
Thu, Oct 10, 4:36 AM

Wed, Oct 9

gniibe added a comment to T7307: Add new function to spawn API which has 'modifying' environment semantics.

Replacing gpgrt_spawn_actions_set_environ by gpgrt_spawn_actions_set_envchange is not good, as it's exported and already used.

Wed, Oct 9, 8:51 AM · gpgrt, Bug Report
gniibe updated the task description for T7323: scdaemon hangs up.
Wed, Oct 9, 4:06 AM · Bug Report, scd
gniibe renamed T7323: scdaemon hangs up from scdaemon hang to scdaemon hangs up.
Wed, Oct 9, 4:06 AM · Bug Report, scd
gniibe created T7323: scdaemon hangs up.
Wed, Oct 9, 4:04 AM · Bug Report, scd

Tue, Oct 8

gniibe changed the status of T7316: Curve25519/v5 key cannot be exported, a subtask of T7315: Allow exporting of PQC keys., from Open to Testing.
Tue, Oct 8, 8:38 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe changed the status of T7316: Curve25519/v5 key cannot be exported from Open to Testing.
Tue, Oct 8, 8:38 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe added a comment to T7316: Curve25519/v5 key cannot be exported.

Pushed the fix for exporting OpenPGP v5 key: rG57dce1ee62c2: common,gpg,scd,sm: Fix for Curve25519 OID supporting new and old.

Tue, Oct 8, 8:38 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe committed rG57dce1ee62c2: common,gpg,scd,sm: Fix for Curve25519 OID supporting new and old. (authored by gniibe).
common,gpg,scd,sm: Fix for Curve25519 OID supporting new and old.
Tue, Oct 8, 8:35 AM
gniibe committed rGf5703994d469: common,gpg,scd,sm: Use openpgp_oid_or_name_to_curve to get curve. (authored by gniibe).
common,gpg,scd,sm: Use openpgp_oid_or_name_to_curve to get curve.
Tue, Oct 8, 8:00 AM

Thu, Oct 3

gniibe added a comment to T7316: Curve25519/v5 key cannot be exported.

The OID is used for fingerprint computation, which complicates things.

Thu, Oct 3, 7:37 AM · gnupg26, OpenPGP, PQC, gnupg
gniibe claimed T7316: Curve25519/v5 key cannot be exported.
Thu, Oct 3, 2:43 AM · gnupg26, OpenPGP, PQC, gnupg

Wed, Oct 2

gniibe triaged T7316: Curve25519/v5 key cannot be exported as Normal priority.
Wed, Oct 2, 7:20 AM · gnupg26, OpenPGP, PQC, gnupg

Tue, Oct 1

gniibe changed the status of T7309: gpg should not proceed with the key import from the smartcard if no valid SCD READKEY information is received from Open to Testing.

Fixed in master: rGe7891225788a: gpg: Robust error handling for SCD READKEY.

Tue, Oct 1, 3:58 AM · Info Needed, scd, gpgagent, Bug Report
gniibe committed rGe7891225788a: gpg: Robust error handling for SCD READKEY. (authored by gniibe).
gpg: Robust error handling for SCD READKEY.
Tue, Oct 1, 3:58 AM

Mon, Sep 30

gniibe claimed T7309: gpg should not proceed with the key import from the smartcard if no valid SCD READKEY information is received.
Mon, Sep 30, 3:49 AM · Info Needed, scd, gpgagent, Bug Report

Fri, Sep 27

gniibe added a comment to T7307: Add new function to spawn API which has 'modifying' environment semantics.

Here is my attempt:

Fri, Sep 27, 10:12 AM · gpgrt, Bug Report
gniibe triaged T7307: Add new function to spawn API which has 'modifying' environment semantics as Normal priority.
Fri, Sep 27, 10:11 AM · gpgrt, Bug Report
gniibe added a comment to T6375: gpg-agent race-condition with parallel clients.

It is reproducible bug even with master branch.

Fri, Sep 27, 4:22 AM · gnupg24, gpgagent, Bug Report

Thu, Sep 26

gniibe added a comment to T6375: gpg-agent race-condition with parallel clients.

I have a look at the log file of gpg-agent.log. I can see that six PKDECRYPT requests are handled simultaneously. I think that it's out of secure memory to decrypt the private key which results pinentry request.

Thu, Sep 26, 10:35 AM · gnupg24, gpgagent, Bug Report

Wed, Sep 25

gniibe closed T7186: Fix tpm2d key import after recent changes as Resolved.
Wed, Sep 25, 7:29 AM · gnupg, Bug Report
gniibe closed T7195: gpgme regression (t-json) with GnuPG 2.5.0 as Resolved.
Wed, Sep 25, 7:28 AM · gnupg, Bug Report
gniibe committed rG79ad6a8b430e: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Wed, Sep 25, 7:27 AM
gniibe committed rG26d171d36d2c: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Wed, Sep 25, 7:15 AM
gniibe closed T6641: pinentry-tty & pinentry-curses breaks tty when timeout occurs or CTRL-C is pressed as Resolved.

Fixed in pinentry 1.3, when using GnuPG 2.4 or later.

Wed, Sep 25, 4:56 AM · gnupg, pinentry
gniibe committed rGa269a27c4ce5: common: Fix gnupg_exec_tool_stream for INEXTRA==NULL. (authored by gniibe).
common: Fix gnupg_exec_tool_stream for INEXTRA==NULL.
Wed, Sep 25, 4:20 AM

Tue, Sep 24

gniibe closed T5924: libassuan: uses of socklen_t in assuan.h are inconsistent as Resolved.

Fixed in libassuan 3.0.0.

Tue, Sep 24, 7:39 AM · libassuan
gniibe closed T6734: gnupg: Use gpgrt_b64* API as Resolved.

Done in GnuPG 2.5.0.

Tue, Sep 24, 7:35 AM · gnupg26

Fri, Sep 20

gniibe added a comment to T7291: scdaemon randomly hangs when trying to access a token.

The change of spawn functions (basically, it was factored out to libgpg-error) results more possibilities to have blocked scdaemon, since the implementation in libgpg-error introduced context switch points when it spawns a child process.

Fri, Sep 20, 4:02 AM · scd
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

Found another thinko; When there is no clients with DEVINFO --watch, the pipe to be notified is not consumed at all (no read). It eventually results blocked by write(2), when the pipe is filled.

Fri, Sep 20, 3:51 AM · gpgagent, scd, gnupg24, Bug Report
gniibe committed rG0a94582af5b1: scd: Fix DEVINFO, allowing no clients which watch the change. (authored by gniibe).
scd: Fix DEVINFO, allowing no clients which watch the change.
Fri, Sep 20, 3:48 AM

Thu, Sep 19

gniibe added a comment to T7291: scdaemon randomly hangs when trying to access a token.

Do you have scd-event script in your GNUPGHOME?

Thu, Sep 19, 9:13 AM · scd
gniibe committed rEbcab96484d48: posix: Fix forgotten _gpgrt_post_syscall on error path. (authored by gniibe).
posix: Fix forgotten _gpgrt_post_syscall on error path.
Thu, Sep 19, 8:56 AM
gniibe committed rE4a0c942151da: posix: Fix memory leak for spawn. (authored by gniibe).
posix: Fix memory leak for spawn.
Thu, Sep 19, 8:55 AM
gniibe added a comment to T7294: keyboxd: Possible race conditions (and clean up).

I applied rGb804378f183f: kbx: Fix a race condition on DATABASE_HD. in master. Let us see how behavior changes.

Thu, Sep 19, 6:53 AM · Bug Report, kleopatra, Restricted Project
gniibe committed rGb804378f183f: kbx: Fix a race condition on DATABASE_HD. (authored by gniibe).
kbx: Fix a race condition on DATABASE_HD.
Thu, Sep 19, 6:47 AM
gniibe added a comment to T7294: keyboxd: Possible race conditions (and clean up).

I found one problem. This problem may result lock-up on Windows, I suppose.

Thu, Sep 19, 6:40 AM · Bug Report, kleopatra, Restricted Project
gniibe triaged T7294: keyboxd: Possible race conditions (and clean up) as High priority.
Thu, Sep 19, 6:32 AM · Bug Report, kleopatra, Restricted Project
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

I mean: two gpg-agent requests simultaneously running DEVINFO --watch.

Thu, Sep 19, 1:43 AM · gpgagent, scd, gnupg24, Bug Report

Wed, Sep 18

gniibe lowered the priority of T7291: scdaemon randomly hangs when trying to access a token from Unbreak Now! to High.

For POSIX, I found an issue of T7151.
If you are using multiple clients which invoke SCD DEVINFO --watch, the problem should be fixed.
If it's not the case, let us locate a bug (or two).

Wed, Sep 18, 6:55 AM · scd
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

Fixed in rGfc30f7059650: scd: Fix DEVINFO to allow multiple clients.

Wed, Sep 18, 6:52 AM · gpgagent, scd, gnupg24, Bug Report
gniibe committed rGfc30f7059650: scd: Fix DEVINFO to allow multiple clients. (authored by gniibe).
scd: Fix DEVINFO to allow multiple clients.
Wed, Sep 18, 6:47 AM
gniibe added a comment to T7151: graceful shutdown: DEVINFO should be a gpg-agent command: also watching input close.

I realized that I put a bug on POSIX; When multiple clients do DEVINFO --watch, it is possible for scdaemon to hang (waiting pselect and read, read by one, read by another is blocked).

Wed, Sep 18, 4:57 AM · gpgagent, scd, gnupg24, Bug Report

Tue, Sep 17

gniibe committed rC4876a1a45c25: tests:kyber: Add genkey and encap KAT tests. (authored by gniibe).
tests:kyber: Add genkey and encap KAT tests.
Tue, Sep 17, 10:39 AM
gniibe committed rC38742196c04c: cipher:kyber: Add gcry_kem_genkey to support deterministic op. (authored by gniibe).
cipher:kyber: Add gcry_kem_genkey to support deterministic op.
Tue, Sep 17, 10:39 AM
gniibe changed the status of T7277: libgcrypt: Adding Known Answer Tests for KEM from Open to Testing.

Pushed the change in: rC38742196c04c: cipher:kyber: Add gcry_kem_genkey to support deterministic op.
rC4876a1a45c25: tests:kyber: Add genkey and encap KAT tests.

Tue, Sep 17, 9:39 AM · PQC, libgcrypt
gniibe added a comment to T7293: spawn API glitch.

Fixed GnuPG 2.4 in: rG730593affa91: common:w32: Don't expose unused functions.

Tue, Sep 17, 9:11 AM · gnupg24, gnupg22, gpgrt, Bug Report
gniibe added a comment to T7138: Windows (Semi-hosted environment): filename and network access.

For now, I'm using this to avoid failure of make check (invoking gpg-agent by gpg-connect-agent).

diff --git a/common/stringhelp.c b/common/stringhelp.c
index 9a2265258..6596c65cd 100644
--- a/common/stringhelp.c
+++ b/common/stringhelp.c
@@ -70,6 +70,22 @@ change_slashes (char *name)
 {
 #ifdef HAVE_DOSISH_SYSTEM
   char *p;
+  /* 0: don't know yet, 1: it's under wine, -1: no */
+  static int semihosted_by_wine;
+
+  /* Under wine, no change.  */
+  if (!semihosted_by_wine)
+    {
+      HMODULE hntdll = GetModuleHandle ("ntdll.dll");
+      if (hntdll
+          && GetProcAddress (hntdll, "wine_get_version"))
+        semihosted_by_wine = 1;
+      else
+        semihosted_by_wine = -1;
+    }
+
+  if (semihosted_by_wine > 0)
+    return name;
Tue, Sep 17, 4:40 AM · gnupg, Bug Report
gniibe updated the task description for T7293: spawn API glitch.
Tue, Sep 17, 3:15 AM · gnupg24, gnupg22, gpgrt, Bug Report
gniibe committed rG730593affa91: common:w32: Don't expose unused functions. (authored by gniibe).
common:w32: Don't expose unused functions.
Tue, Sep 17, 2:33 AM
gniibe set External Link to https://bugs.debian.org/1081807 on T7293: spawn API glitch.
Tue, Sep 17, 2:26 AM · gnupg24, gnupg22, gpgrt, Bug Report
gniibe updated the task description for T7293: spawn API glitch.
Tue, Sep 17, 2:23 AM · gnupg24, gnupg22, gpgrt, Bug Report
gniibe claimed T7293: spawn API glitch.

libgpg-error fix is done in: rEc2a713fe11e3: w32:spawn: Remove unused function get_max_fds.

Tue, Sep 17, 2:22 AM · gnupg24, gnupg22, gpgrt, Bug Report
gniibe created T7293: spawn API glitch.
Tue, Sep 17, 2:20 AM · gnupg24, gnupg22, gpgrt, Bug Report

Mon, Sep 16

gniibe committed rEc2a713fe11e3: w32:spawn: Remove unused function get_max_fds. (authored by gniibe).
w32:spawn: Remove unused function get_max_fds.
Mon, Sep 16, 9:00 AM
gniibe claimed T7291: scdaemon randomly hangs when trying to access a token.
Mon, Sep 16, 8:30 AM · scd
gniibe closed T7139: Windows: gnupg_exec_tool_stream with INEXTRA as Resolved.
Mon, Sep 16, 8:14 AM · gnupg26, Bug Report

Fri, Sep 13

gniibe committed rGb08d990607b6: tests:gpgscm: Raise an error correctly for process spawning. (authored by gniibe).
tests:gpgscm: Raise an error correctly for process spawning.
Fri, Sep 13, 4:04 AM

Thu, Sep 12

gniibe changed the status of T7220: The CF protection not enabled in libgcrypt from Open to Testing.
Thu, Sep 12, 7:17 AM · libgcrypt, Bug Report
gniibe changed the status of T7226: libgcrypt 1.11.0 buid error on armhf with gcc-14 from Open to Testing.
Thu, Sep 12, 7:17 AM · FTBFS, arm, libgcrypt, Bug Report
gniibe changed the status of T7246: libassuan 3.0.1: putc_unlocked() is re-defined unconditionally from Open to Testing.
Thu, Sep 12, 7:12 AM · libassuan, MacOS, Bug Report

Sep 11 2024

gniibe committed rG7e321c2c2a15: gpg: Fix getting key by IPGP. (authored by gniibe).
gpg: Fix getting key by IPGP.
Sep 11 2024, 6:56 AM
gniibe claimed T7288: gpg is not properly handling IPGP entries.
Sep 11 2024, 6:45 AM · dns, dirmngr, gnupg, Bug Report

Sep 9 2024

gniibe committed rP7f9f6bab93cc: curses: Factor out dialog release to separate function. (authored by Jakuje).
curses: Factor out dialog release to separate function.
Sep 9 2024, 10:37 AM
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

Since CreateProcessW allows two ways for lpEnvironment (one is ANSI environment block, another is Unicode environment block), if we want to support these two ways for users' of gpgrt spawn API, we would offer either:

Sep 9 2024, 8:31 AM · Bug Report, gpgrt
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

I'm talking about CreateProcessW and how a user of gpgrt spawn API can specify lpEnvironment (when needed).

Sep 9 2024, 8:03 AM · Bug Report, gpgrt
gniibe changed the status of T7218: pinentry memory leak from Open to Testing.

Thank you. Applied.

Sep 9 2024, 7:58 AM · pinentry, Bug Report
gniibe added a comment to T7288: gpg is not properly handling IPGP entries.

Thank you for the bug report and your patch.

Sep 9 2024, 7:19 AM · dns, dirmngr, gnupg, Bug Report
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

Please note that gpgrt_spawn_actions_set_envvars is W32 specific API in libgpg-error. Currently, the behavior with ASCII string is defined.
The patch is an answer in future if we want to extend the semantics supporting UTF-8.

Sep 9 2024, 2:53 AM · Bug Report, gpgrt

Sep 6 2024

gniibe added a project to T7277: libgcrypt: Adding Known Answer Tests for KEM: PQC.
Sep 6 2024, 8:50 AM · PQC, libgcrypt
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

Here is my attempt:

Sep 6 2024, 8:11 AM · Bug Report, gpgrt
gniibe committed rE0f7b327ccf6d: w32: Clarify the environment block encoding. (authored by gniibe).
w32: Clarify the environment block encoding.
Sep 6 2024, 4:33 AM
gniibe triaged T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8 as Normal priority.
Sep 6 2024, 4:06 AM · Bug Report, gpgrt
gniibe committed rG412e183e55c5: scd:w32: Fix for setting an environment block with GNUPGHOME. (authored by gniibe).
scd:w32: Fix for setting an environment block with GNUPGHOME.
Sep 6 2024, 3:55 AM

Sep 5 2024

gniibe committed rGc9677e950170: scd:w32: Export GNUPGHOME for scd-event. (authored by gniibe).
scd:w32: Export GNUPGHOME for scd-event.
Sep 5 2024, 6:40 AM
gniibe added a comment to T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ').

Use of execve is better (avoiding use of environ).

Sep 5 2024, 4:22 AM · gpgrt, MacOS, Bug Report
gniibe merged task T7168: environ not declared in macOS; gpgrt 1.50 failed to build. into T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ').
Sep 5 2024, 4:20 AM · gpgrt, Bug Report, MacOS
gniibe merged T7168: environ not declared in macOS; gpgrt 1.50 failed to build. into T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ').
Sep 5 2024, 4:20 AM · gpgrt, MacOS, Bug Report

Sep 4 2024

gniibe added a comment to T7246: libassuan 3.0.1: putc_unlocked() is re-defined unconditionally.

Fixed in: rA69069bc63e6b: Remove an declaration for an unused function

Sep 4 2024, 7:23 AM · libassuan, MacOS, Bug Report
gniibe added a project to T7277: libgcrypt: Adding Known Answer Tests for KEM: libgcrypt.
Sep 4 2024, 7:13 AM · PQC, libgcrypt
gniibe added a comment to T7277: libgcrypt: Adding Known Answer Tests for KEM.

I re-consider. Adding arguments to existing gcry_kem_keypair is not good since it introduces API break.
Instead, I add gcry_kem_genkey with additional arguments (which can be used for deterministic key generation).

Sep 4 2024, 7:07 AM · PQC, libgcrypt
gniibe changed the status of T7283: Odd "gpg: KEYTOCARD failed: Invalid time" error when using `--pinentry-mode=loopback` from Open to Testing.
Sep 4 2024, 1:34 AM · gpgagent, Bug Report

Sep 3 2024

werner awarded T7283: Odd "gpg: KEYTOCARD failed: Invalid time" error when using `--pinentry-mode=loopback` a Pterodactyl token.
Sep 3 2024, 11:02 AM · gpgagent, Bug Report
gniibe committed rG4a4c1efac59f: agent: Fix KEYTOCARD for the use case with loopback pinentry. (authored by gniibe).
agent: Fix KEYTOCARD for the use case with loopback pinentry.
Sep 3 2024, 7:20 AM
gniibe claimed T7283: Odd "gpg: KEYTOCARD failed: Invalid time" error when using `--pinentry-mode=loopback`.

I can replicate the problem.

Sep 3 2024, 7:06 AM · gpgagent, Bug Report
gniibe closed T7121: gnupg 2.2.43: scdaemon fails with KDF as Resolved.
Sep 3 2024, 3:35 AM · gnupg22 (gnupg-2.2.44), yubikey, scd, Bug Report

Aug 30 2024

gniibe added a comment to T7277: libgcrypt: Adding Known Answer Tests for KEM.

I was confused. We already have KAT for decap in t-mlkem.c.

Aug 30 2024, 7:57 AM · PQC, libgcrypt

Aug 29 2024

gniibe added a comment to T7277: libgcrypt: Adding Known Answer Tests for KEM.
Aug 29 2024, 8:23 AM · PQC, libgcrypt
gniibe triaged T7277: libgcrypt: Adding Known Answer Tests for KEM as Normal priority.
Aug 29 2024, 8:18 AM · PQC, libgcrypt

Aug 27 2024

gniibe committed rCcc95c36e7f79: cipher:kyber: Apply changes from upstream for final FIPS 203. (authored by gniibe).
cipher:kyber: Apply changes from upstream for final FIPS 203.
Aug 27 2024, 7:54 AM
gniibe committed rEb79d4206f482: w32: Add GPGRT_PROCESS_ALLOW_SET_FG for gpgrt_process_spawn. (authored by gniibe).
w32: Add GPGRT_PROCESS_ALLOW_SET_FG for gpgrt_process_spawn.
Aug 27 2024, 6:34 AM

Aug 26 2024

gniibe claimed T7264: libgcrypt `tests/pkcs1v2` test fails in FIPS mode.

That's my badness.
I noticed by the CI at https://gitlab.com/redhat-crypto/libgcrypt/libgcrypt-mirror

Aug 26 2024, 10:17 AM · libgcrypt, Bug Report
gniibe committed rS8331f3723990: Update *.m4. (authored by gniibe).
Update *.m4.
Aug 26 2024, 10:00 AM
gniibe committed rCbfbddd64002d: Fix previous commit. (authored by gniibe).
Fix previous commit.
Aug 26 2024, 4:27 AM

Aug 22 2024

gniibe committed rCced3a39b29af: tests: More fixes for tests/pkcs1v2.c. (authored by gniibe).
tests: More fixes for tests/pkcs1v2.c.
Aug 22 2024, 2:25 AM