Feed Advanced Search

Today

gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Here are the fixes:

diff --git a/common/init.c b/common/init.c
index 073c5cd8a..dbdf40527 100644
--- a/common/init.c
+++ b/common/init.c
@@ -161,17 +161,6 @@ _init_common_subsystems (gpg_err_source_t errsource, int *argcp, char ***argvp)
   /* Try to auto set the character set.  */
   set_native_charset (NULL);
Thu, Jul 16, 6:43 AM · gnupg, Windows
gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Call of WSAStartup in dirmngr/http.c is no problem, as we define HTTP_NO_WSASTARTUP.

Thu, Jul 16, 6:22 AM · gnupg, Windows
gniibe updated the task description for T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.
Thu, Jul 16, 6:18 AM · gnupg, Windows
gniibe committed rG8abf065307ff: common: Avoid undefined behavior of left shift operator. (authored by gniibe).
common: Avoid undefined behavior of left shift operator.
Thu, Jul 16, 4:20 AM
gniibe added a commit to T4975: undefined-shift in block_filter: rG8abf065307ff: common: Avoid undefined behavior of left shift operator..
Thu, Jul 16, 4:20 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T4624: libassuan-config and libassuan.pc both put -lws2_32 before -lgpg-error, which fails during static linking.

This fix reveals the problem of: T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem

Thu, Jul 16, 3:11 AM · Testing, Windows, libassuan, Bug Report
gniibe updated the task description for T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.
Thu, Jul 16, 3:06 AM · gnupg, Windows
gniibe created T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.
Thu, Jul 16, 3:03 AM · gnupg, Windows

Yesterday

gniibe committed rG8904b18822fc: regexp: Fix generation of _unicode_mapping.c. (authored by gniibe).
regexp: Fix generation of _unicode_mapping.c.
Wed, Jul 15, 7:30 AM
gniibe committed rGb4cbb5f58a00: tools: Use internal regexp routines. (authored by gniibe).
tools: Use internal regexp routines.
Wed, Jul 15, 7:30 AM
gniibe committed rG199309190a0b: gpg: Add regular expression support. (authored by gniibe).
gpg: Add regular expression support.
Wed, Jul 15, 7:30 AM
gniibe committed rG1d1f2aa94370: regexp: Import change from JimTcl. (authored by gniibe).
regexp: Import change from JimTcl.
Wed, Jul 15, 7:30 AM
gniibe added a commit to T4843: REGEXP support for all systems: rG199309190a0b: gpg: Add regular expression support..
Wed, Jul 15, 7:30 AM · Testing, gnupg
gniibe added a commit to T4915: Cannot compile on macOS Mojave (utf8.c): rG8904b18822fc: regexp: Fix generation of _unicode_mapping.c..
Wed, Jul 15, 7:30 AM · Testing, gnupg (gpg23), Bug Report
gniibe committed rEc564d8c5a0e7: w32: Add gpgrt_fcancel to the definition. (authored by gniibe).
w32: Add gpgrt_fcancel to the definition.
Wed, Jul 15, 7:02 AM
gniibe committed rG91cb46d948db: regexp: Import change from JimTcl. (authored by gniibe).
regexp: Import change from JimTcl.
Wed, Jul 15, 2:45 AM
gniibe added a comment to T4992: ssh Yubikey not recognized, but Yubikey works with GPG well.

A reference might help:
https://blogs.itemis.com/en/openpgp-on-the-job-part-8-ssh-with-openpgp-and-yubikey

Wed, Jul 15, 2:16 AM · Bug Report, gpg4win
gniibe added a comment to T3763: ECDH - encryption with obfuscated size of the symmetric key.

@mbrinkers : I think that it was fixed in GnuPG 2.2.21 by T4908: ECDH with AES-128 decryption failure when fully padded.
It was unfortunate that this bug report didn't work to solve problem, with malformed data and discussion went to unrelated thing.

Wed, Jul 15, 2:01 AM · OpenPGP, gnupg (gpg23)

Tue, Jul 14

gniibe committed rCe0dabf74bf27: ecc: Support reading EC point in compressed format for good curves. (authored by gniibe).
ecc: Support reading EC point in compressed format for good curves.
Tue, Jul 14, 9:13 AM
gniibe added a commit to T4951: Support point compression in Libgcrypt: rCe0dabf74bf27: ecc: Support reading EC point in compressed format for good curves..
Tue, Jul 14, 9:13 AM · Feature Request, libgcrypt
gniibe added a comment to T4992: ssh Yubikey not recognized, but Yubikey works with GPG well.

So, where does "ssh-add" command come from? IIUC, it is from OpenSSH.

Tue, Jul 14, 8:40 AM · Bug Report, gpg4win
gniibe added a comment to T4992: ssh Yubikey not recognized, but Yubikey works with GPG well.

You mean running OpenSSH (and its tool ssh-add) on Windows, right?
It is not supported. PuTTY is supported.

Tue, Jul 14, 3:59 AM · Bug Report, gpg4win

Mon, Jul 13

gniibe added a comment to T4951: Support point compression in Libgcrypt.
  • compressed representation of EC point can be used in:
    • public key
    • (exporting) private key
    • signature
    • ECDH ephemeral key
  • For the initial implementation, I'd like to limit our effort for curves of NIST and Brainpool, except NIST P-224, which p = 3 mod 4.
Mon, Jul 13, 10:06 AM · Feature Request, libgcrypt
gniibe added a comment to E665: Weekly Standup.

Topics:

Last week:

This week:

Mon, Jul 13, 4:26 AM
gniibe is attending E665: Weekly Standup.
Mon, Jul 13, 4:21 AM
gniibe claimed T4975: undefined-shift in block_filter.
Mon, Jul 13, 4:18 AM · gnupg (gpg22), Bug Report
gniibe triaged T4977: dirmngr not working with linux kernel parameter ipv6.disable=1 as Normal priority.
Mon, Jul 13, 3:14 AM · Testing, gnupg (gpg22), dirmngr, Bug Report
gniibe changed the status of T4977: dirmngr not working with linux kernel parameter ipv6.disable=1 from Open to Testing.

Pushed fix to master and STABLE-BRANCH-2-2.

Mon, Jul 13, 3:13 AM · Testing, gnupg (gpg22), dirmngr, Bug Report
gniibe committed rGce793fc2f838: dirmngr: Handle EAFNOSUPPORT at connect_server. (authored by gniibe).
dirmngr: Handle EAFNOSUPPORT at connect_server.
Mon, Jul 13, 3:13 AM
gniibe added a commit to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1: rGce793fc2f838: dirmngr: Handle EAFNOSUPPORT at connect_server..
Mon, Jul 13, 3:13 AM · Testing, gnupg (gpg22), dirmngr, Bug Report
gniibe committed rG109d16e8f644: dirmngr: Handle EAFNOSUPPORT at connect_server. (authored by gniibe).
dirmngr: Handle EAFNOSUPPORT at connect_server.
Mon, Jul 13, 3:11 AM
gniibe added a commit to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1: rG109d16e8f644: dirmngr: Handle EAFNOSUPPORT at connect_server..
Mon, Jul 13, 3:11 AM · Testing, gnupg (gpg22), dirmngr, Bug Report
gniibe added a comment to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.

Thanks for your log.

Mon, Jul 13, 2:54 AM · Testing, gnupg (gpg22), dirmngr, Bug Report

Fri, Jul 10

gniibe added a comment to T4951: Support point compression in Libgcrypt.

(3) _gcry_ecc_os2ec in libgcrypt/mpi/ec.c should be modified to support parsing compressed representation.

Fri, Jul 10, 8:19 AM · Feature Request, libgcrypt
gniibe added a comment to T4975: undefined-shift in block_filter.

While I see that it's not the matter of actual use case (but how gpg can be immune to fuzzing), code clean up would be good here.

Fri, Jul 10, 4:34 AM · gnupg (gpg22), Bug Report
gniibe added a comment to D503: fix undefined-shift in block_filter.

Thanks for the patch.
I see your point in T4975: undefined-shift in block_filter.
You are right that we have a problem of possible overflow (which could be kicked by fuzzing) here.
(The actual impact would be small, though).

Fri, Jul 10, 4:26 AM
gniibe claimed T4951: Support point compression in Libgcrypt.
Fri, Jul 10, 3:41 AM · Feature Request, libgcrypt
gniibe added a comment to T4951: Support point compression in Libgcrypt.

What kind of API should we offer?
(1) offering something like q@comp name for gcry_mpi_ec_get_mpi
But...
If the intended use case will be in create_request function in gpg/sm/certreqgen.c for subjectKeyIdentifier, the 'q' is already generated in the form of SEXP.
It is up to an application (gpgsm), to convert non-compressed point representation to compressed point representation, here.

Fri, Jul 10, 3:40 AM · Feature Request, libgcrypt
gniibe changed the status of T4246: GnuPG master does not allow decryption with bad usage flags (regression), a subtask of T4417: Work needed for gnupg 2.3, from Open to Testing.
Fri, Jul 10, 3:04 AM · gnupg (gpg23)
gniibe changed the status of T4246: GnuPG master does not allow decryption with bad usage flags (regression) from Open to Testing.
Fri, Jul 10, 3:04 AM · Testing, Bug Report, gnupg (gpg23)
gniibe committed rG31ae0718ba10: gpg: For decryption, support use of a key with no 'encrypt' usage. (authored by gniibe).
gpg: For decryption, support use of a key with no 'encrypt' usage.
Fri, Jul 10, 3:03 AM
gniibe added a commit to T4246: GnuPG master does not allow decryption with bad usage flags (regression): rG31ae0718ba10: gpg: For decryption, support use of a key with no 'encrypt' usage..
Fri, Jul 10, 3:03 AM · Testing, Bug Report, gnupg (gpg23)

Thu, Jul 9

gniibe claimed T4246: GnuPG master does not allow decryption with bad usage flags (regression).
Thu, Jul 9, 8:20 AM · Testing, Bug Report, gnupg (gpg23)
gniibe added a comment to T4246: GnuPG master does not allow decryption with bad usage flags (regression).

Or this (don't allow anon keys for different usage):

diff --git a/g10/pubkey-enc.c b/g10/pubkey-enc.c
index 14cbdbb0f..b8d4059cd 100644
--- a/g10/pubkey-enc.c
+++ b/g10/pubkey-enc.c
@@ -91,9 +91,6 @@ get_session_key (ctrl_t ctrl, struct pubkey_enc_list *list, DEK *dek)
       if (err)
         break;
Thu, Jul 9, 8:20 AM · Testing, Bug Report, gnupg (gpg23)
gniibe added a comment to T4246: GnuPG master does not allow decryption with bad usage flags (regression).

Do you mean something like this?

Thu, Jul 9, 8:11 AM · Testing, Bug Report, gnupg (gpg23)
gniibe changed the status of T4688: `make distcheck` fails trying to make `rst/gpgme-python-howto.rst` from Open to Testing.

Fixed in rM1b840a151ad7: python: Fix how to generate documentation..

Thu, Jul 9, 7:23 AM · Testing, gpgme, Bug Report
gniibe changed the status of T4915: Cannot compile on macOS Mojave (utf8.c) from Open to Testing.
Thu, Jul 9, 7:07 AM · Testing, gnupg (gpg23), Bug Report
gniibe changed the status of T4973: Cross build problem with v1.38 from Open to Testing.
Thu, Jul 9, 7:05 AM · Testing, gpgrt
gniibe added a parent task for T4160: ed488 support: T4417: Work needed for gnupg 2.3.
Thu, Jul 9, 7:00 AM · Testing, gnupg (gpg23), Feature Request
gniibe added a subtask for T4417: Work needed for gnupg 2.3: T4160: ed488 support.
Thu, Jul 9, 7:00 AM · gnupg (gpg23)
gniibe added a parent task for T4246: GnuPG master does not allow decryption with bad usage flags (regression): T4417: Work needed for gnupg 2.3.
Thu, Jul 9, 6:55 AM · Testing, Bug Report, gnupg (gpg23)
gniibe added a subtask for T4417: Work needed for gnupg 2.3: T4246: GnuPG master does not allow decryption with bad usage flags (regression).
Thu, Jul 9, 6:55 AM · gnupg (gpg23)
gniibe changed the status of T4160: ed488 support from Open to Testing.

It's in master (to be gnupg 2.3).
Enjoy.

Thu, Jul 9, 6:53 AM · Testing, gnupg (gpg23), Feature Request

Tue, Jul 7

gniibe committed rG34c9cfd3d772: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Tue, Jul 7, 2:45 AM

Mon, Jul 6

gniibe added a comment to E664: Weekly Standup.

Last week:

Mon, Jul 6, 3:06 AM
gniibe is attending E664: Weekly Standup.
Mon, Jul 6, 3:01 AM

Thu, Jul 2

gniibe added a comment to T4981: internationalization (support UNICODE/UTF-8 character set).

It seems that nl_langinfo(CODESET) returns US-ASCII on your system.

Thu, Jul 2, 8:16 AM · i18n, FreeBSD, Feature Request
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Yes, it will fix the problem on x32, I suppose.
If it's difficult for dpkg, for some reason for now, workaround for gpgme packaging is disabling pie hardening for x32 until pie will be its compiler default.
For gpgme, it is only test binaries which matter (pie or not), so, the impact (for x32) is minimum.

Thu, Jul 2, 2:15 AM · Debian, gpgme

Wed, Jul 1

gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Some information of Qt5 about -fpic:

Wed, Jul 1, 8:49 AM · Debian, gpgme
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Debian's GCC build for PIE default: https://salsa.debian.org/toolchain-team/gcc/-/blob/master/debian/rules.defs#L1400

Wed, Jul 1, 5:09 AM · Debian, gpgme
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Here is my understanding. My point is it's not problem of gpgme. To fix it correctly, I think that dpkg should be fixed and it would be needed to fix Qt too.

Wed, Jul 1, 4:52 AM · Debian, gpgme

Tue, Jun 30

gniibe committed rG45398518fb76: ecc: Support Ed448/X448 key generation. (authored by gniibe).
ecc: Support Ed448/X448 key generation.
Tue, Jun 30, 7:22 AM
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.
Tue, Jun 30, 6:44 AM · Debian, gpgme
gniibe added a comment to T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

I think that it is the problem of dpkg to override the compiler flag by the spec file. When compiler default is -fPIE, it works well. If not (for the case of x32), it fails.
In the past, hurd-i386 had same issue, but compiler default seems to be now -fPIE, thus no problem.

Tue, Jun 30, 6:06 AM · Debian, gpgme
gniibe triaged T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic as Normal priority.
Tue, Jun 30, 4:36 AM · Debian, gpgme
gniibe claimed T4982: [PATCH] qt libraries should be linked with -fPIC instead of -fpic.

Thanks for your report.

Tue, Jun 30, 4:34 AM · Debian, gpgme

Mon, Jun 29

gniibe added a comment to E663: Weekly Standup.

Last week:

  • Applied changing UI of GnuPG master "cv448" to specify X448 to align to cv25519
  • Pushed Ed448 support in GnuPG: D505: Ed448 support for GnuPG
  • Chopstx 2.0 with RISC-V core support

This week:

Mon, Jun 29, 3:38 AM
gniibe is attending E663: Weekly Standup.
Mon, Jun 29, 3:26 AM

Fri, Jun 26

gniibe added a comment to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.

When I test it on Debian, disabling by,

Fri, Jun 26, 7:25 AM · Testing, gnupg (gpg22), dirmngr, Bug Report
gniibe claimed T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.
Fri, Jun 26, 7:06 AM · Testing, gnupg (gpg22), dirmngr, Bug Report
gniibe added a comment to T4977: dirmngr not working with linux kernel parameter ipv6.disable=1.

Please get log of dirmngr, by putting

log-file /run/user/<YOURNUMBER-LIKE-1000>/dirmngr.log
Fri, Jun 26, 7:04 AM · Testing, gnupg (gpg22), dirmngr, Bug Report

Wed, Jun 24

gniibe added a comment to T4979: enable-ssh-support in windows is broken..

I think the feature is not (yet) supported on Windows.
Please see: T3883: Add Win32-OpenSSH support to gpg-agent's ssh-agent

Wed, Jun 24, 4:05 AM · ssh, Duplicate, Bug Report
gniibe added a comment to D505: Ed448 support for GnuPG.

Pushed to master as rGa763bb2580b0: gpg,agent: Support Ed448 signing..

Wed, Jun 24, 3:17 AM
gniibe committed rGa763bb2580b0: gpg,agent: Support Ed448 signing. (authored by gniibe).
gpg,agent: Support Ed448 signing.
Wed, Jun 24, 3:16 AM

Tue, Jun 23

gniibe updated the diff for D505: Ed448 support for GnuPG.

Update to [rGc94eea15d}.
Hash defaults to SHA512.

Tue, Jun 23, 3:56 AM
gniibe committed rGc94eea15d684: ecc: Use "cv448" to specify key using X448. (authored by gniibe).
ecc: Use "cv448" to specify key using X448.
Tue, Jun 23, 3:21 AM
gniibe committed rC1db1dc7945b1: ecc: Fix length computation. (authored by gniibe).
ecc: Fix length computation.
Tue, Jun 23, 3:11 AM

Mon, Jun 22

gniibe added a comment to E657: Weekly Standup.

Last week:

  • Pushed the change for Ed448 to libgcrypt (no optimization at all): D504: ECC change for Ed448
  • Created (and updated) the change for Ed448 to GnuPG: D505: Ed448 support for GnuPG
  • Minor clean up in GnuPG to prepare accepting D505
  • Tested OpenPGP card v3.4 implementation by Achim
    • flashing was done successfully with TTXS reader
    • no problem with current GnuPG
    • tested against Gnuk's test suite
    • found a minor difference: In V3.4, SEX DO factory setting is '0' (Unknown), while it used to be '9' (N/A)
      • ISO/IEC 5218 thing
      • I don't know if we need to modify GnuPG or not

This week:

  • Change UI of GnuPG master "cv448" to specify X448 to align to cv25519
  • Others: FSIJ accounting of FY2019 and AGM 2020

D505:

  • I realized that the patch number looks like "SOS" :-)
  • For "Ed25519", libgcrypt supports ECDSA as well as EdDSA
    • And Gnunet looks like using it (I don't know if it's intended or not)
    • I don't know if it works well, I'm afraid cofactor matters
    • but for "Ed448", ECDSA is not supported
    • Anyway, because of this, a key or sig-data with Ed25519 curve for EdDSA has "(flags eddsa)"
  • Learning math for elliptic integral and Jacobi elliptic functions
Mon, Jun 22, 5:06 AM
gniibe is attending E657: Weekly Standup.
Mon, Jun 22, 4:24 AM

Fri, Jun 19

gniibe added a comment to D505: Ed448 support for GnuPG.

(1) Has no (flags eddsa) in key in SEXP.
(2) Has no (flags eddsa) and no (hash-algo shake256) in data to be signed in SEXP.
(3) Has no (flags eddsa) and no (hash-algo shake256) in data to be verified in SEXP.
(4) Uses SHA256 for hashing of OpenPGP data

Fri, Jun 19, 8:14 AM
gniibe updated the diff for D505: Ed448 support for GnuPG.

Update to rG4bdade5b0bea: agent: Use get_pk_algo_from_key.

Fri, Jun 19, 8:12 AM
gniibe committed rG4bdade5b0bea: agent: Use get_pk_algo_from_key. (authored by gniibe).
agent: Use get_pk_algo_from_key.
Fri, Jun 19, 7:47 AM
gniibe committed rGd2e4aa5ee4c5: agent: Clean up for getting info from SEXP. (authored by gniibe).
agent: Clean up for getting info from SEXP.
Fri, Jun 19, 7:07 AM
gniibe committed rGabc6a3100a33: agent: A little clean up. (authored by gniibe).
agent: A little clean up.
Fri, Jun 19, 7:07 AM

Thu, Jun 18

gniibe committed rCf2847d56cce2: ecc: Fix the condition for EdDSA data handling. (authored by gniibe).
ecc: Fix the condition for EdDSA data handling.
Thu, Jun 18, 6:52 AM
gniibe committed rCa6177e1bc948: ecc: For Ed448, it's only for EdDSA. (authored by gniibe).
ecc: For Ed448, it's only for EdDSA.
Thu, Jun 18, 6:52 AM
gniibe committed rCba78ad8f1967: ecc: Support EdDSA with context and enabling PH(M). (authored by gniibe).
ecc: Support EdDSA with context and enabling PH(M).
Thu, Jun 18, 4:50 AM
gniibe committed rC2856ac14ae3e: ecc: Change EdDSA internal API. (authored by gniibe).
ecc: Change EdDSA internal API.
Thu, Jun 18, 2:54 AM

Wed, Jun 17

gniibe committed rC1cf497546946: ecc: Support "label" for EdDSA context in data. (authored by gniibe).
ecc: Support "label" for EdDSA context in data.
Wed, Jun 17, 10:02 AM
gniibe committed rCd51a9c259d49: ecc: Initialize key before handling data. (authored by gniibe).
ecc: Initialize key before handling data.
Wed, Jun 17, 10:02 AM
gniibe committed rC9a640eba6dd7: ecc: Add new flag "prehash". (authored by gniibe).
ecc: Add new flag "prehash".
Wed, Jun 17, 9:46 AM
gniibe committed rCb1721f9b291a: ecc: No (flags eddsa) required for Ed448. (authored by gniibe).
ecc: No (flags eddsa) required for Ed448.
Wed, Jun 17, 5:48 AM
gniibe committed rC5585ee494708: ecc: Support Ed448 by _gcry_ecc_compute_public. (authored by gniibe).
ecc: Support Ed448 by _gcry_ecc_compute_public.
Wed, Jun 17, 5:48 AM
gniibe added a comment to D505: Ed448 support for GnuPG.

The changes just follow the existing practice of Ed25519, which does:

Wed, Jun 17, 3:21 AM

Jun 16 2020

gniibe created D505: Ed448 support for GnuPG.
Jun 16 2020, 9:30 AM
gniibe committed rCc15cc1a38199: ecc: Fix Ed448 key generation. (authored by gniibe).
ecc: Fix Ed448 key generation.
Jun 16 2020, 9:24 AM
gniibe committed rCc7779e499e90: ecc,test: Add testing Ed448. (authored by gniibe).
ecc,test: Add testing Ed448.
Jun 16 2020, 4:26 AM
gniibe committed rCd1baad35c650: ecc: Support Ed448 for verify. (authored by gniibe).
ecc: Support Ed448 for verify.
Jun 16 2020, 4:26 AM
gniibe committed rCe25446ecc044: ecc: Support Ed448 for key generation. (authored by gniibe).
ecc: Support Ed448 for key generation.
Jun 16 2020, 4:26 AM
gniibe committed rC951b37c50386: ecc: Support Ed448 signing. (authored by gniibe).
ecc: Support Ed448 signing.
Jun 16 2020, 4:26 AM