Page MenuHome GnuPG
Differential D522

libgcrypt Mac M1 build fix proposal
Needs ReviewPublic
Actions

Authored by devnexen on Jan 24 2021, 10:03 AM.

Details

Reviewers
• gniibe
Summary
  • getentropy needs sys/random.h
  • leading zero counting needs w constraint due to wider types than int.
Test Plan

Just tried to build in a mac m1

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

devnexen created this revision.Jan 24 2021, 10:03 AM
devnexen added a reviewer: • gniibe.
devnexen updated this revision to Diff 1465.Jan 24 2021, 1:16 PM

Check header presence instead for getentropy.

• gniibe edited edge metadata.Jan 26 2021, 3:55 AM

Please note that we also have a commit rC477355047e5c: mpi/longlong: make use of compiler provided __builtin_ctz/__builtin_clz.

mpi/longlong.h
308

Did you checked the output in assembly language?

IIUC, it doesn't work.

%w is for HImode (2-byte) register.

Do you mean %q, which specifies DImode, to generate register name of X<something>?

• gniibe added inline comments.Jan 26 2021, 4:04 AM
mpi/longlong.h
308

IIUC, I think that what you need is rCc59b5b03a063: aarch64: mpi/longlong.h: fix operand size mismatch.

• gniibe mentioned this in T5268: macOS getentropy.Jan 26 2021, 4:56 AM
• gniibe added a comment.Jan 26 2021, 5:40 AM

I created T5268, please continue discussion there.

Revision Contents
Changeset List

PathSize
2 lines
mpi/
2 lines
random/
3 lines

Diff 1465

View Options

configure.ac

Loading...
View Options

mpi/longlong.h

Loading...
View Options

random/rndlinux.c

Loading...