Page MenuHome GnuPG

qt: make the pin entry dialog float again
Needs ReviewPublic

Authored by qyliss on Feb 18 2022, 9:57 PM.
This revision needs review, but all reviewers have resigned.



After 85b180f ("qt: Show hint if passphrase is shown and formatting is enabled"), Sway would attempt to tile the pin entry dialog window, because the size constraint was removed.

I'm not sure if this is the right fix, because I don't know how to test pinentry with a passphrase hint, since AFAICT GnuPG doesn't support it yet. But it does solve a problem I've been having since upgrading to 1.2.0 where Sway would try to tile this dialog instead of having it float as it did before.

Test Plan

Cause the pinentry dialog to be opened in Sway, and see that it floats again.

It should be tested that this change doesn't break the layout of the password hint, but I don't know how to do that.

Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline

qyliss created this revision.
This revision is now accepted and ready to land.Jun 23 2022, 1:43 PM

This patch can be closed, but I seem to lack the permissions to do so.

Resigning as reviewer since I cannot close it, but want to have it off of my list.

This revision now requires review to proceed.Jan 11 2023, 11:07 AM