Page MenuHome GnuPG
Differential D552

gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid
ClosedPublic
Actions

Authored by • ikloecker on Apr 21 2022, 4:49 PM.

Details

Reviewers
• werner
Maniphest Tasks
T5936: gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid
Summary

Patch for T5936: gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid.

Test Plan

Run gpg's --quick-revoke-uid command with verbatim user IDs and with UID hashes.

Diff Detail

Repository
rG GnuPG
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

• ikloecker requested review of this revision.Apr 21 2022, 4:49 PM
• ikloecker created this revision.
• ikloecker added a task: T5936: gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid.
• werner accepted this revision.Apr 22 2022, 6:45 PM

The rest of the code looks fine.

g10/keyedit.c
2465

There is an easier way to do this. See for example agent/command.c:parse_keygrip. The extended error messages are not required but using hex2bin makes sense to me.

This revision is now accepted and ready to land.Apr 22 2022, 6:45 PM
• ikloecker closed this revision.May 27 2022, 9:23 PM
• ikloecker marked an inline comment as done.

The changes have been applied with Werner's suggested improvement with revision rG35b17550706c: gpg: Look up user ID to revoke by UID hash

• canti59 added a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:11 AM
• gniibe removed a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:50 AM

Revision Contents
Changeset List

PathSize
g10/
124 lines

Diff 1513

View Options

g10/keyedit.c

Loading...