qt: Add #include <QStringList> needed for building against qt6
ClosedPublic
Actions

Authored by mlaurent on Jun 29 2022, 7:08 AM.

Details

Reviewers

• ikloecker

Commits

rMd42323f90213: qt: Add #include <QStringList> needed for building against qt6

Summary

lang/qt/src/downloadjob.h, lang/qt/src/exportjob.h, lang/qt/src/keylistjob.h lang/qt/src/refreshkeysjob.h: in qt6 we need

to use #include <QStringList>

It fixes some compile qt6 compile error.

Signed-off-by: Laurent Montel <montel@kde.org>

Test Plan

compile + launch test

Diff Detail

Repository

rM GPGME

Branch

add_missing_include_qt6

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

mlaurent requested review of this revision.Jun 29 2022, 7:08 AM

mlaurent created this revision.

mlaurent added a reviewer: • ikloecker.Jun 29 2022, 7:08 AM

Ping ?

You have not yet sent a signed DCO to gnupg-devel@gnupg.org (or it's stuck in the moderation queue). Moreover, you do not seem to have signed off your commit.

I think it's best if you send your patches to gnupg-devel@gnupg.org instead of using dev.gnupg.org. Phabricator makes it too difficult to apply your commits.

Sorry. Just saw that you have signed off your commit.

In D558#5636, @ikloecker wrote:

You have not yet sent a signed DCO to gnupg-devel@gnupg.org (or it's stuck in the moderation queue). Moreover, you do not seem to have signed off your commit.

I think it's best if you send your patches to gnupg-devel@gnupg.org instead of using dev.gnupg.org. Phabricator makes it too difficult to apply your commits.

Ok I will send them to gnupg-devel@gnupg.org

• ikloecker accepted this revision.Jul 4 2022, 5:14 PM

This revision is now accepted and ready to land.Jul 4 2022, 5:14 PM

• ikloecker added a project: gpgme.Jul 4 2022, 5:15 PM

Applied with rMd42323f90213: qt: Add #include <QStringList> needed for building against qt6