Page MenuHome GnuPG
Differential D561

w32: mbox-util: guard unistd.h include on Windows
Needs ReviewPublic
Actions

Authored by wrobelda on Aug 22 2022, 5:47 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

unistd.h is being included unconditionally, but should be guarded by the #ifdef HAVE_UNISTD_H

Test Plan
  1. confirm compiles on non-Windows platform
  2. confirm compiles on Windows platform

Diff Detail

Repository
rM GPGME
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

wrobelda requested review of this revision.Aug 22 2022, 5:47 PM
wrobelda created this revision.
wrobelda added a comment.EditedAug 22 2022, 7:08 PM

Actually, there's plenty more locations where unistd.h is included unconditionally, all of which should likely embrace in guards like this.

• canti59 added a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:11 AM
• gniibe removed a commit: rG8046fcac63db: po: Update Czech translation..Oct 14 2022, 2:50 AM

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 1530

View Options

src/mbox-util.c

Loading...