Page MenuHome GnuPG

Remove non-symbol npth_sigmask/npth_sigwait
AcceptedPublic

Authored by MaskRay on Mon, Jan 16, 7:35 PM.

Details

Summary

npth_sigmask and npth_sigwait are not symbols, so
-Wl,--no-undefined-version will report errors. Actually npth_sigwait is
not defined, so just remove it. The npth_sigmask macro is used by
gnupg/g13/g13.c, so keep it.

  • src/npth.h.in: Remove npth_sigmask and npth_sigwait.
  • w32/npth.h: Likewise.
  • src/libnpth.vers: Likewise.

symbols to fix -Wl,--no-undefined-version

Test Plan

make all

Diff Detail

Repository
rPTH nPth
Branch
version-script
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

MaskRay created this revision.

I don't have write permission to the repository.

This patch fixes linker errors with GNU ld/gold/ld.lld --no-undefined-version. See https://github.com/gentoo/gentoo/pull/29097 and https://maskray.me/blog/2020-11-15-explain-gnu-linker-options#no-undefined-version

MaskRay edited the summary of this revision. (Show Details)
MaskRay removed a reviewer: gniibe.

keep the macro as it is used

Thank you for the patch.

I'm going to apply the first one, as it is needed in the case, and it makes sense.

On the other hand, API-wise, for POSIX, having npth_sigwait makes sense.
So, I keep the declarations, at least for now.

This revision is now accepted and ready to land.Tue, Jan 17, 5:59 AM
gniibe mentioned this in Unknown Object (Event).Mon, Jan 23, 8:20 AM