Page MenuHome GnuPG
Differential D564

Remove non-symbol npth_sigmask/npth_sigwait
ClosedPublic
Actions

Authored by MaskRay on Jan 16 2023, 7:35 PM.

Details

Reviewers
sergi
• gniibe
• werner
Summary

npth_sigmask and npth_sigwait are not symbols, so
-Wl,--no-undefined-version will report errors. Actually npth_sigwait is
not defined, so just remove it. The npth_sigmask macro is used by
gnupg/g13/g13.c, so keep it.

  • src/npth.h.in: Remove npth_sigmask and npth_sigwait.
  • w32/npth.h: Likewise.
  • src/libnpth.vers: Likewise.

symbols to fix -Wl,--no-undefined-version

Test Plan

make all

Diff Detail

Repository
rPTH nPth
Branch
version-script
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

MaskRay requested review of this revision.Jan 16 2023, 7:35 PM
MaskRay created this revision.
MaskRay added a reviewer: • gniibe.EditedJan 16 2023, 7:36 PM

I don't have write permission to the repository.

This patch fixes linker errors with GNU ld/gold/ld.lld --no-undefined-version. See https://github.com/gentoo/gentoo/pull/29097 and https://maskray.me/blog/2020-11-15-explain-gnu-linker-options#no-undefined-version

MaskRay updated this revision to Diff 1536.Jan 16 2023, 7:59 PM
MaskRay edited the summary of this revision. (Show Details)
MaskRay removed a reviewer: • gniibe.

keep the macro as it is used

MaskRay added reviewers: • gniibe, • werner.Jan 16 2023, 7:59 PM
• gniibe added a comment.Jan 17 2023, 5:59 AM

Thank you for the patch.

I'm going to apply the first one, as it is needed in the case, and it makes sense.

On the other hand, API-wise, for POSIX, having npth_sigwait makes sense.
So, I keep the declarations, at least for now.

• gniibe accepted this revision.Jan 17 2023, 5:59 AM
This revision is now accepted and ready to land.Jan 17 2023, 5:59 AM
MaskRay closed this revision.Aug 17 2023, 12:12 AM

Thank you! Closed by https://github.com/gpg/npth/commit/bd356d82394447b51b2505756094d6475e160a4b

Revision Contents
Changeset List

PathSize
src/
2 lines
1 line
w32/
6 lines

Diff 1536

View Options

src/libnpth.vers

Loading...
View Options

src/npth.h.in

Loading...
View Options

w32/npth.h

Loading...