Page MenuHome GnuPG
Differential D577

cpp: Port away from gnu deprecated extension
Needs RevisionPublic
Actions

Authored by CarlSchwan on Jan 22 2024, 10:45 AM.

Details

Reviewers
ikloecker
TobiasFella
Summary
  • lang/cpp/src/gpgmepp_export.h, lang/qt/src/qgpgme_export.h Declare the deprecated macro using the deprecated attribute
  • lang/cpp/src/key.h, lang/qt/src/downloadjob.h, lang/cpp/src/verificationresult.h adapt usage to the deprecated macro being an attribute --

Use instead the standard deprecated macro which is compatible with
all the C++ compilers and not just GCC and clang.

Test Plan

Compiles fine on Linux and with a bunch of other change on MSVC

Diff Detail

Repository
rM GPGME
Branch
work/carl/port-away-gnu-deprecated-extension
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

CarlSchwan requested review of this revision.Jan 22 2024, 10:45 AM
CarlSchwan created this revision.
CarlSchwan added reviewers: ikloecker, TobiasFella.Jan 22 2024, 10:47 AM
ikloecker requested changes to this revision.Jan 22 2024, 4:35 PM

For the C++ binding and the Qt 5 binding we require C++ 11. The deprecated attribute was added with C++ 14.

This revision now requires changes to proceed.Jan 22 2024, 4:35 PM
CarlSchwan added a comment.Jan 23 2024, 10:17 AM
In D577#6100, @ikloecker wrote:

For the C++ binding and the Qt 5 binding we require C++ 11. The deprecated attribute was added with C++ 14.

:(

I see two solutions:

  • make QGPGME_DEPRECATED noop on MSVC
  • use C++14 in the c++ bindings, this is already 9 years old, so likely no issue for any of our consumers

Revision Contents
Changeset List

PathSize
lang/
cpp/
src/
2 lines
2 lines
2 lines
qt/
src/
2 lines
2 lines

Diff 1569

View Options

lang/cpp/src/gpgmepp_export.h

Loading...
View Options

lang/cpp/src/key.h

Loading...
View Options

lang/cpp/src/verificationresult.h

Loading...
View Options

lang/qt/src/downloadjob.h

Loading...
View Options

lang/qt/src/qgpgme_export.h

Loading...