Page MenuHome GnuPG

Fix display window icon on Wayland
ClosedPublic

Authored by CarlSchwan on Jan 29 2024, 3:04 PM.

Details

Summary

On wayland, the icon is read from the .desktop file so ensure that
QApplication::setWindowIcon and the .desktop file point are using the correct
icon name

Test Plan

Icon is now displayed on Wayland

Diff Detail

Repository
rGPGPASS GnuPG Password Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

CarlSchwan created this revision.
main/main.cpp
54

shouldn't we then also install such an icon somewhere, like into hicolor theme ?

main/main.cpp
54

We already do in CMakeLists.txt

See

install(FILES artwork/sc-gpgpass.svg DESTINATION ${KDE_INSTALL_FULL_ICONDIR}/hicolor/scalable/apps RENAME org.gnupg.gpgpass.svg)

This revision is now accepted and ready to land.Jan 29 2024, 4:03 PM
CarlSchwan mentioned this in Unknown Object (Event).Mon, Feb 5, 9:29 AM
This revision was automatically updated to reflect the committed changes.