Fix display window icon on Wayland
ClosedPublic
Actions

Authored by CarlSchwan on Jan 29 2024, 3:04 PM.

Details

Reviewers

Commits

rGPGPASS0aae2e831f5f: Fix display window icon on Wayland

Summary

On wayland, the icon is read from the .desktop file so ensure that
QApplication::setWindowIcon and the .desktop file point are using the correct
icon name

Test Plan

Icon is now displayed on Wayland

Diff Detail

Repository

rGPGPASS GnuPG Password Manager

Branch

work/carl/fix-icon-wayland

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

CarlSchwan requested review of this revision.Jan 29 2024, 3:04 PM

CarlSchwan created this revision.

CarlSchwan added a reviewer: svuorela.Jan 29 2024, 3:05 PM

svuorela added inline comments.Jan 29 2024, 3:50 PM

main/main.cpp
55	shouldn't we then also install such an icon somewhere, like into hicolor theme ?

CarlSchwan added inline comments.Jan 29 2024, 3:53 PM

main/main.cpp
55	We already do in CMakeLists.txt See install(FILES artwork/sc-gpgpass.svg DESTINATION ${KDE_INSTALL_FULL_ICONDIR}/hicolor/scalable/apps RENAME org.gnupg.gpgpass.svg)