Page MenuHome GnuPG

Add a '5' to adjust defines
ClosedPublic

Authored by heirecka on Mon, Mar 18, 9:28 PM.

Details

Summary

They were changed from PINENTRY_QT_FOO to PINENTRY_QT5_FOO in
1e79123c389584b8240387914b193be41b823e92.

Test Plan

Built with Qt5, KF5Wayland and X11 were linked again.

Diff Detail

Repository
rP Pinentry
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

heirecka created this revision.
ikloecker added a subscriber: ikloecker.

Grr. That's why I'm only using #if DEFINE01 in Kleopatra so that undefined defines don't go unnoticed. (Update: And I just noticed that this doesn't actually work because, apparently, any undefined identifier is replace by 0 when evaluating conditional expressions.)

This revision is now accepted and ready to land.Mon, Mar 18, 10:31 PM

Let's wait a few days before we do a patch release. The missing CAPS lock indicator isn't mission critical.

@heirecka The changes were applied. Please close this MR. (Unfortunately, only the author can close patches.)