Fix crash in KSelectionModelProxy
ClosedPublic
Actions

Authored by CarlSchwan on Jul 2 2024, 4:25 PM.

Details

Reviewers

Commits

rGPGPASS750db0a3edac: Fix crash in KSelectionModelProxy

Summary

In debug builds, KSelectionModelProxy requires what the given selection
model has as sourceModel the same sourceModel specified in
KSelectionModelProxy constructor.

The Q_ASSERT in KSelectionModelProxy is not completely correct as when
using a QIdentityProxyModel, it will still work.

Test Plan

Run without crashing when KItemModels is build in debug mode

Diff Detail

Repository

rGPGPASS GnuPG Password Manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

CarlSchwan requested review of this revision.Jul 2 2024, 4:25 PM

CarlSchwan created this revision.

CarlSchwan added a reviewer: svuorela.Jul 2 2024, 4:25 PM

svuorela accepted this revision.Jul 3 2024, 10:57 AM

This revision is now accepted and ready to land.Jul 3 2024, 10:57 AM

Closed by commit rGPGPASS750db0a3edac: Fix crash in KSelectionModelProxy (authored by CarlSchwan). · Explain WhyJul 3 2024, 3:12 PM

This revision was automatically updated to reflect the committed changes.

CarlSchwan added a commit: rGPGPASS750db0a3edac: Fix crash in KSelectionModelProxy.

merged

Revision Contents
Changeset List

Path

Size

src/

mainwindow.cpp

2 lines

Diff 1624

View Options

Fix crash in KSelectionModelProxyClosedPublicActions