Paths

Table of Contentst

Differential D617

Allow passing flags to Context::deleteKey
Needs ReviewPublic
Actions

Authored by • TobiasFella on Thu, Nov 13, 12:16 PM.

Tags

None

Subscribers

None

Details

Reviewers

Summary

Required for passing GPGME_DELETE_FORCE from kleopatra

Test Plan

Use with other patches; check that deletion works without pinentries

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

• TobiasFella requested review of this revision.Thu, Nov 13, 12:16 PM

• TobiasFella created this revision.

• TobiasFella planned changes to this revision.Thu, Nov 13, 12:22 PM

• TobiasFella mentioned this in D618: Allow passing flags to DeleteJob.Thu, Nov 13, 12:53 PM

• ikloecker requested changes to this revision.Thu, Nov 13, 1:47 PM

• ikloecker added inline comments.

src/context.h
253	No int flags in new C++ API please. Add a proper enum class for the delete flags.

• TobiasFella updated this revision to Diff 1649.Thu, Nov 13, 3:47 PM

• TobiasFella marked an inline comment as done.

Feel free to commit/push when you have made the suggested changes. One last thing: Update the NEWS file.

src/context.h
252	Looks good, but let's move it to global.h. It doesn't need to be in the Context namespace. And I think we don't need the "Delete" prefix of the enum values because all identifiers are scoped with DeletionFlags. I would use `int` as underlying type since the gpgme API uses `int` for flags.

Revision Contents
Changeset List

Path

Size

src/

13 lines

7 lines

Diff 1649

src/context.h

Loading...

src/context.cpp

Loading...