Page MenuHome GnuPG

(Mostly) fix refreshing list of drafts
Needs ReviewPublic

Authored by tfry on Tue, Dec 16, 6:18 PM.

Details

Reviewers
svuorela
m.eik
Summary

See T7689 . The key idea here is to separate "global" status updates (not specific to a particular email) from the "info-fetched" command (specific to a particular email). This actually even simplifies the protocol a little, resulting in a net removal of a bit of code.

With this patch, removal of drafts is visible, immediately. Addition of drafts still does not show until switching to a different email (but at least it *does* show without having to restart the native client). The reason for not addressing this part of the problem is - again - T7972: We need an email-address as a handle for each message, and this is not available in the DraftManager. It would be possible to hack in that info, but in light of our plan to move away from email as a mapping key, that does not seem to go into the right direction.

I'm omitting the generated .js-code to reduce noise. You need to do npm run build. Patch corresponds to the branch work/tfry/refresh_draft_list.

Test Plan

Plugin needs to be re-registered in the office account after updating the web client files.

  • open plugin, select any email, create a draft of a reply
  • see above, draft becomes visible after switching to a different email, so far
  • remove draft (should be visible, immediately)
  • create some more drafts, restart native client, drafts should continue to show.

Diff Detail

Repository
rOJ GpgOL.js
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

tfry requested review of this revision.Tue, Dec 16, 6:18 PM
tfry created this revision.