Page MenuHome GnuPG
Create Task
Maniphest T1982

pinentry-qt should fallback to curses if $DISPLAY is set but unavailable
Open, LowPublic
Actions

Description

https://bugs.debian.org/635935 reports that pinentry-gtk-2 (and presumably other
graphical pinentries) fail hard if $DISPLAY is set but cannot be opened.

They fall back to curses if $DISPLAY is unset. Maybe they should fallback to
curses if they know they are connected to a TTY *and* $DISPLAY is set but
unreachable?

Below is an example that could have succeeded if this workaround was in place:

0 dkg@alice:~$ DISPLAY=:noexist pinentry-gtk-2

(pinentry-gtk-2:16257): Gtk-WARNING **: cannot open display: :noexist
1 dkg@alice:~$

Event Timeline

dkg added projects: Feature Request, pinentry.May 13 2015, 8:25 PM
dkg added a subscriber: dkg.
neal added a subscriber: neal.May 16 2015, 10:51 PM

Fixed in edd9a88.

neal closed this task as Resolved.May 16 2015, 10:51 PM
neal claimed this task.
dkg added a comment.Jan 5 2016, 6:15 AM

Hm, this is indeed fixed for pinentry-gtk2 and pinentry-gnome3, but pinentry-qt
is still broken:

0 $ DISPLAY=:3 pinentry-qt
QXcbConnection: Could not connect to display :3
Aborted
134 $

dkg reopened this task as Open.Jan 5 2016, 6:15 AM
dkg added a comment.Feb 6 2017, 9:26 AM

anyone skilled in qt want to fix this outstanding issue?

• werner reassigned this task from neal to aheinecke.Feb 13 2017, 4:20 PM
• werner added a subscriber: aheinecke.
• werner added a subscriber: • werner.

Andre, can you look at it?

aheinecke added a comment.Feb 13 2017, 6:01 PM

Testing this I noticed that the curses fallback did not work at all for Qt5
versions of pinentry-qt even if display was unset. This i fixed with cd7b35e

But the DISPLAY=:noexist case is more complicated. The GTK pinentry does a
gtk_init_check which Qt does not have. I don't want to mess with X directly and
would have to look into this more how to do this then only when X is used etc.

There is a similar question on stackoverflow and I don't find any answers there
acceptable:
http://stackoverflow.com/questions/28525435/qt-equivalent-to-gtk-init-check

I've changed the topic to reflect that this is a feature currently not available
in pinentry-qt but I don't see it as a high priority issue.

aheinecke renamed this task from graphical pinentries might try to fallback to curses if $DISPLAY is set but unavailable to pinentry-qt should fallback to curses if $DISPLAY is set but unavailable.Feb 13 2017, 6:01 PM
aheinecke lowered the priority of this task from Normal to Low.Apr 24 2017, 5:55 PM
thesamesam added a subscriber: thesamesam.Sep 1 2023, 5:32 AM