Page MenuHome GnuPG
Create Task
Maniphest T1991

pinentry-w32 needs to adjust button sizes
Closed, WontfixPublic
Actions

Description

When you type in a password that isn't secure enough, this dialog box appears
that tells you so. Problem is, the buttons aren't big enough for the text that
they are trying to display.

There are 2 types of this dialog. One for when the password is too short, and
one for when the password doesn't have enough different types of characters
(numbers, upper and lower case letters, etc). Both of these insecure password
warning dialog boxes have buttons that suffer from the same problem.

Attached to this bug report is a screencap of the dialog box that tells you that
the password is too short.

Event Timeline

Animedude5555 set Version to 2.2.4.May 20 2015, 1:20 AM
Animedude5555 added a subscriber: Animedude5555.

Animedude5555 added projects: gpg4win, Bug Report.May 20 2015, 1:20 AM
• werner added a subscriber: • werner.May 21 2015, 8:50 AM

You are using the very simple native WIndows Pinentry. This is more a debug
tool than a real solution. I guess you installed the vanilla version of gpg4win
which comes without any GUI dialog except for this Pinentry. Please install at
least the light version of the installer.

• werner added a project: Not A Bug.May 21 2015, 8:50 AM
Animedude5555 added a comment.May 22 2015, 6:56 AM

615_unnamed1 KBDownload

Animedude5555 added a comment.May 22 2015, 6:56 AM

Even so, this is a bug. As such, it should be fixed.

On Wed, May 20, 2015 at 11:50 PM, Werner Koch via BTS <
gnupg@bugs.g10code.com> wrote:

Werner Koch <wk@gnupg.org> added the comment:

You are using the very simple native WIndows Pinentry. This is more a
debug
tool than a real solution. I guess you installed the vanilla version of
gpg4win
which comes without any GUI dialog except for this Pinentry. Please
install at
least the light version of the installer.

status: unread -> chatting
topic: +nobug

GnuPG's BTS <gnupg@bugs.g10code.com>
<T1991>

• werner added a comment.May 22 2015, 9:48 AM

This requires native Windows code to resize a button in a dialog. This is to
much work for something which is basically a debug tool. I have called several
years for help on building a good native Windows tool (without MFC and such) to
no avail.

Feel free to send a working patch to gnupg-devel@

• werner closed this task as Resolved.May 22 2015, 9:48 AM
• werner claimed this task.
• werner added a project: Won't Fix.
Animedude5555 added a comment.May 22 2015, 11:04 AM

As far as I know, GPG4Win is a compiling/linking of GPG to be Windows
compatible, which means that the code was already altered to work with
Windows. Therefore native Windows code is already in use in the GPG4Win
variant of GPG. Therefore it should work correctly in every respect in
Windows (including correctly sized buttons).

On Fri, May 22, 2015 at 12:48 AM, Werner Koch via BTS <
gnupg@bugs.g10code.com> wrote:

Werner Koch <wk@gnupg.org> added the comment:

This requires native Windows code to resize a button in a dialog. This is
to
much work for something which is basically a debug tool. I have called
several
years for help on building a good native Windows tool (without MFC and
such) to
no avail.

Feel free to send a working patch to gnupg-devel@

status: chatting -> resolved
topic: +wontfix

GnuPG's BTS <gnupg@bugs.g10code.com>
<T1991>

Animedude5555 reopened this task as Open.May 22 2015, 11:04 AM

616_unnamed1 KBDownload

Animedude5555 added a comment.May 22 2015, 11:29 AM

618_pinentry.piz38 KBDownload

Animedude5555 added a comment.May 22 2015, 11:29 AM

Well, here's my fix. Using this neat little program I downloaded called
Resource Hacker, I edited the buttons on the dialog box so that they would
be big enough to display the messages needed. Realizing that pinentry.exe
and pinentry-w32.exe were identical files (checking them in a hex editor
with file comparison function showed them to be exactly the same), I just
copied my edited version of pinentry.exe and renamed the copy as
pinentry-w32.exe. I have put both of them in a zip file called
pinentry.zip, and have attached this zip file to this email. Feel free to
distribute this on the official GPG4Win website. Note that the file name of
the attachment is "piz" not "zip", so before you extract its contents (for
use, or posting on your website) you will need to rename it from "piz" back
to "zip". I had to rename it from "zip" to "piz" because otherwise Gmail's
mail server scans inside the zip file and then for blocks it because it
detects exe files (and exe files are a format that can potentially harbor
malware). Even though this has no malware (as you can see by scanning it
with a virus scanner), Google's mail server takes extra precautions by
refusing to allow sending of executable files or even archive files that
contain executable files.

On Fri, May 22, 2015 at 12:48 AM, Werner Koch via BTS <
gnupg@bugs.g10code.com> wrote:

Werner Koch <wk@gnupg.org> added the comment:

This requires native Windows code to resize a button in a dialog. This is
to
much work for something which is basically a debug tool. I have called
several
years for help on building a good native Windows tool (without MFC and
such) to
no avail.

Feel free to send a working patch to gnupg-devel@

status: chatting -> resolved
topic: +wontfix

GnuPG's BTS <gnupg@bugs.g10code.com>
<T1991>

Animedude5555 added a comment.May 22 2015, 11:29 AM

617_unnamed2 KBDownload

• werner renamed this task from Password insecure warning dialog has buttons too small for text to pinentry-w32 needs to adjust button sizes.May 22 2015, 3:01 PM
• werner removed projects: Bug Report, gpg4win.
• werner added projects: Feature Request, pinentry.

Oh well, resizing the buttons to a new fixed size would be a job in the source
of 10 minutes or so. However, this makes an very ugly Pinentry for every day's
use (i.e. entering a passphrase for an existing key). So, sorry, I won't take
that patch.

With native Windows code I mean native Windows code for GUIs instead of relying
on MFC or whatever is the latest GUI framework MS uses. This is similar to xlib
programm vs. GTK+ programming

Anyway, thanks for looking into this. I will retitle the bug to keep it open.
Maybe eventually someone starts to hack on it.

• werner removed Version.May 22 2015, 3:01 PM
marcus closed this task as Wontfix.Jun 22 2017, 5:07 PM
marcus added a subscriber: marcus.

Nobody started to hack on it in two years, and buried in this bug report nobody will find it. If this is still a desirable task, a new ticket should be opened.