Here's the patch

D336: 697_0001-Keep-a-reference-to-the-pin-when-converting-it-from-.patch

D335: 698_0001-Keep-a-reference-to-the-pin-when-converting-it-from-.patch

ah, it seems there is a slightly different coding style. adjusted.

Uh that's an embarassing error.

Thanks for your analysis and fix. I haven't seen problems with this in my tests
but the UTF8 Byte array is indeed temporary and the pin pointer is invalid after
it's destruction.

I've commited the your fix (with an ammended commit message so it confirms to
the msg style used in pinentry) with f143d21

Werner I've assigned it to you as this needs a release :/ Sorry.

Werner, I know that nothing much in pinentry has changed since 0.9.6 but this
bug is pretty bad for pinentry-qt. It would be good to have a new release.