Page MenuHome GnuPG
Create Task
Maniphest T2910

gpgme 1.8 build failure: strdup undeclared on MacOSX Sierra
Closed, ResolvedPublic
Actions

Description

Copying this issue from the ML so it doesn't get lost.

Build environment: macOS Sierra, XCode 8.1.

quorra:gpgme-1.8.0 rjh$ make
/Applications/Xcode.app/Contents/Developer/usr/bin/make all-recursive
Making all in src
make[2]: Nothing to be done for `all'.
Making all in tests
Making all in gpg
make[3]: Nothing to be done for `all'.
Making all in gpgsm
make[3]: Nothing to be done for `all'.
Making all in opassuan
make[3]: Nothing to be done for `all'.
make[3]: Nothing to be done for `all-am'.
Making all in doc
/Applications/Xcode.app/Contents/Developer/usr/bin/make all-am
make[3]: Nothing to be done for `all-am'.
Making all in lang
Making all in cl
make[3]: Nothing to be done for `all'.
Making all in cpp
Making all in src
/bin/sh ../../../libtool --tag=CXX --mode=compile g++ -std=c++11
-DHAVE_CONFIG_H -I. -I../../.. -I../../../src -I/usr/local/include
-I/usr/local/include -DBUILDING_GPGMEPP -g -O2 -MT
keygenerationresult.lo -MD -MP -MF .deps/keygenerationresult.Tpo -c -o
keygenerationresult.lo keygenerationresult.cpp
libtool: compile: g++ -std=c++11 -DHAVE_CONFIG_H -I. -I../../..
-I../../../src -I/usr/local/include -I/usr/local/include
-DBUILDING_GPGMEPP -g -O2 -MT keygenerationresult.lo -MD -MP -MF
.deps/keygenerationresult.Tpo -c keygenerationresult.cpp -fno-common
-DPIC -o .libs/keygenerationresult.o
keygenerationresult.cpp:43:23: error: use of undeclared identifier 'strdup'

res.fpr = strdup(res.fpr);
          ^

1 error generated.

Details

Version
1.8.0

Revisions and Commits

rT Not Too Bad TLS
rTe582e91e47a1 build: Use macOS' compatibility macros to enable all features.

Related Objects

Event Timeline

neal added projects: Bug Report, gpgme.Jan 6 2017, 3:01 PM
neal set Version to 1.8.0.
neal added subscribers: neal, rjh.
• werner added a subscriber: • werner.Jan 6 2017, 7:09 PM

We don't see that on our Sierra box.

• werner added a project: MacOS.Jan 6 2017, 7:09 PM
justus added a subscriber: justus.Jan 16 2017, 11:10 AM

We configure the build with -D_DARWIN_C_SOURCE=900000L on our macOs box. Not
sure if this is the proper thing to do, and/or if we should just always set that
when we build on Darwin in configure.

• werner added a comment.Jan 17 2017, 11:02 AM

FWIW: In GnuPG we have for example this in the configure script

*-*-hpux*)
    if test -z "$GCC" ; then
        CFLAGS="-Ae -D_HPUX_SOURCE $CFLAGS"
    fi

IF it makes things easier we may add a simlar case for macOS. But we need to do
this for many packages, I think.

justus claimed this task.Feb 13 2017, 10:33 AM
justus added a project: In Progress.Mar 1 2017, 4:53 PM

I addressed this for GPGME in 60273e8b2c11d42215a5707bc55e3e0d8f350e07 but
apparently forgot to mention that here.

I'll keep the bug open until I fixed this in all packages.

justus mentioned this in T2447: macport compile failed in libassuan-2.4.3 due to undefine _POSIX_C_SOURCE.Mar 30 2017, 7:19 PM
justus added a comment.Mar 8 2017, 11:45 AM

libgpg-error fixed in 5e51b642f747547c737a7abbc37e65b0f630d188.

justus added a comment.Mar 8 2017, 12:30 PM

libassuan fixed in b26b73d04bff10852382113ae361ea5726661510.

justus added a comment.Mar 8 2017, 1:05 PM

libksba fixed in 561d03a008150c201ece22b29c97b24a1f6bf590.

justus added a comment.Mar 8 2017, 1:11 PM

libgcrypt fixed in 654024081cfa103c87bb163b117ea3568171d408.

justus added a comment.Mar 8 2017, 1:21 PM

ntbtls fixed in e582e91e47a164816ac074b9078dbed8537601dc.

justus removed a project: In Progress.Mar 8 2017, 1:33 PM

gnupg fixed in dd60e868d2bf649a33dc96e207ffd3b8ae4d35af.

justus closed this task as Resolved.Mar 8 2017, 1:33 PM
justus added a commit: rTe582e91e47a1: build: Use macOS' compatibility macros to enable all features..Apr 25 2017, 3:35 AM
• werner mentioned this in T4943: Release LibKSBA 1.4.0.May 19 2020, 3:41 PM
• gniibe mentioned this in T5440: _DARWIN_C_SOURCE kind of "must" be 1, not "900000L".May 21 2021, 7:04 AM