struct ucred usage needs ucred.h on Solaris
Closed, ResolvedPublic

Description

get_client_pid() uses struct ucred when HAVE_SO_PEERCRED is defined. This
struct definition is defined in ucred.h on Solaris. Attached patch includes
this header when ucred.h was found on the system.

Details

Version
2.1.19
werner added a subscriber: werner.Mar 2 2017, 4:58 PM

We should better fix that by adding a new API to libassuan so that we have that
code only once.

Thanks for the report.

gniibe claimed this task.Mar 6 2017, 12:47 PM
gniibe added a subscriber: gniibe.
gniibe added a comment.Mar 7 2017, 6:25 AM

Since this is for command-ssh.c, we can't change the protocol (the client is SSH
process, which doesn't use libassuan).
Here, the purpose of the code is getting PID of peer, so, we can do something
except FreeBSD.

I think that it is fixed in: f7f806afa5083617f4aba02fc3b285b06a7d73d4

gniibe closed this task as Resolved.Apr 4 2017, 2:21 AM

Fix published in 2.1.20.