Page MenuHome GnuPG
Create Task
Maniphest T3165

Cannot run make check without having the gnupg2 already installed in the tree
Closed, ResolvedPublic
Actions

Description

The tests call scdaemon from /usr/libexec/scdaemon and there is no way how to override it. Similarly for gpg-agent being run from /usr/bin/gpg-agent.

Revisions and Commits

rG GnuPG
rG0e1729bb9936 tests: Fix agent teardown in release builds.
rGa8dd96826f84 g10: Suppress error for card availability check.
rG386a7bbb245d tests: Configure the environments to use scdaemon from build tree.

Related Objects

Event Timeline

t8m created this task.May 16 2017, 1:05 PM
t8m created this object in space S1 Public.
justus claimed this task.May 16 2017, 2:26 PM
justus added a subscriber: justus.

Can you elaborate that?

Where is scdaemon called? (Sadly we do not have a test that explicitly exercises scdaemon...)
Where is gpg-agent from /usr/bin called?

I spent quite a bit of time making sure that the tests do use the artifacts from the built tree. Which version are you using btw?

t8m added a comment.May 16 2017, 3:08 PM

It is recent regression in 2.1.21 - probably in 2.1.20 scdaemon was not run at all.

From https://kojipkgs.fedoraproject.org//packages/gnupg2/2.1.21/1.fc27/data/logs/x86_64/build.log it looks like the scdaemon is being run from the tests.scm which is called from multiple tests.

justus added a comment.May 16 2017, 3:13 PM

Interesting. What about gpg-agent? I don't see problems in the log you mentioned.

t8m added a comment.May 16 2017, 3:39 PM

Sorry for misleading you, gpg-agent seems to be called properly from the build tree.

justus added a commit: rG386a7bbb245d: tests: Configure the environments to use scdaemon from build tree..May 16 2017, 4:23 PM
justus added a subscriber: • gniibe.May 16 2017, 4:24 PM

I just commited 386a7bbb245dd3ab7c4156a554adbe75d82bdf49, that should fix your troubles with the test suite in the short term.

I'm somewhat afraid that we might have broken gpg setups where scdaemon is not installed. Niibe, can you please look into that?

t8m added a comment.May 16 2017, 4:53 PM

Good to know that - I'll include scdaemon in the base gnupg2 package.

• gniibe added a comment.May 17 2017, 1:45 AM

Err... it's my badness. rG97a2394ecafa: g10: For signing, prefer available card key when no -u option. introduced this bug. It checks if a key on card is available by agent_scd_serialno.
Call to start_agent with FOR_CARD=1 may cause an error if there is no scdaemon installed.
I need to fix skipping such errors.

• gniibe added a commit: rGa8dd96826f84: g10: Suppress error for card availability check..May 17 2017, 2:53 AM
• gniibe added a comment.May 17 2017, 6:44 AM

BTW, in the test suite, gpgconf is invoked to kill gpg-agent/scdaemon/dirmngr. But it uses say, /usr/bin/gpg-connect-agent, which might be not yet installed.
I found such errors in Debian build: https://buildd.debian.org/status/fetch.php?pkg=gnupg2&arch=arm64&ver=2.1.21-1&stamp=1494993589&raw=0

justus added a commit: rG0e1729bb9936: tests: Fix agent teardown in release builds..May 17 2017, 12:19 PM
justus added a comment.May 17 2017, 12:19 PM

Niibe, good catch. Hopefully addressed in 0e1729bb993648deca84a2664ae78edc848d7003.

justus closed this task as Resolved.May 18 2017, 10:04 AM