Page MenuHome GnuPG
Create Task
Maniphest T3821

GpgOL: Ignore empty lines in PGP Inline messages
Closed, ResolvedPublic
Actions

Description

I received a debug log that contained a message which could resulted in a "No Data "error in GpgOL. The message contained multiple newlines in the plain body part for each newline.
Our parser could filter out empty lines in a PGP MESSAGE to be more robust and accept such broken input.

-----BEGIN PGP MESSAGE-----



Version: Encryption Desktop 10.4.1 (Build 759)



Comment: ....



Charset: utf-8



 



qANQR1DBwEwDZMPLBT0DLRsBB/9i99aMZFfWTruWRWhzcY39+Oz0Ey2LJ6B8ukMh



cLFO9/FJSm3+x8ymUNO1/9qCd7HODtK5tMxafQnOaVgjrY8rbTFlwSIqGPK46NAU



pHFEwL5cs1geeUaRTHatAhu4/uELbhm/rNYwdJJxBgQYf4fLrr1/wniU453w7nRY

Details

Version
master

Revisions and Commits

rO GpgOL
rO149a0928250a Be more lenient with broken PGP Inline messages

Related Objects
Search...

Event Timeline

• aheinecke created this task.Mar 2 2018, 3:35 PM
• aheinecke added a commit: rO149a0928250a: Be more lenient with broken PGP Inline messages.Mar 6 2018, 11:59 AM
• aheinecke added a parent task: T3742: Gpg4win 3.1.0.Mar 7 2018, 2:09 PM
• aheinecke closed this task as Resolved.Mar 8 2018, 8:41 AM

As this is easy to test and I tested it myself I think I can mark it as resolved.

For Perfomance reasons the fixup is only done on messages that are smaller then < 100k as we can't really determine in the parser if we are looking at a PGP/MIME Message or a PGP/Inline message and the fixup has a bit overhead.