Page MenuHome GnuPG
Create Task
Maniphest T3877

not all malloc performed in libgcrypt covered by gcry_set_allocation_handler
Closed, ResolvedPublic
Actions

Description

libgcrypt allows to provide our own malloc implementation. Howver I have identified at least three direct call of malloc instead of do_malloc (global.c)
hmac256.c -> _gcry_hmac256_file
hmac256.c -> _gcry_hmac256_new

secmem.c -> init_pool

Details

Version
1.8.2

Revisions and Commits

rC libgcrypt
rC06fdc074eb29 hmac: Use xtrymalloc.
rC3e3b520fb32a hmac: Use xtrymalloc.

Event Timeline

JFi created this task.Apr 4 2018, 1:44 PM
• werner triaged this task as Normal priority.Apr 5 2018, 2:48 PM
• werner added a subscriber: • werner.

For secmem.c this is on purpose. For the others we should fix that.

• gniibe added a subscriber: • gniibe.Apr 10 2018, 7:09 AM

Note:
When we change the allocation, hmac256.c will not be standalone any more (as commented in the head of the file), and we will need to change the compile-command line to include libgpg-error.

Or... do we keep allocation by malloc with STANDALONE-ifdef?

• gniibe claimed this task.Apr 11 2018, 1:16 AM
• gniibe added a commit: rC3e3b520fb32a: hmac: Use xtrymalloc..Apr 11 2018, 1:52 AM
• gniibe changed the task status from Open to Testing.Apr 11 2018, 1:52 AM
• gniibe closed this task as Resolved.Sep 11 2018, 1:34 PM
• werner added a commit: rC06fdc074eb29: hmac: Use xtrymalloc..Jun 3 2021, 7:09 PM