Page MenuHome GnuPG
Create Task
Maniphest T4002

gpg-error.h uses c11 reserved word "noreturn"
Closed, ResolvedPublic
Actions

Description

<gpg-error.h> needs to use __noreturn__ instead of noreturn to avoid incompatibilities with C11, and specifically <stdnoreturn.h>. see https://github.com/systemd/systemd/pull/8456

I will attach a patch

Details

External Link
https://github.com/systemd/systemd/pull/8456
Version
HEAD

Revisions and Commits

rE libgpg-error
rE3eee9efc46f9 core: Fix problem with C11 and stdnoreturn.h.

Event Timeline

slandden created this task.May 29 2018, 6:34 PM
slandden updated the task description. (Show Details)
werner triaged this task as High priority.May 30 2018, 8:40 AM
werner added a subscriber: werner.

Oh dear, adding new keywords which have not been reserved in the past was a bad idea by C11. This will eventually require fixes at lot of places because the noreturn attribute is widely used ( other common headers may include the noreturn header as well).

Anyway, for libgpg-error it will be easy to do.

werner changed the task status from Open to Testing.May 30 2018, 5:22 PM

Do you have a need for doing a new release immediately?

werner added a commit: rE3eee9efc46f9: core: Fix problem with C11 and stdnoreturn.h..May 30 2018, 5:24 PM
werner closed this task as Resolved.Jun 6 2018, 6:46 PM
werner claimed this task.