Page MenuHome GnuPG
Create Task
Maniphest T4228

Leaked FILE from tmpfile() in dns.c dns_trace_open
Closed, ResolvedPublic
Actions

Description

The FILE from tmpfile() is not used for anything and just leaked here:
https://dev.gnupg.org/source/gnupg/browse/master/dirmngr/dns.c;0240345728a84d8f235ce05889e83963e52742eb$4507

Should it be assigned to trace->fp ?

Revisions and Commits

rG GnuPG
rGe00e68135c01 dns: Fix irrelevant use of tmpfile.

Event Timeline

t8m created this task.Oct 25 2018, 2:29 PM
t8m created this object in space S1 Public.
• werner triaged this task as Low priority.Oct 25 2018, 5:06 PM
• werner added a project: dns.
• werner added a subscriber: • werner.

It seems that this part of the code was not finished. Unfortunately upstream of the dns code is unresponsive and thus we started to maintain the code base by ourselves. There is still an open question whether we should do that to the full extend, in which case we would integrate the code closer into the GnuPG framework with its own logging subsystems.

Thus for now, I won't fix this.

• gniibe added a subscriber: • gniibe.Aug 22 2019, 5:54 AM

This part of code is questionable. It always comes fp!=NULL, so the part should be removed.
If fp==NULL, use of tmpfile is quite questionable because a user can't know where the trace output goes.
I'm going to remove that part.

• gniibe closed this task as Resolved.Aug 22 2019, 5:55 AM
• gniibe claimed this task.

Fixed in master.

• gniibe added a commit: rGe00e68135c01: dns: Fix irrelevant use of tmpfile..Aug 22 2019, 5:55 AM