python gpg.Context.decrypt(verify=False) no longer works
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dkg
	Nov 27 2018, 10:10 PM

Description

in 11403a46358f9b6e98776974f3c70f211d9adf85, the python gpg bindings appear to have radically changed the semantics of the verify= argument to the gpg.Context.decrypt() function.

In particular:

+            if verify is not None:
+                if isinstance(verify, bool) is True:
+                    if verify is False:
+                        verify = True
+                        sink_result = True
+                    else:
+                        pass

This appears to change verify from False to True, which means that if there is no signature, an error will be raised anyway.

See https://bugs.debian.org/911568 as one example of a problem introduced by this change:

  File "/usr/lib/python3/dist-packages/impass/db.py", line 112, in _decryptDB
    data, _, _ = self._gpg.decrypt(try2, verify=False)
  File "/usr/lib/python3/dist-packages/gpg/core.py", line 431, in decrypt
    for s in verify_result.signatures):
AttributeError: 'NoneType' object has no attribute 'signatures'

Details

Version: 1.12.0

Revisions and Commits

rM GPGME
	rM65c28da4e49a python: overhaul logic of Context.decrypt()
	rMac8d7238dbf1 python: overhaul logic of Context.decrypt()

Related Objects

Mentioned In: rM7c63bfe4ab43: python: docs updates
Mentioned Here: rMac8d7238dbf1: python: overhaul logic of Context.decrypt()
rM11403a46358f: python bindings: ctx.decrypt

Event Timeline

dkg created this task.Nov 27 2018, 10:10 PM

please add a unit to the test suite to make sure something like this doesn't happen in the future!

i believe i heard from some alot users that they were seeing crashes on encrypted but unsigned messages as well, though i don't have a pointer (they're using python-gpg too)

Regression introduced with 1.12.0.

I've just pushed a branch dkg/fix-T4271 , currently at ac8d7238dbf165950c9844e5cb41da8eb4d37bc0 that resolves this problem.

dkg added a commit: rMac8d7238dbf1: python: overhaul logic of Context.decrypt().Dec 5 2018, 12:51 AM

note that the branch also updates the test suite to make sure the verify=False case is tested.

Needs to be merged. (Note that Phabricator does not show the branch in the tooltip for commit ids.)

Ben is not even subscribed to this issue.
With the volatility of gpgme-python I think that this can easily be merged. I did a quick review and it looked good to me.

@BenM do you object?

• aheinecke added a commit: rM65c28da4e49a: python: overhaul logic of Context.decrypt().Dec 5 2018, 11:50 AM

since @aheinecke merged my changes, i think this bug is now resolved. I'll let @BenM close it though :)

Ooh, nice catch @dkg, I just stepped through each of your changes and it all looks good. I'll tweak the relevant sections of the HOWTO dealing with this in the next few days (I need to replace a keyboard here before properly diving back in) and then close this case once done.

Confirmed that this is indeed fixed and made the (rather minor) change to the HOWTO that was needed. No changes were needed for the example script (decrypt-file.py).

BenM mentioned this in rM7c63bfe4ab43: python: docs updates.Dec 10 2018, 6:12 AM