Maniphest T4698

Results from clang analyzer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	stm
	Sep 7 2019, 6:10 PM

Tags

Subscribers

Description

Here are some results from clang's static analyzer. Maybe they are worth to have a look:

Bug Group	Bug Type	File	Function/Method	Line	Path Length
API	Argument with 'nonnull' attribute passed null	src/sysutils.c	_gpgrt_setenv	183	8
Dead store	Dead assignment	src/estream-printf.c	pr_string	1207	1
Logic error	Dereference of null pointer	src/argparse.c	initialize	213	6
Logic error	Dereference of null pointer	src/logging.c	fun_writer	273	12
Logic error	Dereference of null pointer	src/estream.c	do_list_remove	466	29
Memory error	Memory leak	tests/t-b64.c	test_b64dec_string	162	12

Details

Version: GIT HEAD

Revisions and Commits

rE libgpg-error
	rE46bb7eb8c554 tests: Fix deallocation of buffer in t-b64.c.
	rE4b8e8ba9f60c gpgrt_setenv: Define behavior when value=NULL.
	rE521aeecf1e41 logging: Fix the case of using socket_dir_cb which may return NULL.
	rEf41991480aaa estream: Care about erroneous case for stream close.
	rEf7c244273290 estream: Fix dead assigniment.

Related Objects

Mentioned In: T4772: Release libgpg-error 1.37

Event Timeline

stm created this task.Sep 7 2019, 6:10 PM

Oh, this report is about libgpg-error.

• werner triaged this task as Normal priority.Sep 8 2019, 7:38 PM

• werner added a project: gpgrt.

• werner added a commit: rEf7c244273290: estream: Fix dead assigniment..Sep 8 2019, 7:59 PM

@stm -- thank you for this!

I take this so that libgpg-error can be released soon.

• gniibe added a commit: rEf41991480aaa: estream: Care about erroneous case for stream close..Sep 18 2019, 10:48 AM

• gniibe added a commit: rE521aeecf1e41: logging: Fix the case of using socket_dir_cb which may return NULL..

• gniibe added a commit: rE4b8e8ba9f60c: gpgrt_setenv: Define behavior when value=NULL..

• gniibe added a commit: rE46bb7eb8c554: tests: Fix deallocation of buffer in t-b64.c..

For argparse.c, it can be only stopped with nonnull attribute for the API, I suppose.

• gniibe closed this task as Resolved.Dec 6 2019, 5:11 AM

• werner mentioned this in T4772: Release libgpg-error 1.37.Feb 7 2020, 1:47 PM