Page MenuHome GnuPG
Create Task
Maniphest T4758

gnupg-2.2.18/dirmngr/ldap-parse-uri.c:57:27: style: Same expression on both sides of '||'.
Closed, ResolvedPublic
Actions

Description

Source code is

|| ((url[4] == 's' || url[4] == 'S'
     || url[4] == 'i' || url[4] == 'i')

Maybe better code:

|| ((url[4] == 's' || url[4] == 'S'
     || url[4] == 'i' || url[4] == 'I')

Revisions and Commits

rG GnuPG
rG0795ab1c8f95 dirmngr: Fix case handling of "ldapi" scheme.

Event Timeline

dcb created this task.Nov 26 2019, 10:54 AM
• werner triaged this task as Normal priority.Nov 26 2019, 11:17 AM
• werner added projects: dirmngr, LDAP.
• werner added subscribers: neal, • werner.

The LDAP code is actually in very bad shape because @neal added it without utilizing the ldap wrapper and thus a timeout won't work reliable.

• werner added a commit: rG0795ab1c8f95: dirmngr: Fix case handling of "ldapi" scheme..Jul 2 2020, 4:07 PM
• werner closed this task as Resolved.Jul 2 2020, 4:10 PM
• werner claimed this task.

Fixed; In master the code already uses our generic scheme parser.