gnupg-2.2.18/dirmngr/ldap-parse-uri.c:57:27: style: Same expression on both sides of '||'.
Closed, ResolvedPublic

Description

Source code is

|| ((url[4] == 's' || url[4] == 'S'
     || url[4] == 'i' || url[4] == 'i')

Maybe better code:

|| ((url[4] == 's' || url[4] == 'S'
     || url[4] == 'i' || url[4] == 'I')
dcb created this task.Nov 26 2019, 10:54 AM
werner triaged this task as Normal priority.
werner added subscribers: neal, werner.

The LDAP code is actually in very bad shape because @neal added it without utilizing the ldap wrapper and thus a timeout won't work reliable.

werner closed this task as Resolved.Jul 2 2020, 4:10 PM
werner claimed this task.

Fixed; In master the code already uses our generic scheme parser.