Gpg4win problems for Windows Users with some non-ASCII account names
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bernhard
	Oct 6 2020, 3:02 PM

Description

As reported in
https://wald.intevation.org/forum/forum.php?thread_id=2243&forum_id=84&group_id=11
a pubkey could not be imported and a new keypair could not be created with Gpg4win 3.1.13
it worked with 3.1.10 before.

The problem is a non-ASCII character in the user name of the windows account.

How to reproduce:

Install Gpg4win (as User with Administration Rights)
Add another account with an Umlaut,e.g. "Maus Münster" or "Östern" (Short way on Windows 10: Settings/Einstellungen -> Kontos -> Family and other Accounts -> weiteren Nutzer. Kenne Ameldedaten nicht -> lokales Konto)
Login as other user, try e.g. gpg -v --quick-gen-key irgendwas after the acceptance of passphrase the error message is Schlüsselerzeugung fehlgeschlagen: No such such file or directory.

[Please note that although this is a regression in GnuPG 2.2.23 the actual problem existed for much longer and made it impossible to use Unicode account names or other file names under Windows unless the name could be represented by the current one-byte code page.]

Details

External Link: https://wald.intevation.org/forum/forum.php?thread_id=2243&forum_id=84&group_id=11
Version: 2.2.23

Revisions and Commits

rG GnuPG
	rG163e4ff19597 w32: Support Unicode also for config files etc.
	rG9188a3c6b7eb w32: Support utf8 for getcwd even if build with gpgrt < 1.40.
	rG5f8123df7856 common: New functions gnupg_opendir et al.
	rG4252cd7b18b4 w32: Make gnupg_remove and gnupg_rename_file Unicode aware
	rG157030271f2d Replace all calls to stat by gnupg_stat.
	rG86e52e3c3384 Replace most calls to open by a new wrapper.
	rGd65ea29683ee w32: Allow Unicode filenames for dotlock
	rG5c6e9b44cc9e Replace most of the remaining stdio calls by estream calls.
	rGdd5fd4a760b8 Replace all calls to access by gnupg_access
	rG7e22e08e2ab0 common: New functions gnupg_opendir et al.
	rG9a0197b6fe41 w32: Make gnupg_remove and gnupg_rename_file Unicode aware
	rG18e5dd7b03ce Replace all calls to stat by gnupg_stat.
	rG4dcef0e17836 Replace most calls to open by a new wrapper.
	rGb47c355b18d9 w32: Allow Unicode filenames for dotlock
	rG390497ea115e Replace most of the remaining stdio calls by estream calls.
	rGc94ee1386e0d Replace all calls to access by gnupg_access
rC libgcrypt
	rC6b79963f3f09 random: Allow for a Unicode random seed file on Windows.
	rC24341f58f0d3 random: Allow for a Unicode random seed file on Windows.
rA Assuan
	rA397316e9d0fb Support Unicode socket file names under Windows.
rE libgpg-error
	rE4764c5a3a4d7 New public function gpgrt_access.

Related Objects

Mentioned In: T4294: Release Libgcrypt 1.9.0
T5191: Release libgpg-error 1.40
T5052: Release GnuPG 2.2.24
T5045: Release GnuPG 2.2.23
T5113: Release Libgcrypt 1.8.7
T5106: Agent fails to access private keys from path containing non-ascii characters on Windows
Mentioned Here: T4083: gpgtar, Kleopatra: Unicode filenames that are not native 8 bit on Windows don't work

Event Timeline

bernhard created this task.Oct 6 2020, 3:02 PM

bernhard added projects: Windows, gnupg.

Observation:
The umlaut is displayed incorrectly on the command line (cmd.app) when the keybox file is created.
(This may or may not be relevant.)

I can reproduce this.

bernhard updated the task description. (Show Details)Oct 6 2020, 3:13 PM

We understand the problem, it's a regression from August. For T4083 we changed an internal function to better work with Windows UTF-16 filenames in preperation to at some point fully support UTF-16 and only use the wide character functions as system calls.
But that broke places where internally the local 8 bit encoding was still used.

Will be fixed for the next release.

• werner edited projects, added gnupg (gpg22); removed gnupg.Oct 6 2020, 9:30 PM

Thanks for the quick analysis.

Out of curiosity, if it is easy to answer:
Where would an automatically running test need to be added to find a regression like this?
(Just asking, because I've just thought about what it would take if I would add such a test and wondered if the infrastructure is already in place or if this is a kind of defect that is hard to test easily, because of the involvement of gpg-agent and possibly pinentry (at least in the test that reproduced it first)).

• werner mentioned this in T5106: Agent fails to access private keys from path containing non-ascii characters on Windows.Oct 19 2020, 1:24 PM

• werner merged a task: T5106: Agent fails to access private keys from path containing non-ascii characters on Windows.

• werner added subscribers: jibsen, • werner.

• werner added a commit: rE4764c5a3a4d7: New public function gpgrt_access..Oct 19 2020, 3:49 PM

• werner added a commit: rGc94ee1386e0d: Replace all calls to access by gnupg_access.Oct 20 2020, 12:52 PM

• werner added a commit: rG390497ea115e: Replace most of the remaining stdio calls by estream calls..

• werner added a commit: rGb47c355b18d9: w32: Allow Unicode filenames for dotlock.Oct 20 2020, 2:26 PM

• werner added a commit: rG4dcef0e17836: Replace most calls to open by a new wrapper..

• werner added a commit: rA397316e9d0fb: Support Unicode socket file names under Windows..Oct 20 2020, 11:22 PM

All right, using the current master a Windows user with a Unicode name (e.g. Ⓐlfred E. Neumann) is now able to use gpg properly. Quite a lot of changes were required and backported to 2.2 will also be some work. More testing is of course required. Note that libassuan needs to be taken from Git until we have done a new release.

• werner added a commit: rG18e5dd7b03ce: Replace all calls to stat by gnupg_stat..Oct 21 2020, 5:09 PM

• werner added a commit: rG9a0197b6fe41: w32: Make gnupg_remove and gnupg_rename_file Unicode aware.

• werner added a commit: rG7e22e08e2ab0: common: New functions gnupg_opendir et al..

• werner added a commit: rGdd5fd4a760b8: Replace all calls to access by gnupg_access.Oct 21 2020, 9:13 PM

• werner added a commit: rG5c6e9b44cc9e: Replace most of the remaining stdio calls by estream calls..

• werner added a commit: rGd65ea29683ee: w32: Allow Unicode filenames for dotlock.

• werner added a commit: rG86e52e3c3384: Replace most calls to open by a new wrapper..Oct 23 2020, 11:30 AM

• werner added a commit: rG157030271f2d: Replace all calls to stat by gnupg_stat..

• werner added a commit: rG4252cd7b18b4: w32: Make gnupg_remove and gnupg_rename_file Unicode aware.

• werner added a commit: rG5f8123df7856: common: New functions gnupg_opendir et al..

• werner updated the task description. (Show Details)Oct 23 2020, 1:39 PM

• werner removed a project: gpg4win.

• werner changed Version from 3.1.13 to 2.2.23.

Backported to 2.2. Note that an updated libgcrypt is also required (for 2.2 and master)

• werner added a commit: rC24341f58f0d3: random: Allow for a Unicode random seed file on Windows..Oct 23 2020, 3:37 PM

• werner mentioned this in T5113: Release Libgcrypt 1.8.7.Oct 23 2020, 7:30 PM

0x5c added a subscriber: 0x5c.Oct 26 2020, 9:25 PM

• werner mentioned this in T5045: Release GnuPG 2.2.23.Oct 28 2020, 10:19 AM

• werner merged a task: T5087: Not possible to create a new key.Oct 28 2020, 10:21 AM

• werner added subscribers: FJKoenig, r0347192.

• werner added a commit: rG9188a3c6b7eb: w32: Support utf8 for getcwd even if build with gpgrt < 1.40..Nov 10 2020, 12:09 PM

• werner added a commit: rG163e4ff19597: w32: Support Unicode also for config files etc..

• werner mentioned this in T5052: Release GnuPG 2.2.24.Nov 17 2020, 9:33 AM

• werner closed this task as Resolved.Nov 17 2020, 11:31 AM

Thanks Werner! Seems like an important step!

It was a bunch or work and we are still not able to pass Unicode strings on the command line. Will eventually be done. At least people in Asia can now use their regular Windows account with gpg.

• werner mentioned this in T5191: Release libgpg-error 1.40.Dec 21 2020, 6:30 PM

• werner mentioned this in T4294: Release Libgcrypt 1.9.0.Jan 19 2021, 10:17 AM

• werner added a commit: rC6b79963f3f09: random: Allow for a Unicode random seed file on Windows..Jun 3 2021, 7:08 PM