Page MenuHome GnuPG
Create Task
Maniphest T5262

pinentry qt4 fails to compile in pinentry 1.1.1
Closed, ResolvedPublic
Actions

Description

According to configure.ac it should be still possible to compile pinentry against qt4 however it seems to fail after changes made in 1.1.1:

../.././qt/main.cpp:40:10: fatal error: QWindow: No such file or directory
   40 | #include <QWindow>
../.././qt/pinentrydialog.cpp:230:6: error: cannot convert 'PinEntryDialog::PinEntryDialog(QWidget*, const char*, int, bool, bool, const QString&, const QString&, const QString&)::<lambda()>' to 'const char*'

Could you please confirm whether Qt4 is still supported?

Details

Version
1.1.1

Related Objects

Event Timeline

jpalus created this task.Jan 22 2021, 9:10 PM
gouttegd claimed this task.Jan 23 2021, 10:26 PM
gouttegd triaged this task as Normal priority.
gouttegd added a subscriber: gouttegd.

My bad, prior to the release I tested only against Qt5.

Yes, Qt4 should still be supported, no decision to abandon it has been made.

gouttegd added a subscriber: • aheinecke.Jan 24 2021, 12:49 AM

There’s a patch to restore support for Qt4: D521.

I would like input from other Pinentry developers (notably @aheinecke, who introduced the changes inadvertently leading to the loss of compatibility with Qt < 5) before applying it, as it touches parts of the code I am unfamiliar with.

• werner mentioned this in T4659: Release Pinentry-1.1.1.Jan 25 2021, 10:43 AM
gouttegd closed this task as Resolved.Jan 27 2021, 12:37 AM

Thanks @aheinecke for fixing my fix with 2859edd! Closing here.