Page MenuHome GnuPG
Create Task
Maniphest T5511

Kleopatra: Show "is this your own key" question for Smartcards somehow, too
Closed, ResolvedPublic
Actions

Description

When importing a secret key from a file Kleopatra shows this dialog:


(importcertificatescomannd.cpp handleHownerTrust)

The problem is that if you use our nice "plug and play" mechanism where we read key stubs automatically from a smartcard and pull the public key from ldap this does not show up. And the user then has to manually set the ownertrust when he wants to use certify.

As we dont necessarily have the attention of the user when a smartcard is inserted and the auto import is done I dont this a dialog at this place would be the proper solution.

A better Idea I think is that when we do "certify" and the key selected for the certification does not have ownertrust, we show a message with a similar question and some "do not ask again" checkbox.

I can't really see a usecase where you would want to do a certification with a key that has no ownertrust so we should assist the user in avoiding this.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO33b28a9783af Try hard to keep the currently selected key/item if the model changes
rLIBKLEO8749864110c6 Avoid emission of detailed model signals if model reset is in progress
rKLEOPATRA Kleopatra
rKLEOPATRA08d42db60ed5 Allow the user to set owner trust for the certification key

Event Timeline

aheinecke triaged this task as Normal priority.Jun 28 2021, 11:35 AM
aheinecke created this task.
aheinecke added a project: kleopatra.Jun 28 2021, 11:51 AM
ikloecker added a commit: rKLEOPATRA08d42db60ed5: Allow the user to set owner trust for the certification key.Jun 30 2021, 6:48 PM
ikloecker added a commit: rLIBKLEO8749864110c6: Avoid emission of detailed model signals if model reset is in progress.
ikloecker added a commit: rLIBKLEO33b28a9783af: Try hard to keep the currently selected key/item if the model changes.
ikloecker changed the task status from Open to Testing.Jun 30 2021, 6:54 PM
ikloecker reassigned this task from ikloecker to aheinecke.
ikloecker added a subscriber: ikloecker.

When selecting a certification key without ultimate trust the message "Is this your own key?" is shown.

After clicking "Set owner trust" the message changes to success message (if setting owner trust succeeded).

After a few seconds the status of the certification key updates and the message vanishes.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 30 2021, 6:54 PM
aheinecke awarded a token.Jul 1 2021, 8:30 AM
aheinecke added a comment.Jul 1 2021, 8:34 AM

Very cool, I like it especially that you avoided a popup and used that action mechanism.

ikloecker closed this task as Resolved.Oct 20 2021, 4:23 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 20 2021, 4:39 PM