Page MenuHome GnuPG
Create Task
Maniphest T5690

Kleopatra: Custom placeholder text in newcertificatewizard
Closed, ResolvedPublic
Actions

Description

Currently we take the username and e-mail on Windows from AD.

There are organizations where this is not the best because the e-mail does not match the actually used e-mail and users tend to click on continue without checking that. In that case it would be good if we could add a custom placeholder text in kleopatrarc and when this is set we would no longer take the value for which the placeholder is set from AD but instead use the placeholder as placeholder so that users are forced to fill that.

So that you can enter e.g. "Vorname Nachname" and "vorname.nachname@foocorp.org" as placeholders.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA2dd2f9820f55 Add setting to hide advanced options for new keys
rKLEOPATRA61dd7d8868b2 Allow prefilling of name/email for new certificates to be disabled
rKLEOPATRAaa694114b663 Allow specifying placeholder texts for name and email entry fields

Event Timeline

aheinecke triaged this task as Normal priority.Nov 15 2021, 2:05 PM
aheinecke created this task.
• werner added a subscriber: • werner.Nov 15 2021, 3:23 PM

Can you given a example on how this would look like. In particulr are placeholders some kind of forced template or just a grey background text?

aheinecke added a comment.Nov 16 2021, 9:49 AM

It would be the grey background text and no forced template, just as an input hint. And it would override the automatic detection of name / e-mail so that no wrong values are prefilled. This should help avoid unattentive users from creating a slightly wrong user id if their ad domain address does not match the e-mail.

ikloecker claimed this task.Nov 22 2021, 5:06 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a commit: rKLEOPATRAaa694114b663: Allow specifying placeholder texts for name and email entry fields.Nov 23 2021, 8:48 AM
ikloecker added a commit: rKLEOPATRA61dd7d8868b2: Allow prefilling of name/email for new certificates to be disabled.
ikloecker added a comment.Nov 23 2021, 8:58 AM

I have decided to use two different sets of settings for the placeholders and for controlling the prefilling of the values. Overloading the semantics of a specified placeholder text would have confused users and developers alike.

The placeholder texts can be specified by setting the config entries CN_placeholder, NAME_placeholder, and EMAIL_placeholder in the [CertificateCreationWizard] group in kleopatrarc.

Prefilling can be disabled by setting the config entries CN_prefill, NAME_prefill, and EMAIL_prefill to false in the [CertificateCreationWizard] group in kleopatrarc.

ikloecker changed the task status from Open to Testing.Nov 23 2021, 8:58 AM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a comment.Nov 23 2021, 9:15 AM

Example:

[CertificateCreationWizard]
CN_placeholder=Common Name
CN_prefill=false
EMAIL_placeholder=name@example.com
EMAIL_prefill=false
NAME_placeholder=Firstname Lastname
NAME_prefill=false
ikloecker removed ikloecker as the assignee of this task.Dec 3 2021, 7:46 PM
ikloecker added a subscriber: ikloecker.
aheinecke added a commit: rKLEOPATRA2dd2f9820f55: Add setting to hide advanced options for new keys.Dec 8 2021, 10:44 AM
aheinecke added a comment.Dec 8 2021, 10:44 AM

While testing I noticed that another requirement was to hide the advanced button. I have added this myself.

• ebo closed this task as Resolved.Jun 29 2023, 11:42 AM
• ebo claimed this task.
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo added a subscriber: • ebo.

works