Page MenuHome GnuPG
Create Task
Maniphest T5694

poly1305-s390x.S is compiled despite --disable-asm
Closed, ResolvedPublic
Actions

Description

--disable-asm works for MPI, but poly1305-s390x.S is still being compiled by libtool. I'd say that disable-asm should disable assembler across the board.

Details

Version
1.9.4

Revisions and Commits

rC libgcrypt
rC33f1a7ad3cd1 Do not build 'cipher/' assembly files when --disable-asm used
rCf10fa6b9a6ca Do not build poly1305-s390x.S on foreign architectures

Event Timeline

wrobelda created this task.Nov 15 2021, 10:16 PM
• werner triaged this task as Normal priority.Nov 16 2021, 1:10 PM
wrobelda added a comment.Nov 16 2021, 1:31 PM

Additionally, poly1305-s390x.S is being compiled despite running/targeting a PC system:

checking build system type... x86_64-pc-mingw32
checking host system type... i686-pc-mingw32

jukivili claimed this task.Nov 18 2021, 8:17 AM
jukivili added a comment.Nov 18 2021, 8:27 AM

Thanks for your report.

With --disable-asm assembly files under cipher/ may get compiled, however resulting object files are empty (or should be).

Following patch should solve issue of compiling poly1305-s390x.S on wrong architectures:

0001-Do-not-build-poly1305-s390x.S-on-foreign-architectur.patch1 KBDownload

jukivili added a comment.Nov 18 2021, 8:51 AM

Following patch should prevent assembly files being built at all with --disable-asm:

0001-Do-not-build-cipher-assembly-files-when-disable-asm-.patch20 KBDownload

jukivili added a commit: rCf10fa6b9a6ca: Do not build poly1305-s390x.S on foreign architectures.Nov 18 2021, 6:55 PM
jukivili added a commit: rC33f1a7ad3cd1: Do not build 'cipher/' assembly files when --disable-asm used.
jukivili closed this task as Resolved.Feb 24 2022, 6:05 PM