Page MenuHome GnuPG

jukivili (Jussi Kivilinna)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 27 2017, 4:48 PM (238 w, 6 d)
Availability
Available

Recent Activity

Sun, Oct 10

jukivili committed rC95425c6b0b96: cipher/sha256: fix 'accessing 32 bytes in a region of size 4' warnings (authored by jukivili).
cipher/sha256: fix 'accessing 32 bytes in a region of size 4' warnings
Sun, Oct 10, 8:38 AM

Wed, Oct 6

jukivili committed rC9fc0d145278d: Fix building for Win64 target (authored by jukivili).
Fix building for Win64 target
Wed, Oct 6, 6:16 PM

Sep 1 2021

jukivili added a comment to T5581: buf_eq_const() function in cipher/bufhelp.h may get wrong result.

Based on GCC bugzilla, affected released GCC versions are 11.1 and 11.2.

Sep 1 2021, 3:44 PM · toolchain, libgcrypt, Bug Report
jukivili added a comment to T5581: buf_eq_const() function in cipher/bufhelp.h may get wrong result.

(ab | ba) >= 0 is used to make optimization analysis for compiler more difficult. I see that with (ab | ba) == 0, it would be much easier for compiler to conclude than loop could exit early as soon as first a[i] != b[i] is seen.

Sep 1 2021, 3:39 PM · toolchain, libgcrypt, Bug Report

Aug 26 2021

jukivili committed rC47e425e07995: Add ARMv8-CE HW acceleration for GCM-SIV counter mode (authored by jukivili).
Add ARMv8-CE HW acceleration for GCM-SIV counter mode
Aug 26 2021, 8:19 PM
jukivili committed rC9e3b0446653f: mpi/longlong: fix variable shadowing from MIPS umul_ppmm macros (authored by jukivili).
mpi/longlong: fix variable shadowing from MIPS umul_ppmm macros
Aug 26 2021, 8:19 PM
jukivili committed rC33aebb30d210: Add x86 HW acceleration for GCM-SIV counter mode (authored by jukivili).
Add x86 HW acceleration for GCM-SIV counter mode
Aug 26 2021, 8:19 PM
jukivili committed rC1b8994c4ecf2: Add AES-GCM-SIV mode (RFC 8452) (authored by jukivili).
Add AES-GCM-SIV mode (RFC 8452)
Aug 26 2021, 8:19 PM
jukivili committed rC659a208cb065: Add SIV mode (RFC 5297) (authored by jukivili).
Add SIV mode (RFC 5297)
Aug 26 2021, 8:19 PM

Aug 13 2021

jukivili committed rCa5982e35088a: tests/bench-slope: allow non-FIPS ECC benchmarking in non-FIPS mode (authored by jukivili).
tests/bench-slope: allow non-FIPS ECC benchmarking in non-FIPS mode
Aug 13 2021, 2:01 PM

Jul 31 2021

jukivili claimed T4486: Add AEAD mode AES-SIV to libgcrypt (RFC 5297).
Jul 31 2021, 12:36 PM · Feature Request, libgcrypt

Jul 7 2021

jukivili committed rCb98ca3f798ab: tests/basic: use SHA256 instead of RMD160 for SHAKE extract testing (authored by jukivili).
tests/basic: use SHA256 instead of RMD160 for SHAKE extract testing
Jul 7 2021, 5:29 PM
jukivili added a comment to T5520: Fix tests in FIPS mode.

That crcalgo can be any digest algorithm and SHA256 seems best option to me.

Jul 7 2021, 5:29 PM · Testing, FIPS, libgcrypt, Bug Report

Jul 6 2021

jukivili committed rC69fdcb543323: ec: add zSeries/s390x accelerated scalar multiplication (authored by jukivili).
ec: add zSeries/s390x accelerated scalar multiplication
Jul 6 2021, 6:07 PM
jukivili committed rC4b76fa6a1f92: rinjdael-s390x: fix UBSAN warning on using index beyond end of array (authored by jukivili).
rinjdael-s390x: fix UBSAN warning on using index beyond end of array
Jul 6 2021, 6:07 PM
jukivili closed T5510: libgcrypt: incorrect computation for secp192r1 as Resolved.
Jul 6 2021, 6:02 PM · libgcrypt, Bug Report

Jul 2 2021

jukivili committed rC3f4a59299134: tests/t-mpi-point: add one more NIST P-256 reduction test-vector (authored by jukivili).
tests/t-mpi-point: add one more NIST P-256 reduction test-vector
Jul 2 2021, 12:49 AM
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Got a new bug with regression range ccfa9f2c1427b40483984198c3df41f8057f69f8:6dfab8cfb94ccb485a15b13df3c499cbb06fddf2

curve=23 secp256r1
point=04555555ffffffffffffffffffffffffffffffffffffffffffffffffffffffffff73a865e2e128733884fb82ce625ade822f7d8a59a4dcc09266966cf1bf082856
bignum=2020ff2020202020202020202020202020202020202020202020202020202020
nettle: 0 045549408909dd3e772d7d669f8fba2248d334b54be3d18833223d944a328948c76198ac3b29712256dcd9ce1a09471f04267684e1edd45910d61d0b7847db2d58
gcrypt: 0 047a6ec0df23082c8ce54c2b536d76b30464f4e1e690bb77665d298f05f0bee6806e7db3377141cc71ee30dcb8ffb7240bc3ecf29132ab5eb4ae03c067cea0d561
Jul 2 2021, 12:43 AM · libgcrypt, Bug Report

Jul 1 2021

jukivili committed rC9911069388e7: bench-slope: add X25519 and X448 scalar multiplication (authored by jukivili).
bench-slope: add X25519 and X448 scalar multiplication
Jul 1 2021, 5:38 PM
jukivili committed rC2fcac487069f: mpi: optimizations for MPI scanning and printing (authored by jukivili).
mpi: optimizations for MPI scanning and printing
Jul 1 2021, 5:38 PM
jukivili committed rCef676b9c14da: mpi/ec: cache converted field_table MPIs (authored by jukivili).
mpi/ec: cache converted field_table MPIs
Jul 1 2021, 5:38 PM
jukivili committed rC38d80fdfddd0: mpi_ec_get_affine: fast path for Z==1 case (authored by jukivili).
mpi_ec_get_affine: fast path for Z==1 case
Jul 1 2021, 5:38 PM
jukivili committed rC165237776389: tests/t-mpi-point: add reduction test-vectors for secp256k1 (authored by jukivili).
tests/t-mpi-point: add reduction test-vectors for secp256k1
Jul 1 2021, 5:38 PM

Jun 30 2021

jukivili committed rCfc92c609dfdb: ec-nist: fix 'mod p' carry adjustment and output masking (authored by jukivili).
ec-nist: fix 'mod p' carry adjustment and output masking
Jun 30 2021, 5:58 PM
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Thanks a lot.

Jun 30 2021, 4:54 PM · libgcrypt, Bug Report

Jun 28 2021

jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

P192, P224, P256 and P384 are affected.

Jun 28 2021, 10:03 PM · libgcrypt, Bug Report
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Attached patch should fix the issue:

Jun 28 2021, 8:03 PM · libgcrypt, Bug Report
jukivili added a comment to T5510: libgcrypt: incorrect computation for secp192r1.

Thanks for reporting. There is two commits in that commit range, including https://dev.gnupg.org/rC9d909cb67e70fd792926ac1e2ab305b2cc96bc27 which adds fast reduction for NIST curves. So obviously something is wrong there. Is secp192r1 only curve that is giving wrong results?

Jun 28 2021, 5:34 PM · libgcrypt, Bug Report

Jun 24 2021

jukivili committed rC6dfab8cfb94c: mpi/ec: add fast reduction for secp256k1 (authored by jukivili).
mpi/ec: add fast reduction for secp256k1
Jun 24 2021, 8:49 PM
jukivili committed rC9d909cb67e70: mpi/ec: add fast reduction functions for NIST curves (authored by jukivili).
mpi/ec: add fast reduction functions for NIST curves
Jun 24 2021, 8:49 PM

Jun 19 2021

jukivili committed rC9c12226c31d4: mpi/ec: small optimization for ec_mulm_25519 (authored by jukivili).
mpi/ec: small optimization for ec_mulm_25519
Jun 19 2021, 3:33 PM
jukivili committed rC9722da5bfc4a: mpi/longlong.h: fix missing macro parameter parentheses (authored by jukivili).
mpi/longlong.h: fix missing macro parameter parentheses
Jun 19 2021, 3:33 PM
jukivili committed rCccfa9f2c1427: mpi/ec: small optimization for ec_mulm_448 (authored by jukivili).
mpi/ec: small optimization for ec_mulm_448
Jun 19 2021, 3:33 PM
jukivili committed rCa0871a1e817f: tests/t-mpi-point: add NIST curve multiplication test vectors (authored by jukivili).
tests/t-mpi-point: add NIST curve multiplication test vectors
Jun 19 2021, 3:33 PM
jukivili committed rC57cf83834bc0: tests/bench-slope: add ECC benchmarking (authored by jukivili).
tests/bench-slope: add ECC benchmarking
Jun 19 2021, 3:33 PM
jukivili committed rCb53abf7905e0: tests/benchmark: add benchmark for Ed448 (authored by jukivili).
tests/benchmark: add benchmark for Ed448
Jun 19 2021, 3:33 PM

Jun 3 2021

jukivili committed rCec7db47e9998: Set vZZ.16b register to zero before use in armv8 gcm implementation (authored by larma).
Set vZZ.16b register to zero before use in armv8 gcm implementation
Jun 3 2021, 7:08 PM
jukivili committed rC761a1a0d30ea: Fix wrong code execution in Poly1305 ARM/NEON implementation (authored by jukivili).
Fix wrong code execution in Poly1305 ARM/NEON implementation
Jun 3 2021, 7:08 PM

May 17 2021

jukivili committed rC14bb6d4ea0dc: cipher: Fix memory leaks for EdDSA. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
cipher: Fix memory leaks for EdDSA.
May 17 2021, 9:01 PM
jukivili committed rCa1f5d87ed49b: Always include <config.h> in cipher assembly codes (authored by H.J. Lu <hjl.tools@gmail.com>).
Always include <config.h> in cipher assembly codes
May 17 2021, 9:01 PM

Apr 28 2021

jukivili committed rCec87511d9cd2: hwf-x86: fix use of wrong operand type (authored by jukivili).
hwf-x86: fix use of wrong operand type
Apr 28 2021, 8:52 PM

Apr 26 2021

jukivili committed rCeb96baf28473: hash_buffers: add output length param for XOF support (authored by jukivili).
hash_buffers: add output length param for XOF support
Apr 26 2021, 9:47 PM
jukivili committed rCe866c01e645d: keccak: add hash_buffers functions for SHAKE128 & SHAKE256 (authored by jukivili).
keccak: add hash_buffers functions for SHAKE128 & SHAKE256
Apr 26 2021, 9:47 PM
jukivili committed rC580ae61db5fe: md: remove hash_buffer function from algorithms (authored by jukivili).
md: remove hash_buffer function from algorithms
Apr 26 2021, 9:47 PM
jukivili committed rCf53d541d0947: Add XOF output support for internal _gcry_md_hash_buffers (authored by jukivili).
Add XOF output support for internal _gcry_md_hash_buffers
Apr 26 2021, 9:47 PM
jukivili committed rC4770ad72607f: Use memset for constant length wipememory2 (authored by jukivili).
Use memset for constant length wipememory2
Apr 26 2021, 9:47 PM
jukivili closed T5255: libgcrypt: build "error: invalid operand for instruction" when compiling with Clang & LTO as Resolved.
Apr 26 2021, 5:43 PM · asm, libgcrypt, clang, Bug Report

Apr 12 2021

jukivili committed rC9bc3d8de6e2a: mpi: harden add_n_cond, sub_n_cond and abs_cond against EM leakage (authored by jukivili).
mpi: harden add_n_cond, sub_n_cond and abs_cond against EM leakage
Apr 12 2021, 7:40 PM
jukivili committed rCc7c25b6e6e6b: mpi: harden set_cond functions against EM leakage (authored by jukivili).
mpi: harden set_cond functions against EM leakage
Apr 12 2021, 7:40 PM
jukivili committed rC1266f5bb02b7: mpi: harden swap_cond functions against EM leakage (authored by jukivili).
mpi: harden swap_cond functions against EM leakage
Apr 12 2021, 7:40 PM

Apr 6 2021

jukivili added a comment to T5369: GnuPG build on Apple with Clang.

Note that rndjent.c is already build with -O0 as can be seen in example above. That warning could be silenced by surrounding pragma with #ifdef __OPTIMIZE__ (with should be supported by GCC and Clang).

Apr 6 2021, 10:20 PM · libgcrypt, MacOS, Bug Report

Apr 1 2021

jukivili committed rCaaa30381eac3: cipher-gcm-ppc: add big-endian support (authored by jukivili).
cipher-gcm-ppc: add big-endian support
Apr 1 2021, 1:25 PM
jukivili committed rC1cf5a568f2b2: mpi/aarch64: use C_SYMBOL_NAME for assembly function names (authored by jukivili).
mpi/aarch64: use C_SYMBOL_NAME for assembly function names
Apr 1 2021, 12:38 PM

Mar 30 2021

jukivili updated subscribers of T5356: gnupg2 test failure on s390x.

@werner Can you comment about bugfix release?

Mar 30 2021, 4:50 PM · libgcrypt, Bug Report
jukivili added a comment to T5370: Apple M1 and Symbol not found: __gcry_mpih_mul_1.

These functions are internal to library and, for example, on linux/windows builds are not externally available.

Mar 30 2021, 4:48 PM · arm, MacOS, gnupg, Bug Report

Mar 29 2021

jukivili added a comment to T5370: Apple M1 and Symbol not found: __gcry_mpih_mul_1.

This patch should work if configure properly detects need for extra underscore on C symbols:

Mar 29 2021, 4:55 PM · arm, MacOS, gnupg, Bug Report

Mar 26 2021

jukivili committed rC56da81ac4720: tests/basic: add decryption check to check_ocb_cipher_checksum (authored by jukivili).
tests/basic: add decryption check to check_ocb_cipher_checksum
Mar 26 2021, 8:04 AM
jukivili committed rC68bb0ddc5504: rijndael-s390x: fix checksum calculation in OCB decryption (authored by jukivili).
rijndael-s390x: fix checksum calculation in OCB decryption
Mar 26 2021, 8:04 AM
jukivili committed rC21c273cecfd5: tests/basic: OCB large buffer check: make input buffer non-repeatable (authored by jukivili).
tests/basic: OCB large buffer check: make input buffer non-repeatable
Mar 26 2021, 8:04 AM

Mar 25 2021

jukivili added a comment to T5356: gnupg2 test failure on s390x.

Thanks for the report.

Mar 25 2021, 7:06 PM · libgcrypt, Bug Report
jukivili claimed T5356: gnupg2 test failure on s390x.
Mar 25 2021, 9:18 AM · libgcrypt, Bug Report

Mar 12 2021

jukivili updated the task description for T4460: libgcrypt performance TODOs.
Mar 12 2021, 5:32 PM · libgcrypt
jukivili closed T4531: PowerPC performance improvements as Resolved.
Mar 12 2021, 5:31 PM
jukivili closed T4531: PowerPC performance improvements, a subtask of T4460: libgcrypt performance TODOs, as Resolved.
Mar 12 2021, 5:31 PM · libgcrypt

Mar 9 2021

jukivili renamed T5040: Improve PPC code using code from CRYPTOGRAMs from Impove PPC code using code from CRYPTOGRAMs to Improve PPC code using code from CRYPTOGRAMs.
Mar 9 2021, 8:46 PM · legal, libgcrypt
jukivili closed T4630: libgcrypt: POWER GHASH Vector Acceleration as Resolved.
Mar 9 2021, 8:45 PM · Feature Request, libgcrypt
jukivili closed T4630: libgcrypt: POWER GHASH Vector Acceleration, a subtask of T4531: PowerPC performance improvements, as Resolved.
Mar 9 2021, 8:45 PM
jukivili committed rC760ef8baee06: cipher-gcm-ppc: tweak for better performance (authored by jukivili).
cipher-gcm-ppc: tweak for better performance
Mar 9 2021, 8:44 PM
jukivili committed rC43302b960f54: Compile arch specific GCM implementations only on target arch (authored by jukivili).
Compile arch specific GCM implementations only on target arch
Mar 9 2021, 8:44 PM
jukivili committed rC440332532a1c: VPMSUMD acceleration for GCM mode on PPC (authored by slandden).
VPMSUMD acceleration for GCM mode on PPC
Mar 9 2021, 8:44 PM
jukivili committed rC8892510bb8f4: configure.ac: fix digest implementations going to cipher list (authored by jukivili).
configure.ac: fix digest implementations going to cipher list
Mar 9 2021, 8:44 PM
jukivili added a comment to T4630: libgcrypt: POWER GHASH Vector Acceleration.

Pushed to master with two commits:

Mar 9 2021, 8:44 PM · Feature Request, libgcrypt

Mar 7 2021

jukivili added a comment to T5040: Improve PPC code using code from CRYPTOGRAMs.

I posted patch-set to mailing-list. Please check if AUTHORS/LICENSES updates are ok.
https://lists.gnupg.org/pipermail/gcrypt-devel/2021-March/005120.html

Mar 7 2021, 5:48 PM · legal, libgcrypt
jukivili added a comment to T5040: Improve PPC code using code from CRYPTOGRAMs.

I've cleaned up the patch from D501 and tweaked the implementation a bit for performance. Here's patches attached:

Mar 7 2021, 1:36 AM · legal, libgcrypt

Mar 6 2021

jukivili closed T5337: Missing hardware features in documentation as Resolved.

Fixed typos and applied to master. Thanks.

Mar 6 2021, 4:22 PM · Feature Request, patch, libgcrypt
jukivili committed rC7c4c992fe96f: src/hwfeatures: add reminder about documenting new HW features (authored by jukivili).
src/hwfeatures: add reminder about documenting new HW features
Mar 6 2021, 2:54 PM
jukivili committed rC49ab649c6995: doc: Document newly added optimizations (authored by Jakuje).
doc: Document newly added optimizations
Mar 6 2021, 2:54 PM
jukivili claimed T5337: Missing hardware features in documentation.
Mar 6 2021, 2:52 PM · Feature Request, patch, libgcrypt

Mar 3 2021

jukivili committed rCd1fcf3975c57: cipher-gcm-intel-pclmul: fix compiling with i386 gcc-4.7 (authored by jukivili).
cipher-gcm-intel-pclmul: fix compiling with i386 gcc-4.7
Mar 3 2021, 6:21 PM
jukivili committed rC2b84da922660: poly1305: make --disable-asm work on x86, aarch64 and ppc (authored by jukivili).
poly1305: make --disable-asm work on x86, aarch64 and ppc
Mar 3 2021, 6:21 PM
jukivili committed rCbcb180190e89: poly1305: fix compiling on i386 gcc-4.7 (authored by jukivili).
poly1305: fix compiling on i386 gcc-4.7
Mar 3 2021, 6:21 PM
jukivili committed rCe72498a54fde: rijndael: add x86_64 VAES/AVX2 accelerated implementation (authored by jukivili).
rijndael: add x86_64 VAES/AVX2 accelerated implementation
Mar 3 2021, 6:14 PM
jukivili committed rC0e7e60241a0d: camellia: add x86_64 VAES/AVX2 accelerated implementation (authored by jukivili).
camellia: add x86_64 VAES/AVX2 accelerated implementation
Mar 3 2021, 6:14 PM
jukivili committed rCffe1d5319703: rijndael-aesni: add 8-block parallel code path for XTS (authored by jukivili).
rijndael-aesni: add 8-block parallel code path for XTS
Mar 3 2021, 6:14 PM
jukivili committed rCeb404d890453: hwf-x86: add "intel-vaes-vpclmul" HW feature (authored by jukivili).
hwf-x86: add "intel-vaes-vpclmul" HW feature
Mar 3 2021, 6:14 PM

Feb 12 2021

jukivili updated subscribers of rC3f42f727a069: Make sure the grcy_get_config string is always null-terminated..
Feb 12 2021, 4:16 PM

Feb 6 2021

jukivili closed T5256: libgcrypt, convert Intel syntax x86_64 assembly files to AT&T syntax as Resolved.

Problem with clang and these files was resolved by replacement of assembler macros with C preprocessor macros.

Feb 6 2021, 12:47 PM · asm, clang, libgcrypt
jukivili closed T5256: libgcrypt, convert Intel syntax x86_64 assembly files to AT&T syntax, a subtask of T5255: libgcrypt: build "error: invalid operand for instruction" when compiling with Clang & LTO, as Resolved.
Feb 6 2021, 12:47 PM · asm, libgcrypt, clang, Bug Report

Feb 4 2021

jukivili added a comment to rC8716e4b2ada2: global: make sure that bulk config string is null-terminated.

The 'what != NULL' case is handled by the "Strip trailing LF" part at the end of function. These data strings always end with '\n', so null-termination gets done there.

Feb 4 2021, 4:44 PM

Feb 3 2021

jukivili committed rC24af2a55d862: sha256-avx2: fix reading beyond end of input buffer (authored by jukivili).
sha256-avx2: fix reading beyond end of input buffer
Feb 3 2021, 5:47 PM
jukivili committed rC8716e4b2ada2: global: make sure that bulk config string is null-terminated (authored by jukivili).
global: make sure that bulk config string is null-terminated
Feb 3 2021, 5:47 PM
jukivili committed rCa71b7de32b0c: Add handling for -Og with O-flag munging (authored by jukivili).
Add handling for -Og with O-flag munging
Feb 3 2021, 5:47 PM
jukivili committed rC289543544e41: ecc-ecdh: fix memory leak (authored by jukivili).
ecc-ecdh: fix memory leak
Feb 3 2021, 5:47 PM
jukivili committed rCf46a6bd9b3d7: tests: allow running 'make check' with ASAN (authored by jukivili).
tests: allow running 'make check' with ASAN
Feb 3 2021, 5:47 PM
jukivili committed rC6fc11291282a: jent: silence ubsan warning about signed overflow (authored by jukivili).
jent: silence ubsan warning about signed overflow
Feb 3 2021, 5:47 PM
jukivili committed rC364e9e9d1050: Fix ubsan warnings for i386 build (authored by jukivili).
Fix ubsan warnings for i386 build
Feb 3 2021, 5:47 PM
jukivili committed rCcb95fc53003e: md: clear bctx.count at final function (authored by jukivili).
md: clear bctx.count at final function
Feb 3 2021, 5:47 PM
jukivili committed rCaf23ab5c5482: Fix building with --disable-asm on x86 (authored by jukivili).
Fix building with --disable-asm on x86
Feb 3 2021, 5:47 PM

Jan 31 2021

jukivili added a comment to T5157: libgcrypt: ARM64 Builds on macOS fail.

Does it build if configure with parameter 'ac_cv_sys_symbol_underscore=yes'? <path-to-libgcrypt-source>/configure ac_cv_sys_symbol_underscore=yes --host=aarch64-apple-darwin ...

Jan 31 2021, 7:32 PM · toolchain, MacOS, libgcrypt, Bug Report

Jan 29 2021

jukivili added a comment to T5277: libgcrypt 1.9.1 fails to build with --disable-asm.

Thanks for your report.

Jan 29 2021, 5:22 PM · MacOS, libgcrypt, Bug Report