Page MenuHome GnuPG
Create Task
Maniphest T7175

libgcrypt 1.11.0 fails to build on 32bit Windows with Clang
Closed, ResolvedPublic
Actions

Description

1.10.3 builds fine with the same toolchain

1.11.0 fails with:

hwf-x86.c:60:14: error: this directive must appear between .cfi_startproc and .cfi_endproc directives
   60 |     ("pushf\n\t"                 /* Copy flags to EAX.  */
      |              ^

Downstream issue: https://github.com/msys2/MINGW-packages/pull/21202

Full build log: https://gist.github.com/lazka/82f0efc163b9b62beb5375c04501d381

Details

Version
1.11.0

Revisions and Commits

rC libgcrypt
rC26a462925e22 src/hwf-x86: disable inline assembly CFI directivies for WIN32

Event Timeline

lazka created this task.Jun 21 2024, 4:19 PM
lazka added a subscriber: jukivili.Jun 21 2024, 7:11 PM

seems to be related to https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=a5f88f30ce612b0239b946c4424d81cf0d552e96

@jukivili since you worked on that, do you have any ideas by any chance? thanks

jukivili added a comment.Jun 22 2024, 2:57 PM

Hm, CFI directives should not be used on WIN32 target. This patch should solve the issue for now:

0001-src-hwf-x86-disable-inline-assembly-CFI-directivies-.patch984 BDownload

jukivili added a comment.Jun 22 2024, 3:00 PM

I tried to reproduce issue with clang/w32 toolchain from https://github.com/mstorsjo/llvm-mingw but there build worked even with CFI directives.

• werner triaged this task as Low priority.Jun 22 2024, 5:01 PM
• werner added projects: libgcrypt, Windows, clang.
• werner added a subscriber: • werner.

Using clang for Windows is not tested or suggested. Thus low priority.

lazka added a comment.Jun 23 2024, 9:20 AM
In T7175#187690, @jukivili wrote:

Hm, CFI directives should not be used on WIN32 target. This patch should solve the issue for now:

0001-src-hwf-x86-disable-inline-assembly-CFI-directivies-.patch984 BDownload

Thanks, I can confirm that this fixes things.

jukivili added a commit: rC26a462925e22: src/hwf-x86: disable inline assembly CFI directivies for WIN32.Jun 23 2024, 4:42 PM
jukivili closed this task as Resolved.Jun 24 2024, 6:40 AM
jukivili claimed this task.