Page MenuHome GnuPG
Create Task
Maniphest T5822

libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1)
Closed, ResolvedPublic
Actions

Description

EXTRA_ALIGN should be fixed, to match ABI of the machine.

In C11, we have max_align_t.
Usually, it's long double.

Revisions and Commits

rC libgcrypt
rC738723a1cd20 Clean up for removal of memory guard support.
rCf98ca6aa34cc Remove the built-in memory guard support.
rC90f41a1898e4 Fix memory allocation when GCRYCTL_ENABLE_M_GUARD.

Related Objects

Event Timeline

• gniibe created this task.Feb 9 2022, 2:09 AM
• gniibe mentioned this in rC59b2504df8f0: kdf: fix unaligned memory access in balloon_xor_block.Feb 9 2022, 2:11 AM
• gniibe added a commit: rC90f41a1898e4: Fix memory allocation when GCRYCTL_ENABLE_M_GUARD..Feb 9 2022, 2:57 AM
• gniibe claimed this task.Feb 9 2022, 2:58 AM
• gniibe added projects: Restricted Project, libgcrypt, Bug Report.
• gniibe added a comment.Feb 9 2022, 12:33 PM

Instead, let us remove the feature.

• gniibe renamed this task from libgcrypt: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1 to libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).Feb 10 2022, 1:19 AM
• gniibe added a comment.Feb 10 2022, 1:32 AM

It was addressed in rC04f325d8917d: released 1.1.4 as "(obsolete)" feature, in Aug 2001.

• gniibe added a commit: rC738723a1cd20: Clean up for removal of memory guard support..Feb 10 2022, 1:56 AM
• gniibe added a commit: rCf98ca6aa34cc: Remove the built-in memory guard support..
• gniibe triaged this task as Normal priority.Feb 18 2022, 1:01 AM
• werner changed the task status from Open to Testing.Sep 22 2022, 11:01 AM
• werner removed a project: Restricted Project.
• werner mentioned this in T7165: Release Libgcrypt 1.11.0.Jun 19 2024, 11:37 AM
• werner closed this task as Resolved.Jun 19 2024, 12:12 PM