Page MenuHome GnuPG
Create Task
Maniphest T5850

Kleopatra: "Show not certified certificates" button shows any not fully valid certificates
Closed, ResolvedPublic
Actions

Description

Kleopatra shows a "Show not certified certificates" button next to the filter drop-down if there are any certificates that are not fully valid. Clicking this button selects the "Not Validated Certificates" filter in the drop-down. This filter shows any not valid certificates including certificates that have expired or that have been revoked.

I don't think that's the intention of the button. The tool-tip of the button suggests that it wants to support the user to find certificate the user has not yet certified. Also showing expired or revoked certificates makes no sense because, unless those certificates belong to the user, they can do nothing to validate those certificates.

I think clicking the button should activate a filter that lists certificates that are "good" (i.e. not revoked, expired, etc.), but that are not fully valid.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO7d37b6391578 Add default filter for "good", uncertified OpenPGP keys
rKLEOPATRA Kleopatra
rKLEOPATRAb6f570f57fbd Use the key filter to check for an uncertified OpenPGP key
rKLEOPATRAe3fba1dd4dc5 Use the key cache instead of running our own keylist job
rKLEOPATRA6ef300c6c7c2 Show "good" but not certified keys instead of any not valid keys

Event Timeline

ikloecker created this task.Feb 21 2022, 9:28 AM
• werner added a subscriber: • werner.Feb 25 2022, 4:32 PM

I tend to agree

ikloecker added a subscriber: aheinecke.Mar 16 2022, 4:52 PM

@aheinecke What do you think?

aheinecke added a comment.Mar 16 2022, 5:09 PM

Yes, makes more sense to me, too. Maybe another filter "bad" certificates, so that you can bulk delete them for example to clean up your keyring?

But that is unrelated, feel free to make the change.

ikloecker claimed this task.Mar 17 2022, 10:13 AM
ikloecker triaged this task as Normal priority.
ikloecker added a commit: rLIBKLEO7d37b6391578: Add default filter for "good", uncertified OpenPGP keys.Mar 17 2022, 2:58 PM
ikloecker added a commit: rKLEOPATRA6ef300c6c7c2: Show "good" but not certified keys instead of any not valid keys.
ikloecker added a commit: rKLEOPATRAe3fba1dd4dc5: Use the key cache instead of running our own keylist job.
ikloecker added a commit: rKLEOPATRAb6f570f57fbd: Use the key filter to check for an uncertified OpenPGP key.
ikloecker changed the task status from Open to Testing.Mar 17 2022, 3:06 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

There is a new key filter "Not certified certificates" that is selected if the button is pressed.

• ebo closed this task as Resolved.Nov 30 2022, 4:00 PM
• ebo claimed this task.
• ebo added a subscriber: • ebo.

works

• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 5 2023, 2:55 PM