Page MenuHome GnuPG
Create Task
Maniphest T5893

Patches to compile pinentry-1.2.0 cleanly with mingw.org's MinGW
Closed, ResolvedPublic
Actions

Description

The patches attached below fix several minor issues with building pinentry with mingw.org's MinGW on MS-Windows:

  • symlink command that's part of "make install" that fails to use $(EXEEXT) on the target
  • unnecessary inclusion of iconv.h and langinfo.h in pinentry-curses.c, which fails the compilation when these headers are not available
  • compilation warning in pinentry-curses.c due to type mismatch
  • a simple replacement for the missing nl-langinfo function in pinentry.c
  • compiler warnings in secmem.c due to variables used only in some configurations
  • link error buulding pinentry-w32.exe because libiconv is not on the link command line

DIFFS2 KBDownload

Revisions and Commits

rP Pinentry
rP9a8a38d28d36 build,w32: Fix build on Windows.
rP41884436bec0 w32,curses: Supply simple replacement for nl_langinfo.

Related Objects

Event Timeline

eliz created this task.Mar 21 2022, 6:59 PM
• gniibe claimed this task.Mar 24 2022, 7:28 AM
• gniibe triaged this task as Normal priority.
• gniibe added projects: pinentry, Windows.
• gniibe added a subscriber: • gniibe.

Thank you for your report.

Firstly, I'm going to apply a part of Makefile and secmem.c.

• gniibe added a comment.EditedMar 24 2022, 8:19 AM

And I move functions from pinentry.c to pinentry-curses.c, so that pinentry-w32.exe can be build with no libiconv (which is actually not used).

Then, I appy nl_langinfo function to pinentry-curses.c.

I don't apply newterm type mismatch thing, as it's because of compatibility of curses library. (I confirmed that NetBSD curses uses char * for the first argument. Ncurses uses const char *)

• gniibe added a commit: rP9a8a38d28d36: build,w32: Fix build on Windows..Mar 24 2022, 8:45 AM
• gniibe added a commit: rP41884436bec0: w32,curses: Supply simple replacement for nl_langinfo..
• gniibe added a project: Restricted Project.Mar 25 2022, 2:13 AM
• gniibe closed this task as Resolved.Aug 25 2022, 3:11 AM
• gniibe removed a project: Restricted Project.

Fixed in 1.2.1.

• werner mentioned this in T5566: Release Pinentry 1.2.x.Mar 18 2024, 12:20 PM