Page MenuHome GnuPG
Create Task
Maniphest T6271

The old FSF address in libgcrypt source code
Testing, LowPublic
Actions

Description

The libgcrypt sources still have at many places the old FSF address, which was recently pointed to me by Fedora rpmlint:

libgcrypt (master)]$  git grep "Temple Place" | wc -l
152

This is probably not a huge issue, but as it was already fixed in other code previously, it would be great to clean up also in libgcrypt.

For the record, there are still some files with this address in GnuGP too:

gnupg (master)]$  git grep "Temple Place" | wc -l
11

https://dev.gnupg.org/rKLEOPATRA97f2b05c7e096e989ed824cee4ce23c406433285
https://dev.gnupg.org/rGf98537733ac96fd7e786286944fd3c2696229c4f
https://dev.gnupg.org/rG7d4043ca57f75c7a9461bbaf5754396531ab7d85

Details

External Link
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Version
master

Revisions and Commits

rC libgcrypt
rCf5284460ac4c Update copyright notices to use URL.

Related Objects

Event Timeline

Jakuje created this task.Nov 10 2022, 11:57 AM
• werner triaged this task as Low priority.Nov 10 2022, 12:25 PM
• werner added a project: Documentation.
• werner added a subscriber: • werner.

Thanks. There should also be SPDX indentifiers everywhere.

• gniibe added a subscriber: • gniibe.Nov 29 2022, 2:46 AM

Modern way for license notice seems use of URL: https://www.gnu.org/prep/maintain/maintain.html#License-Notices-for-Code
https://www.gnu.org/licenses/gpl-howto.html

ikloecker added a subscriber: ikloecker.Nov 29 2022, 9:09 AM

Well, the modern way, recommended by the FSFE, for license notices in source files is SPDX instead of verbose license notices. https://reuse.software/

• gniibe added a commit: rCf5284460ac4c: Update copyright notices to use URL..Apr 27 2023, 7:06 AM
• gniibe changed the task status from Open to Testing.Apr 27 2023, 7:09 AM
• gniibe claimed this task.

Fixed for libgcrypt, updating copyright notices and license files.

Jakuje added a comment.Jun 12 2023, 4:11 PM

FYI, while going through the licenses again I noticed one of the pinentry files have even older address that so if you would do sed, this would not be matched:

https://git.gnupg.org/cgi-bin/gitweb.cgi?p=pinentry.git;a=blob;f=efl/pinentry-efl.c;h=58796ba1fb153e68d9f93c44b133e30b79f80375;hb=HEAD

• gniibe added a comment.Jun 13 2023, 3:10 AM

Thanks. I think that it was the oldest one: FSF used to be there in Cambridge, then moved to Tremont St. in Boston, and now it's in Franklin St.

I'll try to fix those license things for other gpg related software.

• gniibe added a comment.Jul 20 2023, 6:56 AM

Fixed in: rP66abf7cb1e1b: Update GPL2 for new FSF address. Use URL for license.