Page MenuHome GnuPG
Create Task
Maniphest T6380

Kleopatra: SignEncryptWidget::isDeVsAndValid does not skip revoked UIds
Closed, ResolvedPublic
Actions

Description

We have the problem again that revoked UIDs are not ignored by the validity check in isDeVsAndValid.

I wonder if we should make a function that combines isKeyDeVs and uidsHaveFullValidity.

As we skip revoked Uids I wonder if we should not also skip invalid UserIds, because we would never use them.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO93ea0bde0ad6 Remove duplicate keyValidity helper
rLIBKLEOe0e4b2bff211 Make the key resolver reject not fully valid keys in compliance mode
rLIBKLEO8400035eedd5 Simplify checking keys for compliance with de-vs mode
rLIBKLEO257c62365032 Move Formatting::isKeyDeVs to compliance
rLIBKLEO222614e5450c Move Formatting::uidsHaveFullValidity to keyhelpers
rKLEOPATRA Kleopatra
rKLEOPATRAc4c9e6fbd089 Use new helper function
rKLEOPATRA1d70e822f9ea Use new keyIsCompliant helper to unify compliance check

Event Timeline

• aheinecke triaged this task as High priority.Feb 17 2023, 3:21 PM
• aheinecke created this task.
• ikloecker claimed this task.Mar 16 2023, 10:43 AM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a commit: rLIBKLEO222614e5450c: Move Formatting::uidsHaveFullValidity to keyhelpers.Mar 17 2023, 12:56 PM
• ikloecker added a commit: rLIBKLEO257c62365032: Move Formatting::isKeyDeVs to compliance.
• ikloecker added a commit: rLIBKLEO8400035eedd5: Simplify checking keys for compliance with de-vs mode.
• ikloecker added a commit: rLIBKLEOe0e4b2bff211: Make the key resolver reject not fully valid keys in compliance mode.
• ikloecker added a commit: rLIBKLEO93ea0bde0ad6: Remove duplicate keyValidity helper.Mar 17 2023, 2:15 PM
• ikloecker added a commit: rKLEOPATRAc4c9e6fbd089: Use new helper function.Mar 17 2023, 2:18 PM
• ikloecker added a commit: rKLEOPATRA1d70e822f9ea: Use new keyIsCompliant helper to unify compliance check.
• ikloecker changed the task status from Open to Testing.Mar 17 2023, 2:31 PM
• ikloecker removed • ikloecker as the assignee of this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a subscriber: • ikloecker.

We are now using the new helper DeVSCompliance::keyIsCompliant everywhere where previously isKeyDeVs and uidsHaveFullValidity were used or should have been used (as in SignEncryptWidget::isDeVsAndValid).

• ebo added a project: gpgol.Apr 19 2023, 9:44 AM
• ebo closed this task as Resolved.Apr 19 2023, 3:21 PM
• ebo claimed this task.
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo added a subscriber: • ebo.

works, a key with a revoked uid is accepted as VS-NfD compliant, VS-Desktop-3.1.27.0-beta44