Move Formatting::isKeyDeVs to compliance
257c62365032
Actions

Description

Move Formatting::isKeyDeVs to compliance

Rename it to allSubkeysAreCompliant to make it clearer what it checks.
And rewrite it, so that it doesn't return true for keys without any
usable subkeys. Adapt creation of test keys in NewKeyApprovalDialogTest,
so that the test still passes.

GnuPG-bug-id: T6380

Details

Provenance

ikloecker

Authored on Mar 17 2023, 10:30 AM

Parents

rLIBKLEO222614e5450c: Move Formatting::uidsHaveFullValidity to keyhelpers

Branches

Unknown

Tags

Unknown

Tasks

T6380: Kleopatra: SignEncryptWidget::isDeVsAndValid does not skip revoked UIds

Event Timeline

ikloecker committed rLIBKLEO257c62365032: Move Formatting::isKeyDeVs to compliance (authored by ikloecker).Mar 17 2023, 12:55 PM

ikloecker added a task: T6380: Kleopatra: SignEncryptWidget::isDeVsAndValid does not skip revoked UIds.

Changes (9)

Path

Size

autotests/

newkeyapprovaldialogtest.cpp

src/

kleo/

defaultkeyfilter.cpp

keyresolvercore.cpp

ui/

keyrequester.cpp

newkeyapprovaldialog.cpp

utils/

rLIBKLEO257c62365032

View Options

autotests/newkeyapprovaldialogtest.cpp

View Options

src/kleo/defaultkeyfilter.cpp

View Options

src/kleo/keyresolvercore.cpp

View Options

src/ui/keyrequester.cpp

View Options

src/ui/newkeyapprovaldialog.cpp

View Options

src/utils/algorithm.h

View Options

src/utils/compliance.cpp

View Options

src/utils/compliance.h

View Options

Move Formatting::isKeyDeVs to compliance257c62365032Actions

Description

Details

Event Timeline

Changes (9)

rLIBKLEO257c62365032

autotests/newkeyapprovaldialogtest.cpp

src/kleo/defaultkeyfilter.cpp

src/kleo/keyresolvercore.cpp

src/ui/keyrequester.cpp

src/ui/newkeyapprovaldialog.cpp

src/utils/algorithm.h

src/utils/compliance.cpp

src/utils/compliance.h

src/utils/formatting.cpp

Move Formatting::isKeyDeVs to compliance
257c62365032
Actions