Page MenuHome GnuPG

Kleopatra / Gpgtar: Cancel does not kill the job
Closed, ResolvedPublic

Description

Hi,
I consider this a release blocker issue. I started a job to encrypt 10gb, considered this too slow and aborted.
Task manager shows this is still running.

We also need to make sure that any temporary files are deleted after such a cancel.

Event Timeline

aheinecke triaged this task as Unbreak Now! priority.Jun 9 2023, 12:14 PM
aheinecke created this task.

The processes should now be killed properly.

With regard to the temporary files, we are using QTemporaryFile which should just work.

ikloecker changed the task status from Open to Testing.Jun 9 2023, 3:56 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker added a subscriber: ikloecker.
aheinecke changed the task status from Testing to Open.Jun 9 2023, 4:36 PM
aheinecke moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

As I already had my testsetup open I recompiled with your change and I tested manually cancelling and letting it run into the disk full error. In both cases the temporary file was deleted and the job was cancelled :)

But :) Same problem exists on the other side. Decrypting still has the issue.

ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Of course, those are different controllers. :-)

ikloecker changed the task status from Open to Testing.Jun 9 2023, 5:34 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
werner lowered the priority of this task from Unbreak Now! to High.Jun 15 2023, 2:02 PM
werner removed a project: gpgtar.
ebo changed the task status from Testing to Open.Jun 23 2023, 4:34 PM
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ebo added a subscriber: ebo.

cancelling decryption does not work yet on windows

I have tested this with a self-built installer from a few minutes ago in my Windows VM. Whenever I canceled decryption (I tried it about 5 times), then the gpgtar process went away very quickly. The gpg process keeps running, but that's a bug in gpgtar: T6558: gpgtar: Does not stop spawned gpg process when exiting.

ikloecker changed the task status from Open to Testing.Jun 23 2023, 4:44 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I hate this ping-pong, but, as I wrote in my previous comment, for me canceling decryption does work on Windows, i.e. the gpgtar process does not keep running for a long time. That the gpg process keeps running is nothing Kleopatra can do anything about.

If you make different observations, then you need to provide logs of gpgme and kleopatra.

When testing this I noticed that the cancel does not seem to have an effect on normal file jobs run directly through Kleo either: T6560 This is probably not a regression as you fixed here that the cancel is even propagated to the jobs but still I find that disturbing and buggy.

ikloecker changed the task status from Testing to Open.Jun 26 2023, 10:00 AM
ikloecker claimed this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ikloecker changed the task status from Open to Testing.Jun 26 2023, 12:16 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Finally, canceling decrypt/verify should also work properly.

ebo claimed this task.
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

works, the processes are stopped.
For the removal of the unfinished archive on cancelling encryption see T6584.