Hi,
I consider this a release blocker issue. I started a job to encrypt 10gb, considered this too slow and aborted.
Task manager shows this is still running.
We also need to make sure that any temporary files are deleted after such a cancel.
Description
Description
Revisions and Commits
Revisions and Commits
| rKLEOPATRA Kleopatra | |||
| rKLEOPATRA20405b699261 Actually cancel the job when the task is canceled | |||
| rKLEOPATRA6ca603ffe60c Cancel decryption/verification tasks when user cancels the operation | |||
| rKLEOPATRA8f6c4d45c244 Cancel decryption/verification tasks when user cancels the operation | |||
| rKLEOPATRAb3895166022f Cancel tasks when user cancels operation | |||
| rKLEOPATRA4a5d24c40d1f Cancel tasks when user cancels operation | |||
Related Objects
Related Objects
- Mentioned In
- T6584: Kleopatra / Gpgtar: Cancel on encrypt leaves a broken archive behind
T6558: gpgtar: Does not stop spawned gpg process when exiting - Mentioned Here
- T6584: Kleopatra / Gpgtar: Cancel on encrypt leaves a broken archive behind
T6560: Kleopatra: Cancel does not kill GnuPG
T6558: gpgtar: Does not stop spawned gpg process when exiting
Event Timeline
Comment Actions
The processes should now be killed properly.
With regard to the temporary files, we are using QTemporaryFile which should just work.
Comment Actions
As I already had my testsetup open I recompiled with your change and I tested manually cancelling and letting it run into the disk full error. In both cases the temporary file was deleted and the job was cancelled :)
But :) Same problem exists on the other side. Decrypting still has the issue.
Comment Actions
I have tested this with a self-built installer from a few minutes ago in my Windows VM. Whenever I canceled decryption (I tried it about 5 times), then the gpgtar process went away very quickly. The gpg process keeps running, but that's a bug in gpgtar: T6558: gpgtar: Does not stop spawned gpg process when exiting.
Comment Actions
I hate this ping-pong, but, as I wrote in my previous comment, for me canceling decryption does work on Windows, i.e. the gpgtar process does not keep running for a long time. That the gpg process keeps running is nothing Kleopatra can do anything about.
If you make different observations, then you need to provide logs of gpgme and kleopatra.
Comment Actions
When testing this I noticed that the cancel does not seem to have an effect on normal file jobs run directly through Kleo either: T6560 This is probably not a regression as you fixed here that the cancel is even propagated to the jobs but still I find that disturbing and buggy.
Comment Actions
works, the processes are stopped.
For the removal of the unfinished archive on cancelling encryption see T6584.