Page MenuHome GnuPG
Create Task
Maniphest T6698

Kleopatra: Not all User IDs tagged with chosen tag selected when certifying a certificate
Closed, ResolvedPublic
Actions

Description

Prerequisites:

  • An OpenPGP key A with at least 3 user IDs, e.g. A1, A2, A3
  • Another OpenPGP key C (used as certification certificate)
  • "Show tags attached to certificates" is enabled

How to reproduce:

  1. Certify A1 and A3 with tag "tagC1" with certification certificate C.
  2. Certify A2 with tag "tagC2" with certification certificate C.
  3. Select certificate A and chose "Certify".

Expected:
Certify dialog opens and user IDs A1 and A3 are checked (and the (hidden) Tags field is prefilled with "tagC1").

Actual:
Certify dialog opens and only user ID A3 is checked (and the (hidden) Tags field is prefilled with "tagC1").

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAd44cfb0f8039 Fix selection of all user IDs with tags matching Tags value

Related Objects

Event Timeline

ikloecker claimed this task.Sep 1 2023, 4:01 PM
ikloecker triaged this task as Normal priority.
ikloecker created this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
aheinecke added a subscriber: aheinecke.Sep 1 2023, 4:15 PM

Yes remove this / leave this empty. I think the idea was that if you certify lots of users and wanted to have the same tag. But I guess that would be covered by bulk signing anyway and can actually be more trouble if you accidentally use the wrong tag.

aheinecke added a comment.Sep 1 2023, 4:39 PM

At least GnuPG only shows the most recent key signature tag. So if we leave it out when adding another signature then we remove this.

A solution I can think of that would be privacy respecting and user friendly would be to "If exportable is checked and any keys have text: Ask the user if the tags should be kept and then also include them in the new key sig, and otherwise remove them.Maybe with a don't ask again.
Since tags are kind of an advanced feature that I don't think is used by many but loved by some. So I think the vast majority of users won't see such a dialog.

ikloecker added a commit: rKLEOPATRAd44cfb0f8039: Fix selection of all user IDs with tags matching Tags value.Sep 1 2023, 5:11 PM
ikloecker changed the task status from Open to Testing.Sep 1 2023, 5:13 PM
ikloecker removed ikloecker as the assignee of this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Fixed. I'll copy the ideas in comment T6698#175165 to a separate task.

ikloecker mentioned this in T6699: Kleopatra: Ask for confirmation when overwriting existing tags during certification.Sep 1 2023, 5:18 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 4 2023, 4:37 PM
• ebo added a subscriber: • ebo.

Works, the expected behavior from the description is shown.

Though I do not understand why tagC1 is chosen, which was the first to be added.

ikloecker closed this task as Resolved.Oct 4 2023, 5:56 PM
ikloecker claimed this task.
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

The tag of the last displayed user ID that has a tag is chosen. And that's tag tagC1 in the above scenario.

Closing as fixed according to the previous comment.